From 73921052970fb4416a25d037c88466a801092ef0 Mon Sep 17 00:00:00 2001 From: Marcus Huderle Date: Sat, 27 Jun 2020 17:14:37 -0500 Subject: [PATCH] Early exit magic fill if it would be a no-op --- src/ui/mappixmapitem.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/ui/mappixmapitem.cpp b/src/ui/mappixmapitem.cpp index d6f4b2c4..7fec4421 100644 --- a/src/ui/mappixmapitem.cpp +++ b/src/ui/mappixmapitem.cpp @@ -322,6 +322,11 @@ void MapPixmapItem::magicFill( bool fromScriptCall) { Block *block = map->getBlock(initialX, initialY); if (block) { + if (selectedMetatiles->length() == 1 && selectedMetatiles->value(0) == block->tile) { + logInfo("early exit"); + return; + } + bool setCollisions = selectedCollisions && selectedCollisions->length() == selectedMetatiles->length(); uint16_t tile = block->tile; for (int y = 0; y < map->getHeight(); y++) {