atiran/porymap
3
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Fix metatile selector rectangle jumping

Browse source
This commit is contained in:
GriffinR 2024-01-04 21:22:10 -05:00
parent 28831a7ff0
commit 8c85209d53
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.md
View file

@ -16,6 +16,7 @@ The **"Breaking Changes"** listed below are changes that have been made in the d
- Metatile ID strings are now padded to their current max, not the overall max. - Metatile ID strings are now padded to their current max, not the overall max.
### Fixed ### Fixed
- Fix the metatile selector rectangle jumping when selecting up or left of the origin.
- Fix the event group tabs sometimes showing an event from the wrong group - Fix the event group tabs sometimes showing an event from the wrong group
- Fix API error reporting - Fix API error reporting

6
src/ui/metatileselector.cpp
View file

@ -4,7 +4,9 @@
#include <QPainter> #include <QPainter>
QPoint MetatileSelector::getSelectionDimensions() { QPoint MetatileSelector::getSelectionDimensions() {
return selection.dimensions; if (this->prefabSelection || this->externalSelection)
return selection.dimensions;
return SelectablePixmapItem::getSelectionDimensions();
} }
void MetatileSelector::draw() { void MetatileSelector::draw() {
@ -155,7 +157,7 @@ void MetatileSelector::updateSelectedMetatiles() {
this->selection.metatileItems.clear(); this->selection.metatileItems.clear();
this->selection.collisionItems.clear(); this->selection.collisionItems.clear();
this->selection.hasCollision = false; this->selection.hasCollision = false;
this->selection.dimensions = SelectablePixmapItem::getSelectionDimensions(); this->selection.dimensions = this->getSelectionDimensions();
QPoint origin = this->getSelectionStart(); QPoint origin = this->getSelectionStart();
for (int j = 0; j < this->selection.dimensions.y(); j++) { for (int j = 0; j < this->selection.dimensions.y(); j++) {
for (int i = 0; i < this->selection.dimensions.x(); i++) { for (int i = 0; i < this->selection.dimensions.x(); i++) {