atiran/sovereignx
3
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixed TOD & weather fadeout.

Browse source
This commit is contained in:
Ariel Antonitis 2021-03-17 01:52:07 -04:00
parent 806b4acda2
commit 68068981a4
2 changed files with 13 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/field_weather.c
View file

@ -779,7 +779,7 @@ void FadeScreen(u8 mode, s8 delay)
if (fadeOut) if (fadeOut)
{ {
if (useWeatherPal) if (TRUE || useWeatherPal) // TODO: Can copying Faded to Unfaded before fadeout cause problems ?
CpuFastCopy(gPlttBufferFaded, gPlttBufferUnfaded, 0x400); CpuFastCopy(gPlttBufferFaded, gPlttBufferUnfaded, 0x400);
BeginNormalPaletteFade(PALETTES_ALL, delay, 0, 16, fadeColor); BeginNormalPaletteFade(PALETTES_ALL, delay, 0, 16, fadeColor);

13
src/field_weather_effect.c
View file

@ -481,6 +481,7 @@ void Rain_InitVars(void)
gWeatherPtr->gammaTargetIndex = gTimeOfDay == TIME_OF_DAY_DAY ? 3 : 0; gWeatherPtr->gammaTargetIndex = gTimeOfDay == TIME_OF_DAY_DAY ? 3 : 0;
gWeatherPtr->gammaStepDelay = 20; gWeatherPtr->gammaStepDelay = 20;
SetRainStrengthFromSoundEffect(SE_RAIN); SetRainStrengthFromSoundEffect(SE_RAIN);
Weather_SetBlendCoeffs(8, 12); // preserve shadow darkness
} }
void Rain_InitAll(void) void Rain_InitAll(void)
@ -774,6 +775,7 @@ void Snow_InitVars(void)
gWeatherPtr->gammaStepDelay = 20; gWeatherPtr->gammaStepDelay = 20;
gWeatherPtr->targetSnowflakeSpriteCount = 16; gWeatherPtr->targetSnowflakeSpriteCount = 16;
gWeatherPtr->snowflakeVisibleCounter = 0; gWeatherPtr->snowflakeVisibleCounter = 0;
Weather_SetBlendCoeffs(8, 12); // preserve shadow darkness
} }
void Snow_InitAll(void) void Snow_InitAll(void)
@ -1049,6 +1051,7 @@ void Thunderstorm_InitVars(void)
gWeatherPtr->weatherGfxLoaded = FALSE; // duplicate assignment gWeatherPtr->weatherGfxLoaded = FALSE; // duplicate assignment
gWeatherPtr->thunderTriggered = FALSE; gWeatherPtr->thunderTriggered = FALSE;
SetRainStrengthFromSoundEffect(SE_THUNDERSTORM); SetRainStrengthFromSoundEffect(SE_THUNDERSTORM);
Weather_SetBlendCoeffs(8, 12); // preserve shadow darkness
} }
void Thunderstorm_InitAll(void) void Thunderstorm_InitAll(void)
@ -1077,6 +1080,7 @@ void Downpour_InitVars(void)
gWeatherPtr->gammaStepDelay = 20; gWeatherPtr->gammaStepDelay = 20;
gWeatherPtr->weatherGfxLoaded = FALSE; // duplicate assignment gWeatherPtr->weatherGfxLoaded = FALSE; // duplicate assignment
SetRainStrengthFromSoundEffect(SE_DOWNPOUR); SetRainStrengthFromSoundEffect(SE_DOWNPOUR);
Weather_SetBlendCoeffs(8, 12); // preserve shadow darkness
} }
void Downpour_InitAll(void) void Downpour_InitAll(void)
@ -1525,8 +1529,8 @@ void Ash_InitVars(void)
gWeatherPtr->ashUnused = 20; // Never read gWeatherPtr->ashUnused = 20; // Never read
if (!gWeatherPtr->ashSpritesCreated) if (!gWeatherPtr->ashSpritesCreated)
{ {
Weather_SetBlendCoeffs(0, 16); Weather_SetBlendCoeffs(0, 12);
SetGpuReg(REG_OFFSET_BLDALPHA, BLDALPHA_BLEND(64, 63)); // These aren't valid blend coefficients! // SetGpuReg(REG_OFFSET_BLDALPHA, BLDALPHA_BLEND(64, 63)); // These aren't valid blend coefficients!
} }
} }
@ -1553,7 +1557,7 @@ void Ash_Main(void)
if (!gWeatherPtr->ashSpritesCreated) if (!gWeatherPtr->ashSpritesCreated)
CreateAshSprites(); CreateAshSprites();
Weather_SetTargetBlendCoeffs(16, 0, 1); Weather_SetTargetBlendCoeffs(10, 12, 1);
gWeatherPtr->initStep++; gWeatherPtr->initStep++;
break; break;
case 2: case 2:
@ -1574,7 +1578,7 @@ bool8 Ash_Finish(void)
switch (gWeatherPtr->finishStep) switch (gWeatherPtr->finishStep)
{ {
case 0: case 0:
Weather_SetTargetBlendCoeffs(0, 16, 1); Weather_SetTargetBlendCoeffs(0, 12, 1);
gWeatherPtr->finishStep++; gWeatherPtr->finishStep++;
break; break;
case 1: case 1:
@ -2243,6 +2247,7 @@ void Shade_InitVars(void)
gWeatherPtr->initStep = 0; gWeatherPtr->initStep = 0;
gWeatherPtr->gammaTargetIndex = 3; gWeatherPtr->gammaTargetIndex = 3;
gWeatherPtr->gammaStepDelay = 20; gWeatherPtr->gammaStepDelay = 20;
Weather_SetBlendCoeffs(8, 12); // preserve shadow darkness
} }
void Shade_InitAll(void) void Shade_InitAll(void)