Review changes.

This commit is contained in:
Eduardo Quezada 2023-09-22 11:19:00 -03:00
parent af210da972
commit a56eb4f53f
3 changed files with 29 additions and 30 deletions

View file

@ -4734,7 +4734,7 @@ static void AnimFalseSwipeSlice(struct Sprite *sprite)
static void AnimFalseSwipePositionedSlice(struct Sprite *sprite)
{
sprite->x = GetBattlerSpriteCoord(gBattleAnimTarget, BATTLER_COORD_X_2) + 0xFFD0 + gBattleAnimArgs[0];
sprite->x = GetBattlerSpriteCoord(gBattleAnimTarget, BATTLER_COORD_X_2) - 48 + gBattleAnimArgs[0];
sprite->y = GetBattlerSpriteCoord(gBattleAnimTarget, BATTLER_COORD_Y_PIC_OFFSET);
StartSpriteAnim(sprite, 1);
sprite->data[0] = 0;

View file

@ -48,7 +48,6 @@ static const struct MapConnection *GetIncomingConnection(u8 direction, int x, in
static bool8 IsPosInIncomingConnectingMap(u8 direction, int x, int y, const struct MapConnection *connection);
static bool8 IsCoordInIncomingConnectingMap(int coord, int srcMax, int destMax, int offset);
#define GetBorderBlockAt(x, y)({ \
u16 block; \
int i; \

View file

@ -257,34 +257,34 @@ const u8 gClockTable[] =
const struct PokemonCrySong gPokemonCrySongTemplate =
{
1, // track count
0, // block count
255, // priority
0, // reverb
(struct ToneData *)&voicegroup000, // tone
{NULL, NULL}, // part
0, // gap
TUNE, // part 0
C_V, // TUNE value
GOTO,
0, // GOTO target address
TUNE, // part 1
C_V + 16, // TUNE value
{VOICE, 0}, // part 0 jumps here with GOTO
VOL,
127, // volume
{XCMD, 0x0D},
0, // unk value
{XCMD, xRELE},
0, // release
PAN,
C_V, // PAN value
TIE,
60, // TIE key (default is Cn3)
127, // TIE velocity
{XCMD, 0x0C},
60, // unk value
{EOT, FINE} // end
.trackCount = 1,
.blockCount = 0,
.priority = 255,
.reverb = 0,
.tone = (struct ToneData *)&voicegroup000,
.part = {NULL, NULL},
.gap = 0,
.part0 = TUNE,
.tuneValue = C_V,
.gotoCmd = GOTO,
.gotoTarget = 0,
.part1 = TUNE,
.tuneValue2 = C_V + 16,
.cont = {VOICE, 0}, // part0 jumps here with gotoCmd
.volCmd = VOL,
.volumeValue = 127,
.unkCmd0D = {XCMD, 0x0D},
.unkCmd0DParam = 0,
.xreleCmd = {XCMD, xRELE},
.releaseValue = 0,
.panCmd = PAN,
.panValue = C_V,
.tieCmd = TIE,
.tieKeyValue = 60, // default is Cn3
.tieVelocityValue = 127,
.unkCmd0C = {XCMD, 0x0C},
.unkCmd0CParam = 60,
.end = {EOT, FINE}
};
const XcmdFunc gXcmdTable[] =