From a6847ca1d938f6f4f317d88b0f656682a974c6d9 Mon Sep 17 00:00:00 2001
From: GriffinR <griffin.richards@comcast.net>
Date: Fri, 4 Oct 2019 00:58:47 -0400
Subject: [PATCH] Note overflow in ModifyStatByNature

---
 src/pokemon.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/pokemon.c b/src/pokemon.c
index da659b10d3..55f9a93f3f 100644
--- a/src/pokemon.c
+++ b/src/pokemon.c
@@ -5724,9 +5724,9 @@ u16 ModifyStatByNature(u8 nature, u16 n, u8 statIndex)
     switch (gNatureStatTable[nature][statIndex - 1])
     {
     case 1:
-        return (u16)(n * 110) / 100;
+        return (u16)(n * 110) / 100; // NOTE: will overflow for n > 595 because the intermediate value is cast to u16 before the division. Fix by removing (u16) cast
     case -1:
-        return (u16)(n * 90) / 100;
+        return (u16)(n * 90) / 100;  // NOTE: will overflow for n > 728, see above
     }
 
     return n;