atiran/sovereignx
3
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

added missing minior description + test for missing descriptions (#4858)

Browse source
This commit is contained in:
cawtds 2024-06-24 12:19:12 +02:00 committed by GitHub
parent ec75a75498
commit a8ae1a0342
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 25 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/data/pokemon/species_info.h
View file

@ -31,11 +31,7 @@ const struct SpeciesInfo gSpeciesInfo[] =
.categoryName = _("Unknown"),
.height = 0,
.weight = 0,
.description = COMPOUND_STRING(
"This is a newly discovered Pokémon.\n"
"It is currently under investigation.\n"
"No detailed information is available\n"
"at this time."),
.description = gFallbackPokedexText,
.pokemonScale = 256,
.pokemonOffset = 0,
.trainerScale = 256,

1
src/data/pokemon/species_info/gen_7_families.h
View file

@ -3617,6 +3617,7 @@ const struct SpeciesInfo gSpeciesInfoGen7[] =
.baseSpAttack = 60, \
.baseSpDefense = 100, \
.weight = 400, \
.description = gMiniorMeteorPokedexText, \
.frontPic = gMonFrontPic_MiniorMeteor, \
.frontPicSize = MON_COORDS_SIZE(48, 40), \
.frontPicYOffset = 14, \

7
src/data/pokemon/species_info/shared_dex_text.h
View file

@ -1,3 +1,10 @@
// fallback
const u8 gFallbackPokedexText[] = _(
"This is a newly discovered Pokémon.\n"
"It is currently under investigation.\n"
"No detailed information is available\n"
"at this time.");
// Gen 1 families
const u8 gRaticateAlolanPokedexText[] = _(
"It forms a group of Rattata, which it \n"

16
test/species.c
View file

@ -1,4 +1,5 @@
#include "global.h"
#include "string_util.h"
#include "test/test.h"
#include "constants/form_change_types.h"
@ -129,3 +130,18 @@ TEST("No species has two evolutions that use the evolution tracker")
EXPECT(evolutionTrackerEvolutions < 2);
}
extern const u8 gFallbackPokedexText[];
TEST("Every species has a description")
{
u32 i;
u32 species = SPECIES_NONE;
for (i = 1; i < NUM_SPECIES; i++)
{
if (IsSpeciesEnabled(i))
PARAMETRIZE { species = i; }
}
EXPECT_NE(StringCompare(GetSpeciesPokedexDescription(species), gFallbackPokedexText), 0);
}