atiran/sovereignx
3
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Updated README & Improved efficiency of tracking palette unloads.

Browse source
This commit is contained in:
Ariel Antonitis 2021-06-15 18:54:36 -04:00
parent 9a6f6212b2
commit dda599e929
2 changed files with 23 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
README.md
View file

@ -1,14 +1,26 @@
# Pokémon Emerald
This is a decompilation of Pokémon Emerald.
This is a fork of the [matching decompilation](https://github.com/pret/pokeemerald) at [PRET](https://github.com/pret).
It builds the following ROM:
The general philosophy of this fork is to maintain vanilla behavior & compatibility where possible, especially in terms of data structures. For that reason, this fork does not increase the size of the save data structure or the object event structure, nor does it add a `nature` field to the Pokémon structure.
* [**pokeemerald.gba**](https://datomatic.no-intro.org/index.php?page=show_record&s=23&n=1961) `sha1: f3ae088181bf583e55daf962a92bb46f4f1d07b7`
There are several branches, each with additional features compared to vanilla:
**romhack** branch:
* [HGSS-style pokémon followers](https://bulbapedia.bulbagarden.net/wiki/Walking_Pok%C3%A9mon#Pok.C3.A9mon_HeartGold_and_SoulSilver) for all 386 pokémon, including emotes, the 28 Unown forms and a majority of follower messages.
* Dynamic overworld palettes & reflections compatible with vanilla berry trees.
* HGSS-style alpha-blended shadows for object events.
* A way to change a pokemon's nature while mangling its PID as little as possible.
* Function to detect newer emulators/new GBA hardware.
**lighting** branch:
* Everything from the **romhack** branch.
* Day/night shading compatible with weather.
* GSC-style window lights.
* WIP interframe-blended lamp lights at night, i.e in Rustboro.
To set up the repository, see [INSTALL.md](INSTALL.md).
## See also
Other disassembly and/or decompilation projects:
@ -28,4 +40,4 @@ Other disassembly and/or decompilation projects:
## Contacts
You can find us on [Discord](https://discord.gg/d5dubZ3) and [IRC](https://kiwiirc.com/client/irc.freenode.net/?#pret).
You can find PRET on [Discord](https://discord.gg/d5dubZ3) and [IRC](https://kiwiirc.com/client/irc.freenode.net/?#pret).

16
gflib/sprite.c
View file

@ -1673,16 +1673,12 @@ u16 GetSpritePaletteTagByPaletteNum(u8 paletteNum)
void FreeSpritePaletteByTag(u16 tag)
{
u8 index = IndexOfSpritePaletteTag(tag);
#if DEBUG
u16 emptyPalette[16] = {0};
if (index != 0xFF) {
sSpritePaletteTags[index] = 0xFFFF;
LoadPalette(emptyPalette, index * 16 + 0x100, 32);
}
#else
if (index != 0xFF)
sSpritePaletteTags[index] = 0xFFFF;
#endif
if (index != 0xFF) {
sSpritePaletteTags[index] = 0xFFFF;
#if DEBUG
FillPalette(0, index * 16 + 0x100, 32);
#endif
}
}
void SetSubspriteTables(struct Sprite *sprite, const struct SubspriteTable *subspriteTables)