atiran/sovereignx
3
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

pokeblock review changes

Browse source
This commit is contained in:
DizzyEggg 2017-12-20 17:20:41 +01:00
parent b615af4184
commit df479661ff
3 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/pokeblock.c
View file

@ -800,7 +800,7 @@ static void sub_8136344(void)
u8 i; u8 i;
for (i = 0; for (i = 0;
i < sSavedPokeblockData.lastItemPos - 4 && sSavedPokeblockData.lastItemPage + sPokeblockMenu->maxShowed != sPokeblockMenu->itemsNo; (i < sSavedPokeblockData.lastItemPos - 4) && (sSavedPokeblockData.lastItemPage + sPokeblockMenu->maxShowed != sPokeblockMenu->itemsNo);
sSavedPokeblockData.lastItemPos--, sSavedPokeblockData.lastItemPage++, i++); sSavedPokeblockData.lastItemPos--, sSavedPokeblockData.lastItemPage++, i++);
} }
} }

10
src/pokeblock_feed.c
View file

@ -802,7 +802,7 @@ static void Task_ReturnAfterPaletteFade(u8 taskId)
{ {
ResetSpriteData(); ResetSpriteData();
FreeAllSpritePalettes(); FreeAllSpritePalettes();
m4aMPlayVolumeControl(&gMPlay_BGM, -1, 256); m4aMPlayVolumeControl(&gMPlay_BGM, -1, 0x100);
SetMainCallback2(gMain.savedCallback); SetMainCallback2(gMain.savedCallback);
DestroyTask(taskId); DestroyTask(taskId);
FreeAllWindowBuffers(); FreeAllWindowBuffers();
@ -1092,13 +1092,13 @@ static void sub_817AB68(void)
if (!var_24) if (!var_24)
{ {
pokeblockFeed->field_850[r4] = Sin(pokeblockFeed->field_1060[0], pokeblockFeed->field_1060[2] + r5 / 256) + r8; pokeblockFeed->field_850[r4] = Sin(pokeblockFeed->field_1060[0], pokeblockFeed->field_1060[2] + r5 / 0x100) + r8;
pokeblockFeed->field_C50[r4] = Cos(pokeblockFeed->field_1060[0], pokeblockFeed->field_1060[3] + r5 / 256) + r7; pokeblockFeed->field_C50[r4] = Cos(pokeblockFeed->field_1060[0], pokeblockFeed->field_1060[3] + r5 / 0x100) + r7;
} }
else else
{ {
pokeblockFeed->field_850[r4] = Sin(pokeblockFeed->field_1060[0], pokeblockFeed->field_1060[2] - r5 / 256) + r8; pokeblockFeed->field_850[r4] = Sin(pokeblockFeed->field_1060[0], pokeblockFeed->field_1060[2] - r5 / 0x100) + r8;
pokeblockFeed->field_C50[r4] = Cos(pokeblockFeed->field_1060[0], pokeblockFeed->field_1060[3] - r5 / 256) + r7; pokeblockFeed->field_C50[r4] = Cos(pokeblockFeed->field_1060[0], pokeblockFeed->field_1060[3] - r5 / 0x100) + r7;
} }
pokeblockFeed->field_1060[0] += pokeblockFeed->field_1060[1]; pokeblockFeed->field_1060[0] += pokeblockFeed->field_1060[1];

8
src/pokemon_3.c
View file

@ -1298,16 +1298,16 @@ bool8 IsPokeSpriteNotFlipped(u16 species)
return gBaseStats[species].noFlip; return gBaseStats[species].noFlip;
} }
s8 GetMonFlavorRelation(struct Pokemon *mon, u8 flavour) s8 GetMonFlavorRelation(struct Pokemon *mon, u8 flavor)
{ {
u8 nature = GetNature(mon); u8 nature = GetNature(mon);
return gPokeblockFlavorCompatibilityTable[nature * 5 + flavour]; return gPokeblockFlavorCompatibilityTable[nature * 5 + flavor];
} }
s8 GetFlavorRelationByPersonality(u32 personality, u8 flavour) s8 GetFlavorRelationByPersonality(u32 personality, u8 flavor)
{ {
u8 nature = GetNatureFromPersonality(personality); u8 nature = GetNatureFromPersonality(personality);
return gPokeblockFlavorCompatibilityTable[nature * 5 + flavour]; return gPokeblockFlavorCompatibilityTable[nature * 5 + flavor];
} }
bool8 IsTradedMon(struct Pokemon *mon) bool8 IsTradedMon(struct Pokemon *mon)