atiran/sovereignx
3
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Juan text buffer overflow note

Browse source
This commit is contained in:
Tustin2121 2019-08-17 10:32:37 -04:00
parent 4663564e02
commit ea724278b7
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
data/maps/SootopolisCity_Gym_1F/scripts.inc
View file

@ -222,6 +222,10 @@ SootopolisCity_Gym_1F_Text_225268: @ 8225268
.string "A grand illusion of water sculpted\n" .string "A grand illusion of water sculpted\n"
.string "by POKéMON and myself!$" .string "by POKéMON and myself!$"
@ NOTE: This defeat text actually causes a buffer overflow. It's about 50 bytes too long for
@ the gDisplayedStringBattle buffer that it's put into, and it stomps all over the gBattleTextBuffs
@ after, as well as the otherwise unused array after that. One wonders if that's the reason for
@ the existence of that unused array of ints.
SootopolisCity_Gym_1F_Text_225432: @ 8225432 SootopolisCity_Gym_1F_Text_225432: @ 8225432
.string "Ahahaha, excellent!\n" .string "Ahahaha, excellent!\n"
.string "Very well, you are the winner.\p" .string "Very well, you are the winner.\p"