Phlosioneer
93e9b9fe5d
Fix some names
2019-02-18 01:33:41 -05:00
Phlosioneer
40d4f7f8db
Minor fixes
2019-02-18 01:10:59 -05:00
Phlosioneer
7ad225a72f
Address formatting issues and use constants
2019-02-18 00:16:27 -05:00
Phlosioneer
f528552583
Rename pokenav file
2019-02-17 23:14:14 -05:00
Phlosioneer
762640664f
Fix formatting
2019-02-17 23:14:14 -05:00
Phlosioneer
bfeb7fb32a
Tabs converted to spaces.
...
Oops.
2019-02-17 23:14:14 -05:00
Phlosioneer
fbcfb69fe6
Remove guess code, fix pointer formatting
2019-02-17 23:14:14 -05:00
Phlosioneer
197ad274b4
Reformat braces
2019-02-17 23:14:14 -05:00
Phlosioneer
be08a662a8
More data moved into C code
2019-02-17 23:14:14 -05:00
Phlosioneer
a4aaf279ac
Move more data into pokenav, name some strings
2019-02-17 23:14:14 -05:00
Phlosioneer
bf4c1a73c0
Start moving pokenav data into C files
...
The types and usage of many of the globals are now known.
2019-02-17 23:14:14 -05:00
Phlosioneer
758b8c7f0e
Decompiled three more functions.
2019-02-17 23:14:14 -05:00
Phlosioneer
6d929c61c5
Decompiled 4 more functions
2019-02-17 23:14:14 -05:00
Phlosioneer
cb800e4708
Decompiled 5 functions
...
Was unable to decompile sub_81C79BC.
2019-02-17 23:14:14 -05:00
Phlosioneer
d41c597f90
Decompiled sub_81C7990
2019-02-17 23:14:14 -05:00
Phlosioneer
f95eebf47a
With help, sub_81C795C has been tamed.
...
Thanks to Garak on the discord server.
2019-02-17 23:14:14 -05:00
Phlosioneer
a8d920cc45
Decompiled 2 functions, unable to decompile 1.
...
sub_81C795C could not be decompiled due to register naming issues.
However, its structure was correctly matched, so I have left the C
code and a comment explaining the issue.
2019-02-17 23:14:14 -05:00
Phlosioneer
34b16e9e78
Decompiled 5 functions for unknown structs
2019-02-17 23:14:14 -05:00
Phlosioneer
3bb4057bad
Decompiled sub_81C7764
2019-02-17 23:14:14 -05:00
Phlosioneer
7c405e08d0
Decompiled three more small functions
2019-02-17 23:14:14 -05:00
Phlosioneer
5beb2baa97
Decompiled sub_81C76C4
2019-02-17 23:14:14 -05:00
Phlosioneer
b038556851
Decompiled several setters and getters
2019-02-17 23:14:14 -05:00
Phlosioneer
13a6765c88
Decompiled several trivial functions
2019-02-17 23:14:14 -05:00
Phlosioneer
112fc47017
Decompiled sub_81C756C
...
Also discovered a constant that may be useful for future decompiling.
Comments were added in the asm that references the constant.
2019-02-17 23:14:14 -05:00
Phlosioneer
3d73f7c48c
Decompiled sub_81C742C
2019-02-17 23:14:14 -05:00
Phlosioneer
cf721879dd
Decompiled sub_81C7418
2019-02-17 23:14:14 -05:00
Phlosioneer
323df8ed40
Decompiled sub_81C7400
2019-02-17 23:14:14 -05:00
Phlosioneer
729e7116f2
Decompiled AnyMonHasRibbon
2019-02-17 23:14:14 -05:00
Phlosioneer
5441d80ebc
Decompiled sub_81C7360
2019-02-17 23:14:14 -05:00
Phlosioneer
aa61e105e0
Decompiled sub_81C7334
2019-02-17 23:14:14 -05:00
Phlosioneer
d52cbe6bcb
Decompiled sub_81C72BC
2019-02-17 23:14:14 -05:00
Phlosioneer
9bda2297e3
Decompiled sub_81C72A4
2019-02-17 23:14:14 -05:00
Phlosioneer
cd84c92cfa
Decompiled CB2_PokeNav
2019-02-17 23:14:14 -05:00
Phlosioneer
69b014f7aa
Decompiled sub_81C71E4
2019-02-17 23:14:14 -05:00
Phlosioneer
fb705e6047
Decompiled sub_81C7170.
2019-02-17 23:14:14 -05:00
Phlosioneer
6466d0bea8
Decompiled sub_81C7124
2019-02-17 23:14:14 -05:00
Phlosioneer
052cd4da10
Decompiled sub_81C70D8
2019-02-17 23:14:14 -05:00
Phlosioneer
698c2879e4
Decompiled sub_81C7078
2019-02-17 23:14:14 -05:00
Diegoisawesome
367c7b5f89
Merge pull request #558 from Phlosioneer/check-pokedex-asm
...
Add comments explaining the remaining asm in pokedex.c
2019-02-17 12:59:52 -06:00
garak
22657c7087
use BG_SCREEN_ADDR macro for tilemap addresses
2019-02-17 00:35:26 -05:00
garak
35575b57a0
use BG_CHAR_ADDR define
2019-02-16 23:51:06 -05:00
Phlosioneer
e90e3458cb
Document the regi* code more
...
Fixed some confusing naming, named some unknown symbols, and fixed the
names of some flags.
2019-02-15 18:24:55 -05:00
Phlosioneer
986d3d8b2f
Finish and polish new_game.c
...
Only one function is left undocumented. I tried to go into the assembly
to at least name it, but it clears fields in the save block that aren't
even documented yet.
2019-02-15 03:40:57 -05:00
Phlosioneer
0a3912c95d
Add comments explaining asm in pokedex.c
...
I added comments to each of the asm functions explaining why they won't
match with the C.
I also got one of the functions much closer to matching.
2019-02-15 01:28:28 -05:00
Diegoisawesome
047c282763
Merge pull request #548 from Phlosioneer/intro-movie-state-machine
...
Document the intro movie state machine
2019-02-13 21:24:20 -06:00
Phlosioneer
e7d0268143
Fix spelling of Rayquaza
2019-02-13 21:41:28 -05:00
Diegoisawesome
aa5d5fa34a
Merge pull request #550 from Phlosioneer/name-palette-return-values
...
Name the possible return values of palette fading functions
2019-02-13 20:15:47 -06:00
Diegoisawesome
dfb896356c
Merge branch 'master' of github.com:pret/pokeemerald
2019-02-12 00:40:42 -06:00
Diegoisawesome
449fb25f23
Clear up misnamed time-based flags and functions
2019-02-12 00:40:34 -06:00
Phlosioneer
37bea25b01
Name the possible return values of palette fading functions
...
Also replace implicit conversion from gPalette.active into a status with
if statements, to make the return value clear.
I've also added comments when the check is redundant.
2019-02-09 21:50:12 -05:00
Phlosioneer
45297797e6
Document the intro movie state machine
...
Need to study the water droplet animation more closely before they can
be renamed; otherwise, this names every major symbol in this file.
2019-02-09 21:07:07 -05:00
Marcus Huderle
6f1d2b870c
Give proper names to dynamic map layouts
2019-02-09 09:57:30 -06:00
Marcus Huderle
40dc6833c5
Fully document tileset animations
2019-02-08 15:07:42 -06:00
Marcus Huderle
abebd2b864
Cleanup externs in overworld.c
2019-02-08 11:48:51 -06:00
Marcus Huderle
6add3e1794
Document some battle dome stuff
2019-02-08 11:08:25 -06:00
Marcus Huderle
4570e3b6a5
Document battle arena
2019-02-08 09:41:36 -06:00
Marcus Huderle
3a40f5203b
Remove old rom_818CFC8.h header
2019-02-07 17:41:44 -06:00
Marcus Huderle
85040e26fd
Document battle pike
2019-02-07 17:37:41 -06:00
Marcus Huderle
4785a07acd
Document battle factory functions
2019-02-07 12:58:09 -06:00
Marcus Huderle
b52871433a
Fix typo
2019-02-07 11:54:51 -06:00
Marcus Huderle
3a88ab831d
Document more battle pyramid
2019-02-07 11:51:03 -06:00
Marcus Huderle
a1ad1bad3a
Document a bunch of battle pyramid
2019-02-06 21:14:28 -06:00
Marcus Huderle
1253cbf5f6
Document some battle anim things
2019-02-06 21:14:28 -06:00
huderlem
b0ee100975
Merge pull request #543 from pret/mapdata
...
Convert map data to JSON
2019-02-04 21:36:18 -06:00
Diegoisawesome
646533cfa3
Merge pull request #542 from Slawter666/pss
...
Label some summary screen functions
2019-02-04 09:46:39 -06:00
Slawter666
fa352cfda3
Some more labelling
2019-02-04 14:35:49 +00:00
Slawter666
3d79aeb9da
More documentation
2019-02-04 12:44:09 +00:00
Slawter666
804e955c8d
Label some more functions
2019-02-04 11:38:44 +00:00
Slawter666
031fd66393
Label some summary screen functions
2019-02-02 22:14:04 +00:00
Diegoisawesome
ff48e5ada0
Merge pull request #541 from Diegoisawesome/master
...
Misc documentation
2019-02-02 16:00:56 -06:00
Diegoisawesome
d64a905d65
Document trainer backsprites
2019-02-02 15:56:22 -06:00
Diegoisawesome
59807c0f2c
Merge pull request #536 from DizzyEggg/menu
...
Use Menu and List Menu input defines
2019-02-02 12:45:35 -06:00
DizzyEggg
ea79f1c8f6
tabs
2019-02-02 19:41:34 +01:00
Diegoisawesome
e8952c2374
Merge pull request #539 from DizzyEggg/ram_vars
...
Move ram vars in sym files to C
2019-02-02 11:17:50 -06:00
Diegoisawesome
47c105bef6
Merge pull request #538 from DizzyEggg/data
...
Dump last battle anim file
2019-02-02 11:12:29 -06:00
DizzyEggg
363fa9bed2
Clean up ram vars
2019-02-02 12:44:00 +01:00
DizzyEggg
a7f94bbeea
Dump last battle anim file
2019-02-02 11:55:11 +01:00
DizzyEggg
a740bc7190
Name action 11
2019-02-02 11:32:00 +01:00
DizzyEggg
23b240ab65
Fix Menu and List Menu input defines
2019-02-02 11:04:38 +01:00
Diegoisawesome
46a3969f69
Add constants for flags and vars
2019-02-02 00:25:43 -06:00
Diegoisawesome
9d8a43a1fb
Merge pull request #534 from DizzyEggg/patch-1
...
Get rid of an unnecessary extern
2019-02-01 14:51:04 -06:00
DizzyEggg
b3d48c0ed6
Get rid of an unnecessary extern
2019-02-01 19:45:06 +01:00
DizzyEggg
d02a788d2e
Match GetItemEffectType
2019-02-01 19:25:10 +01:00
Diegoisawesome
b26c24ffee
Merge pull request #532 from DizzyEggg/bored
...
Fix some fakematches
2019-02-01 10:04:42 -06:00
DizzyEggg
c0db311637
some more fakematch fix
2019-02-01 12:26:40 +01:00
DizzyEggg
e3bec4b480
fix nonmatch in mauville old man
2019-02-01 11:56:02 +01:00
DizzyEggg
7c8fb66acf
Fix field player avatar fakmatch
2019-02-01 11:50:45 +01:00
DizzyEggg
5dfaf22fb3
Fix pokemon icon asm
2019-02-01 11:39:24 +01:00
DizzyEggg
b4055e4fc0
Merge m4a files into one, get rid of one asm
2019-02-01 10:37:13 +01:00
DizzyEggg
7750a8126d
CgbSound is decompiled.
2019-02-01 00:25:31 +01:00
Marcus Huderle
29d6221935
Convert map data to JSON
2019-01-31 15:51:20 -06:00
Diegoisawesome
3f1a7330dd
Document siirtc a bit more
2019-01-30 19:48:28 -06:00
DizzyEggg
d46e60765d
Rename a palace battle field
2019-01-29 22:22:02 +01:00
Marcus Huderle
8f832434e5
Change drought colors table files to .bin
2019-01-29 14:36:02 -06:00
Marcus Huderle
36a1825bbe
Document trainer approach funcs, and use movement type constants in scripts
2019-01-29 14:36:02 -06:00
Marcus Huderle
e81838dba3
Misc. documentation and move some data into .c files
2019-01-29 14:36:02 -06:00
DizzyEggg
73d919fa0f
Define double single left right qutoation marks char
2019-01-28 19:02:34 +01:00
DizzyEggg
922726ff3d
contest
2019-01-28 18:19:58 +01:00
DizzyEggg
ad59811154
Decompile whole contest
2019-01-28 18:13:07 +01:00
DizzyEggg
26a2a4f9e7
Match all of contest functions
2019-01-28 12:29:47 +01:00