a64e1c63c1
* Made gBattleMoves handle the InGame name and description of battle moves No more multiple arrays in separate, individual files. Note: -Keep an eye on Task_LearnedMove. * Reintroduced move names Misc: -Fixed Trick-or-Treat and Light of Ruin's expanded names. -Introduced a new field for Z-Move names, and a constant for their name length. -Added a few TODOs to GetBattleMoveName. -Updated GetMaxMoveName and GetZMoveName. There's no reason not to let GetBattleMoveName handle everything on its own. * Updated GetBattleMoveName to handle Z-Move Names Misc: -Removed pointless TODO about MOVE_NAME_LENGTH. -The compiler doesn't allow to have a move name with a value higher than MOVE_NAME_LENGTH, therefore it's pointless to worry about it. * Fixed a couple of expanded move names * Removed zMoveName variable of struct BattleMove and extended the name variable's size * Ditched no longer used MOVE_NAME_LENGTH constant * Corrected the names of the max moves I should have done this after updating the size of the name variable of the struct BattleMove, but I didn't think about it at all until Cancer Fairy indirectly gave me the idea. * Fixed U-turn's name * Brought back MOVE_NAME_LENGTH I think it doesn't make sense to have a Z_MOVE_NAME_LENGTH because the length in question is used for all battle moves, not just the Z-Moves. * Introduced a union for Move/Z-Move names in the struct BattleMove * Fixed the union for gBattleMoves move names Also updated GetBattleMoveName to properly handle Max Move names. Also also renamed the "zMoveName" variable to "bigMoveName" which better reflects its purpose. Z-Move names weren't the only thing it covered, since it also handles Max Move names. * Removed deprecated GetZMoveName and GetMaxMoveName * Reintroduced mention to gMoveNames in sGFRomHeader * Fixed move names and ported move descriptions * Fused the struct ContestMove into the struct BattleMove * Removed no longer used Z_MOVE_NAME_LENGTH constant * Renamed the struct BattleMove's bigMoveName variable and introduced macros to prettify move names * Reintroduced the contest parameters for Pokémon moves * Renamed gBattleMoves to gMovesInfo This is consistent with gSpeciesInfo, the array that contains most of the species data. * Renamed the BattleMove struct to MovesInfo This is consistent with the struct SpeciesInfo, which contains the variables used by the gSpeciesInfo array. * Removed empty lines separating battle params from contest params in gMovesInfo * Renamed MovesInfo to MoveInfo * Added Cancer Fairy's HANDLE_EXPANDED_MOVE_NAME macro Used to handle moves with expanded names in a more comfortable manner. Also fixed Trick-or-Treat's expanded name. * Renamed GetBattleMoveName to GetMoveName * Added a comment pointing out that the shared move descriptions are shared move descriptions * Re-aligned one of the escape characters of CHECK_MOVE_FLAG * Renamed the battle_moves.h file to moves_info.h instead for consistency's sake * Applied Eduardo's adjustments * Using compound string for regular move names as well, saving 1180 bytes and making their use consistent * Move description formatting * Updated Pursuit test after merge * Renamed the BATTLE_CATEGORY constants to DAMAGE_CATEGORY --------- Co-authored-by: Nephrite <thechurchofcage@gmail.com> Co-authored-by: Bassoonian <iasperbassoonian@gmail.com> Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
155 lines
6.3 KiB
C
155 lines
6.3 KiB
C
#include "global.h"
|
|
#include "test/battle.h"
|
|
|
|
SINGLE_BATTLE_TEST("Venusaur can Mega Evolve holding Venusaurite")
|
|
{
|
|
GIVEN {
|
|
PLAYER(SPECIES_VENUSAUR) { Item(ITEM_VENUSAURITE); }
|
|
OPPONENT(SPECIES_WOBBUFFET);
|
|
} WHEN {
|
|
TURN { MOVE(player, MOVE_CELEBRATE, megaEvolve: TRUE); }
|
|
} SCENE {
|
|
MESSAGE("Venusaur's Venusaurite is reacting to 1's Mega Ring!");
|
|
ANIMATION(ANIM_TYPE_GENERAL, B_ANIM_MEGA_EVOLUTION, player);
|
|
MESSAGE("Venusaur has Mega Evolved into Mega Venusaur!");
|
|
} THEN {
|
|
EXPECT_EQ(player->species, SPECIES_VENUSAUR_MEGA);
|
|
}
|
|
}
|
|
|
|
DOUBLE_BATTLE_TEST("Mega Evolution's order is determined by Speed - opponent faster")
|
|
{
|
|
GIVEN {
|
|
PLAYER(SPECIES_VENUSAUR) { Item(ITEM_VENUSAURITE); Speed(1); }
|
|
PLAYER(SPECIES_WOBBUFFET) { Speed(3); }
|
|
OPPONENT(SPECIES_GARDEVOIR) { Item(ITEM_GARDEVOIRITE); Speed(3); }
|
|
OPPONENT(SPECIES_WOBBUFFET) { Speed(4); }
|
|
} WHEN {
|
|
TURN { MOVE(opponentLeft, MOVE_CELEBRATE, megaEvolve: TRUE); MOVE(playerLeft, MOVE_CELEBRATE, megaEvolve: TRUE); }
|
|
} SCENE {
|
|
MESSAGE("Foe Gardevoir's Gardevoirite is reacting to 2's Mega Ring!");
|
|
ANIMATION(ANIM_TYPE_GENERAL, B_ANIM_MEGA_EVOLUTION, opponentLeft);
|
|
MESSAGE("Foe Gardevoir has Mega Evolved into Mega Gardevoir!");
|
|
MESSAGE("Venusaur's Venusaurite is reacting to 1's Mega Ring!");
|
|
ANIMATION(ANIM_TYPE_GENERAL, B_ANIM_MEGA_EVOLUTION, playerLeft);
|
|
MESSAGE("Venusaur has Mega Evolved into Mega Venusaur!");
|
|
}
|
|
}
|
|
|
|
DOUBLE_BATTLE_TEST("Mega Evolution's order is determined by Speed - player faster")
|
|
{
|
|
GIVEN {
|
|
PLAYER(SPECIES_VENUSAUR) { Item(ITEM_VENUSAURITE); Speed(5); }
|
|
PLAYER(SPECIES_WOBBUFFET) { Speed(3); }
|
|
OPPONENT(SPECIES_GARDEVOIR) { Item(ITEM_GARDEVOIRITE); Speed(2); }
|
|
OPPONENT(SPECIES_WOBBUFFET) { Speed(4); }
|
|
} WHEN {
|
|
TURN { MOVE(opponentLeft, MOVE_CELEBRATE, megaEvolve: TRUE); MOVE(playerLeft, MOVE_CELEBRATE, megaEvolve: TRUE); }
|
|
} SCENE {
|
|
MESSAGE("Venusaur's Venusaurite is reacting to 1's Mega Ring!");
|
|
ANIMATION(ANIM_TYPE_GENERAL, B_ANIM_MEGA_EVOLUTION, playerLeft);
|
|
MESSAGE("Venusaur has Mega Evolved into Mega Venusaur!");
|
|
MESSAGE("Foe Gardevoir's Gardevoirite is reacting to 2's Mega Ring!");
|
|
ANIMATION(ANIM_TYPE_GENERAL, B_ANIM_MEGA_EVOLUTION, opponentLeft);
|
|
MESSAGE("Foe Gardevoir has Mega Evolved into Mega Gardevoir!");
|
|
}
|
|
}
|
|
|
|
SINGLE_BATTLE_TEST("Rayquaza can Mega Evolve knowing Dragon Ascent")
|
|
{
|
|
GIVEN {
|
|
PLAYER(SPECIES_RAYQUAZA) { Moves(MOVE_DRAGON_ASCENT, MOVE_CELEBRATE); }
|
|
OPPONENT(SPECIES_WOBBUFFET);
|
|
} WHEN {
|
|
TURN { MOVE(player, MOVE_CELEBRATE, megaEvolve: TRUE); }
|
|
} SCENE {
|
|
MESSAGE("1's fervent wish has reached Rayquaza!");
|
|
ANIMATION(ANIM_TYPE_GENERAL, B_ANIM_MEGA_EVOLUTION, player);
|
|
MESSAGE("Rayquaza has Mega Evolved into Mega Rayquaza!");
|
|
} THEN {
|
|
EXPECT_EQ(player->species, SPECIES_RAYQUAZA_MEGA);
|
|
}
|
|
}
|
|
|
|
SINGLE_BATTLE_TEST("Mega Evolution affects turn order")
|
|
{
|
|
GIVEN {
|
|
ASSUME(B_MEGA_EVO_TURN_ORDER >= GEN_7);
|
|
PLAYER(SPECIES_GARDEVOIR) { Item(ITEM_GARDEVOIRITE); Speed(105); }
|
|
OPPONENT(SPECIES_WOBBUFFET) { Speed(106); }
|
|
} WHEN {
|
|
TURN { MOVE(player, MOVE_CELEBRATE, megaEvolve: TRUE); }
|
|
} SCENE {
|
|
MESSAGE("Gardevoir used Celebrate!");
|
|
MESSAGE("Foe Wobbuffet used Celebrate!");
|
|
} THEN {
|
|
ASSUME(player->speed == 205);
|
|
}
|
|
}
|
|
|
|
SINGLE_BATTLE_TEST("Abilities replaced by Mega Evolution do not affect turn order")
|
|
{
|
|
GIVEN {
|
|
ASSUME(B_MEGA_EVO_TURN_ORDER >= GEN_7);
|
|
ASSUME(gSpeciesInfo[SPECIES_SABLEYE_MEGA].abilities[0] != ABILITY_STALL
|
|
&& gSpeciesInfo[SPECIES_SABLEYE_MEGA].abilities[1] != ABILITY_STALL);
|
|
PLAYER(SPECIES_SABLEYE) { Item(ITEM_SABLENITE); Ability(ABILITY_STALL); Speed(105); }
|
|
OPPONENT(SPECIES_WOBBUFFET) { Speed(44); }
|
|
} WHEN {
|
|
TURN { MOVE(player, MOVE_CELEBRATE, megaEvolve: TRUE); }
|
|
} SCENE {
|
|
MESSAGE("Sableye used Celebrate!");
|
|
MESSAGE("Foe Wobbuffet used Celebrate!");
|
|
} THEN {
|
|
ASSUME(player->speed == 45);
|
|
}
|
|
}
|
|
|
|
DOUBLE_BATTLE_TEST("Mega Evolution happens after switching, but before Focus Punch-like Moves")
|
|
{
|
|
GIVEN {
|
|
ASSUME(gMovesInfo[MOVE_FOCUS_PUNCH].effect == EFFECT_FOCUS_PUNCH);
|
|
PLAYER(SPECIES_WOBBUFFET);
|
|
PLAYER(SPECIES_VENUSAUR) { Item(ITEM_VENUSAURITE); }
|
|
OPPONENT(SPECIES_WYNAUT);
|
|
OPPONENT(SPECIES_WOBBUFFET);
|
|
OPPONENT(SPECIES_WOBBUFFET);
|
|
} WHEN {
|
|
TURN { SWITCH(opponentRight, 2); MOVE(playerRight, MOVE_FOCUS_PUNCH, megaEvolve: TRUE, target: opponentLeft); MOVE(playerLeft, MOVE_FOCUS_PUNCH, target: opponentLeft); }
|
|
TURN {}
|
|
} SCENE {
|
|
MESSAGE("2 withdrew Wobbuffet!");
|
|
MESSAGE("2 sent out Wobbuffet!");
|
|
|
|
MESSAGE("Venusaur's Venusaurite is reacting to 1's Mega Ring!");
|
|
ANIMATION(ANIM_TYPE_GENERAL, B_ANIM_MEGA_EVOLUTION, playerRight);
|
|
MESSAGE("Venusaur has Mega Evolved into Mega Venusaur!");
|
|
|
|
ANIMATION(ANIM_TYPE_GENERAL, B_ANIM_FOCUS_PUNCH_SETUP, playerRight);
|
|
MESSAGE("Venusaur is tightening its focus!");
|
|
|
|
ANIMATION(ANIM_TYPE_GENERAL, B_ANIM_FOCUS_PUNCH_SETUP, playerLeft);
|
|
MESSAGE("Wobbuffet is tightening its focus!");
|
|
}
|
|
}
|
|
|
|
SINGLE_BATTLE_TEST("Regular Mega Evolution and Fervent Wish Mega Evolution can happen on the same turn")
|
|
{
|
|
GIVEN {
|
|
PLAYER(SPECIES_RAYQUAZA) { Moves(MOVE_DRAGON_ASCENT, MOVE_CELEBRATE); Speed(3); }
|
|
OPPONENT(SPECIES_GARDEVOIR) { Item(ITEM_GARDEVOIRITE); Speed(2); }
|
|
} WHEN {
|
|
TURN { MOVE(player, MOVE_CELEBRATE, megaEvolve: TRUE); MOVE(opponent, MOVE_CELEBRATE, megaEvolve: TRUE); }
|
|
} SCENE {
|
|
MESSAGE("1's fervent wish has reached Rayquaza!");
|
|
ANIMATION(ANIM_TYPE_GENERAL, B_ANIM_MEGA_EVOLUTION, player);
|
|
MESSAGE("Rayquaza has Mega Evolved into Mega Rayquaza!");
|
|
|
|
MESSAGE("Foe Gardevoir's Gardevoirite is reacting to 2's Mega Ring!");
|
|
ANIMATION(ANIM_TYPE_GENERAL, B_ANIM_MEGA_EVOLUTION, opponent);
|
|
MESSAGE("Foe Gardevoir has Mega Evolved into Mega Gardevoir!");
|
|
} THEN {
|
|
EXPECT_EQ(player->species, SPECIES_RAYQUAZA_MEGA);
|
|
EXPECT_EQ(opponent->species, SPECIES_GARDEVOIR_MEGA);
|
|
}
|
|
}
|