sovereignx/include/constants
Nephrite 65c508d193
Secondary effects overhaul minor follow-up (#4062)
* settwoturnstring command

* Unified two-turn attacks and Meteor Beam

To do: Solar Beam

* Solar Beam

Also fixed various function, removed EFFECT_GUST (who knows why that exists?)

* Updated Solar Beam + tests

* Redid two turn move + animations logic

Removed pointless various function; to do: remove Skull Bash, fix AI test

* Removed now-pointless flag

* Removed Skull Bash

And temporarily commented out failing AI tests

* Removed Sky Uppercut effect

Not sure when or why this was ever necessary

* Removed BattleScript_EffectSemiInvulnerable

Now uses BattleScript_EffectTwoTurnsAttack. Kept the effect; used the argument field to determine which STATUS3 such moves should apply but added a function to jump over weather checks in BattleScript_EffectTwoTurnsAttack if the current move is semi-invulnerable (since the instant-fire weather check and STATUS3 use the same field)

* Applied review changes

* Replaced VARIOUS with callnative

Tried to fix test but couldn't :/ wtf is going on

* Fixed one AI test

Cant fix the other...

* Added KNOWN_FAILING to failing AI tests

Separated them out into their own test

* Optimised script, overhauled charge turn string setting

Condensed multiple confusing macros into one, jumpifweathercheckchargeeffects. Script now tweaked and trimmed, string ids for charge turns now added to argument along with status3 (thanks to compression macro) and instant-fire-weather for semi-invulnerable and two-turn moves respectively. Also introduced a savedStringId in gBattleScripting to make string selection work.

* Unified two turn move tests + minor corrections

* Added semi-invulnerable move tests

Set the Razor Wind test to known failing - something to do with its animation?

---------

Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2024-02-04 23:02:59 +01:00
..
abilities.h Define new abilities (#3838) 2023-12-28 12:33:29 +01:00
apprentice.h
battle.h Adds Dragon Cheer (#4122) 2024-02-03 08:00:41 -07:00
battle_ai.h Smarter SwitchAI Mon Choices | HasBadOdds Switch Check (#3253) 2023-11-11 14:37:35 +01:00
battle_anim.h Fix rain dance/sunny day not blending opponent sprite (#3785) 2023-12-21 13:17:05 +01:00
battle_anim_scripts.h Add many gen 8 move animations (#2861) 2023-06-21 13:19:54 -04:00
battle_arena.h
battle_dome.h Battle Dome Automation (#3596) 2023-11-24 16:19:32 +01:00
battle_factory.h
battle_frontier.h Partner Battle refactor (#3592) 2023-12-20 12:38:28 +01:00
battle_frontier_mons.h
battle_frontier_trainers.h
battle_move_effects.h Secondary effects overhaul minor follow-up (#4062) 2024-02-04 23:02:59 +01:00
battle_palace.h Clean up pokemon/ball/dex mentions in comments 2023-12-12 19:02:36 +01:00
battle_partner.h Partner Battle refactor (#3592) 2023-12-20 12:38:28 +01:00
battle_pike.h
battle_pyramid.h
battle_script_commands.h Secondary effects overhaul minor follow-up (#4062) 2024-02-04 23:02:59 +01:00
battle_setup.h
battle_string_ids.h Secondary effects overhaul minor follow-up (#4062) 2024-02-04 23:02:59 +01:00
battle_tent.h
battle_tent_mons.h
battle_tent_trainers.h
battle_tower.h
battle_z_move_effects.h Removed some hardcoded move IDs (#3982) 2024-01-12 22:41:46 +01:00
berry.h Refactor growth time and add six stage toggle 2023-12-07 13:22:01 +01:00
cable_club.h
coins.h
contest.h Merge remote-tracking branch 'pret/master' into RHH/pr/upcoming/pret_20230829 2023-08-31 14:28:01 -04:00
cries.h Add Indigo Disk Pokemon data (#3878) 2024-01-01 01:38:50 +01:00
daycare.h Converts a bunch of #if to regular conditions (#4071) 2024-01-26 18:15:45 +01:00
decorations.h
easy_chat.h
event_bg.h
event_object_movement.h Port pokefirered's Vs. Seeker to pokeemerald (#3256) 2023-11-26 18:58:43 +01:00
event_objects.h
expansion.h Non-tagged 2024-01-17 11:52:04 -03:00
field_effects.h Port pokefirered's Vs. Seeker to pokeemerald (#3256) 2023-11-26 18:58:43 +01:00
field_poison.h
field_specials.h Clean up pokemon/ball/dex mentions in comments 2023-12-12 19:02:36 +01:00
field_tasks.h
field_weather.h
flags.h Merge pull request #1904 from GriffinRichards/temp-alias 2023-08-11 15:45:00 -04:00
form_change_types.h Add status form change 2023-12-15 11:17:35 +01:00
frontier_util.h
game_stat.h Rename GAME_STAT_FISHING_CAPTURES to GAME_STAT_FISHING_ENCOUNTERS 2023-06-05 14:15:07 +02:00
global.h Converts a bunch of #if to regular conditions (#4071) 2024-01-26 18:15:45 +01:00
heal_locations.h
hold_effects.h Change Ivy Cudgel to be based on Ogerpon form rather than held item (#3865) 2023-12-30 11:40:58 +01:00
item.h Rename gItems and gAbilities to gItemsInfo and gAbilitiesInfo (#4068) 2024-01-26 15:25:52 -03:00
item_effects.h Add Teal Mask item, move, and ability data (#3349) 2023-10-08 15:56:09 -03:00
items.h Converts a bunch of #if to regular conditions (#4071) 2024-01-26 18:15:45 +01:00
layouts.h
lilycove_lady.h
map_groups.h
map_scripts.h
map_types.h
maps.h
mauville_old_man.h
metatile_behaviors.h
metatile_labels.h
moves.h Metronome move fix (#3852) 2023-12-28 16:57:29 +01:00
mystery_gift.h
opponents.h Partner Battle refactor (#3592) 2023-12-20 12:38:28 +01:00
party_menu.h Add support for legendary fusion (#3274) 2023-11-23 22:59:51 +01:00
pokedex.h Add Indigo Disk Pokemon data (#3878) 2024-01-01 01:38:50 +01:00
pokemon.h Adds missing evolution methods (#4087) 2024-02-01 18:35:38 -03:00
pokemon_debug.h
region_map_sections.h
rgb.h
roulette.h
script_menu.h Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into berryexpansion 2024-01-05 00:32:21 +01:00
secret_bases.h
slot_machine.h
songs.h
sound.h
species.h Add Indigo Disk Pokemon data (#3878) 2024-01-01 01:38:50 +01:00
tms_hms.h Reference TMs and HMs by move instead of number (#1732) 2023-08-09 10:51:01 -04:00
trade.h
trainer_hill.h Fix some frontier gfx, adjacent cleanup 2023-08-03 11:15:15 -04:00
trainer_types.h
trainers.h Refactor mugshots (#4000) 2024-01-16 00:45:13 +01:00
tv.h Clean up pokemon/ball/dex mentions in comments 2023-12-12 19:02:36 +01:00
union_room.h
vars.h Add temp var aliases 2023-08-04 14:17:28 -04:00
weather.h
wild_encounter.h