atiran/sovereignx
3
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
sovereignx/data/text
History
psf fe16a2cdee
Port pokefirered's Vs. Seeker to pokeemerald (#3256) 
* First version of Vs. Seeker

* Update movement.inc

98f7e9978d (r1306721924)

* Update field_effect_scripts.s

https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306722004

* Update field_effect_scripts.s

https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306722024

* Update item_use.h

https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306722401

* Update movement_action_func_tables.h

https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306722828

* Update event_object_movement.c

https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306722887

* Update overworld.c

https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306723396

* Update vs_seeker.h

https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306724158

* Update vs_seeker.c

Addressed some cleanup comments from SBird

* Update UpdateRandomTrainerRematches
Fixed typo in ClearAllTrainerRematchStates
Fixed types in GetRematchableTrainerLocalId

* Updated UseVsSeekerEffect_2

* Updated UseVsSeekerEffect_3

* Updated UseVsSeekerEffect_4

* Fixed bug that allowed Vs Seeker to be used indoors in correct places
Moved VsSeeker function declarations into header

* Refactored FieldUseFunc_VsSeeker

* Added curly braces to else case in FieldUseFunc_VsSeeker

* renamed data[x] in Task_ResetObjectsRematchWantedState

* Refactored Task_ResetObjectsRematchWantedState

* Refactored VsSeekerResetObjectMovementAfterChargeComplete

* Refactored ResetMovementOfRematchableTrainers

* Refactored GatherNearbyTrainerInfo

* Refactored Task_VsSeeker_3

* CanUseVsSeeker

* Refactored GetVsSeekerResponseInArea

* GetCurVsSeekerResponse refactored

* Cleaned up GetTrainerFlagFromScript

* Gave sensible names to Task_VsSeeker

* Fixed two bugs where player would not have the right gfx state after using VsSeeker on a Bike or Underwater

* Renamed UseVsSeeker Functions

* Added I_VS_SEEKER_CHARGING to make Vs. Seeker broken until flag is assigned
Removed extra VsSeeker animation code

* Addressed PR feedback

* Fixed issue with building non-modern

* Refactored GetRunningBehaviorFromGraphicsId and renamed to GetResponseMovementTypeFromTrainerGraphicsId

* Addresses Lunos's PR feedback: https://github.com/rh-hideout/pokeemerald-expansion/pull/3256\#pullrequestreview-1623547850
Removed the check to see if a map was not indoors to improve readability
Made IsValidLocationForVsSeeker into a static function

* Added changes in response to Jasper's feedback
https://github.com/rh-hideout/pokeemerald-expansion/pull/3256\#pullrequestreview-1725276522

* Updated with Edu's discord feedback https://discord.com/channels/419213663107416084/1135040810082123907/1176872015085453392

* Removed ifdef tags around the repo unless needed
b5dc744ced
2023-11-26 18:58:43 +01:00
..
abnormal_weather.inc Remove address comments 2021-07-20 15:18:31 -04:00
apprentice.inc Remove address comments 2021-07-20 15:18:31 -04:00
battle_dome.inc More battle_dome.c doc 2020-01-07 22:30:37 -05:00
battle_tent.inc Remove address comments 2021-07-20 15:18:31 -04:00
berries.inc Remove address comments 2021-07-20 15:18:31 -04:00
birch_speech.inc Remove address comments 2021-07-20 15:18:31 -04:00
blend_master.inc Remove address comments 2021-07-20 15:18:31 -04:00
braille.inc Better braille support 2021-10-30 16:19:10 -04:00
cable_club.inc Remove address comments 2021-07-20 15:18:31 -04:00
check_furniture.inc Remove address comments 2021-07-20 15:18:31 -04:00
contest_link.inc Remove address comments 2021-07-20 15:18:31 -04:00
contest_painting.inc Remove address comments 2021-07-20 15:18:31 -04:00
contest_strings.inc Corrected two missing newlines 2022-06-17 12:05:32 -03:00
event_ticket_1.inc Remove address comments 2021-07-20 15:18:31 -04:00
event_ticket_2.inc Fixed instances of .string being used with spaces instead of tabs 2022-08-15 14:32:01 -04:00
frontier_brain.inc Remove address comments 2021-07-20 15:18:31 -04:00
lottery_corner.inc Remove address comments 2021-07-20 15:18:31 -04:00
mart_clerk.inc Remove address comments 2021-07-20 15:18:31 -04:00
match_call.inc Remove address comments 2021-07-20 15:18:31 -04:00
mauville_man.inc More mauville_old_man clean up 2021-10-18 14:40:04 -04:00
move_tutors.inc Remove address comments 2021-07-20 15:18:31 -04:00
obtain_item.inc Remove address comments 2021-07-20 15:18:31 -04:00
pc.inc Remove address comments 2021-07-20 15:18:31 -04:00
pc_transfer.inc Format newlines in pc_transfer.inc 2022-06-17 14:22:31 -03:00
pkmn_center_nurse.inc Fixed instances of .string being used with spaces instead of tabs 2022-08-15 14:32:01 -04:00
pokedex_rating.inc Fix inconsistent static s/g names 2022-05-17 14:00:02 -04:00
pokemon_news.inc Remove address comments 2021-07-20 15:18:31 -04:00
questionnaire.inc Correct usage of MysteryEvent to MysteryGift 2021-10-17 03:00:48 -04:00
record_mix.inc Remove address comments 2021-07-20 15:18:31 -04:00
save.inc Remove address comments 2021-07-20 15:18:31 -04:00
secret_base_trainers.inc Fixed instances of .string being used with spaces instead of tabs 2022-08-15 14:32:01 -04:00
shoal_cave.inc Remove address comments 2021-07-20 15:18:31 -04:00
surf.inc Format newlines in surf.inc 2022-06-17 15:21:12 -03:00
trainers.inc Port pokefirered's Vs. Seeker to pokeemerald (#3256) 2023-11-26 18:58:43 +01:00
trick_house_mechadolls.inc Remove address comments 2021-07-20 15:18:31 -04:00
tv.inc Document battle tower TV show 2022-06-14 09:37:39 -04:00