atiran/sovereignx
3
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
sovereignx/data/text
History
psf bf8b09b1b6
Item Ball refactor / Pluralize item names for giveitem and finditem (#3942) 
* Emptied out item_ball_scripts
Added GetObjectEventTrainerRangeFromTemplate
Added Common_EventScript_FindItem

* Replaced trainer_sight_or_berry_tree_id with item constant
Replaced scripts with Common_EventScript_FindItem

* Renamed to GetItemBallIdAndAmountFromTemplate
Moved to item_ball.c

* Updated ObjectEventTemplate

* Updated inc files to support plural item names

* Refactored CopyItemNameHandlePlural to handle all items

* Change failsafe in GetItemBallIdFromTemplate to be ITEM_NONE + 1 instead of ITEMS_COUNT

* Converted spaces to tabs
https://github.com/rh-hideout/pokeemerald-expansion/pull/3942\#discussion_r1446415663
https://github.com/rh-hideout/pokeemerald-expansion/pull/3942\#discussion_r1446415525
https://github.com/rh-hideout/pokeemerald-expansion/pull/3942\#discussion_r1446415409
https://github.com/rh-hideout/pokeemerald-expansion/pull/3942\#discussion_r1446415130

* Added warning on object_event macro to prevent silent failure
Reverted global.fieldmap to original state, per feedback

---------

Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2024-01-14 21:35:45 +01:00
..
abnormal_weather.inc Remove address comments 2021-07-20 15:18:31 -04:00
apprentice.inc Remove address comments 2021-07-20 15:18:31 -04:00
battle_dome.inc More battle_dome.c doc 2020-01-07 22:30:37 -05:00
battle_tent.inc Remove address comments 2021-07-20 15:18:31 -04:00
berries.inc Remove address comments 2021-07-20 15:18:31 -04:00
birch_speech.inc Remove address comments 2021-07-20 15:18:31 -04:00
blend_master.inc Remove address comments 2021-07-20 15:18:31 -04:00
braille.inc Better braille support 2021-10-30 16:19:10 -04:00
cable_club.inc Remove address comments 2021-07-20 15:18:31 -04:00
check_furniture.inc Remove address comments 2021-07-20 15:18:31 -04:00
contest_link.inc Remove address comments 2021-07-20 15:18:31 -04:00
contest_painting.inc Remove address comments 2021-07-20 15:18:31 -04:00
contest_strings.inc Corrected two missing newlines 2022-06-17 12:05:32 -03:00
event_ticket_1.inc Remove address comments 2021-07-20 15:18:31 -04:00
event_ticket_2.inc Fixed instances of .string being used with spaces instead of tabs 2022-08-15 14:32:01 -04:00
frontier_brain.inc Remove address comments 2021-07-20 15:18:31 -04:00
lottery_corner.inc Remove address comments 2021-07-20 15:18:31 -04:00
mart_clerk.inc Remove address comments 2021-07-20 15:18:31 -04:00
match_call.inc Remove address comments 2021-07-20 15:18:31 -04:00
mauville_man.inc More mauville_old_man clean up 2021-10-18 14:40:04 -04:00
move_tutors.inc Remove address comments 2021-07-20 15:18:31 -04:00
obtain_item.inc Item Ball refactor / Pluralize item names for giveitem and finditem (#3942) 2024-01-14 21:35:45 +01:00
pc.inc Remove address comments 2021-07-20 15:18:31 -04:00
pc_transfer.inc Format newlines in pc_transfer.inc 2022-06-17 14:22:31 -03:00
pkmn_center_nurse.inc Fixed instances of .string being used with spaces instead of tabs 2022-08-15 14:32:01 -04:00
pokedex_rating.inc Fix inconsistent static s/g names 2022-05-17 14:00:02 -04:00
pokemon_news.inc Remove address comments 2021-07-20 15:18:31 -04:00
questionnaire.inc Correct usage of MysteryEvent to MysteryGift 2021-10-17 03:00:48 -04:00
record_mix.inc Remove address comments 2021-07-20 15:18:31 -04:00
save.inc Remove address comments 2021-07-20 15:18:31 -04:00
secret_base_trainers.inc Fixed instances of .string being used with spaces instead of tabs 2022-08-15 14:32:01 -04:00
shoal_cave.inc Remove address comments 2021-07-20 15:18:31 -04:00
surf.inc Format newlines in surf.inc 2022-06-17 15:21:12 -03:00
trainers.inc Port pokefirered's Vs. Seeker to pokeemerald (#3256) 2023-11-26 18:58:43 +01:00
trick_house_mechadolls.inc Remove address comments 2021-07-20 15:18:31 -04:00
tv.inc Document battle tower TV show 2022-06-14 09:37:39 -04:00