atiran/sovereignx
3
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
sovereignx/graphics/field_effects/pics
History
psf fe16a2cdee
Port pokefirered's Vs. Seeker to pokeemerald (#3256) 
* First version of Vs. Seeker

* Update movement.inc

98f7e9978d (r1306721924)

* Update field_effect_scripts.s

https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306722004

* Update field_effect_scripts.s

https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306722024

* Update item_use.h

https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306722401

* Update movement_action_func_tables.h

https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306722828

* Update event_object_movement.c

https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306722887

* Update overworld.c

https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306723396

* Update vs_seeker.h

https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306724158

* Update vs_seeker.c

Addressed some cleanup comments from SBird

* Update UpdateRandomTrainerRematches
Fixed typo in ClearAllTrainerRematchStates
Fixed types in GetRematchableTrainerLocalId

* Updated UseVsSeekerEffect_2

* Updated UseVsSeekerEffect_3

* Updated UseVsSeekerEffect_4

* Fixed bug that allowed Vs Seeker to be used indoors in correct places
Moved VsSeeker function declarations into header

* Refactored FieldUseFunc_VsSeeker

* Added curly braces to else case in FieldUseFunc_VsSeeker

* renamed data[x] in Task_ResetObjectsRematchWantedState

* Refactored Task_ResetObjectsRematchWantedState

* Refactored VsSeekerResetObjectMovementAfterChargeComplete

* Refactored ResetMovementOfRematchableTrainers

* Refactored GatherNearbyTrainerInfo

* Refactored Task_VsSeeker_3

* CanUseVsSeeker

* Refactored GetVsSeekerResponseInArea

* GetCurVsSeekerResponse refactored

* Cleaned up GetTrainerFlagFromScript

* Gave sensible names to Task_VsSeeker

* Fixed two bugs where player would not have the right gfx state after using VsSeeker on a Bike or Underwater

* Renamed UseVsSeeker Functions

* Added I_VS_SEEKER_CHARGING to make Vs. Seeker broken until flag is assigned
Removed extra VsSeeker animation code

* Addressed PR feedback

* Fixed issue with building non-modern

* Refactored GetRunningBehaviorFromGraphicsId and renamed to GetResponseMovementTypeFromTrainerGraphicsId

* Addresses Lunos's PR feedback: https://github.com/rh-hideout/pokeemerald-expansion/pull/3256\#pullrequestreview-1623547850
Removed the check to see if a map was not indoors to improve readability
Made IsValidLocationForVsSeeker into a static function

* Added changes in response to Jasper's feedback
https://github.com/rh-hideout/pokeemerald-expansion/pull/3256\#pullrequestreview-1725276522

* Updated with Edu's discord feedback https://discord.com/channels/419213663107416084/1135040810082123907/1176872015085453392

* Removed ifdef tags around the repo unless needed
b5dc744ced
2023-11-26 18:58:43 +01:00
..
pokecenter_monitor Move more graphics out of misc 2022-01-14 12:29:30 -05:00
sand_pillar Document more misc field effects 2020-06-29 16:32:46 -04:00
arrow.png Move field effects data and graphics into own directory, and cleanup naming for object events 2020-02-12 17:32:51 -06:00
ash.png Move field effects data and graphics into own directory, and cleanup naming for object events 2020-02-12 17:32:51 -06:00
ash_launch.png Continue documenting overworld/field effects 2020-06-29 01:26:29 -04:00
ash_puff.png Continue documenting overworld/field effects 2020-06-29 01:26:29 -04:00
bike_tire_tracks.png Move field effects data and graphics into own directory, and cleanup naming for object events 2020-02-12 17:32:51 -06:00
bird.png Move field effects data and graphics into own directory, and cleanup naming for object events 2020-02-12 17:32:51 -06:00
bubbles.png Move field effects data and graphics into own directory, and cleanup naming for object events 2020-02-12 17:32:51 -06:00
cut_grass.png Move field effects data and graphics into own directory, and cleanup naming for object events 2020-02-12 17:32:51 -06:00
deep_sand_footprints.png Move field effects data and graphics into own directory, and cleanup naming for object events 2020-02-12 17:32:51 -06:00
deoxys_rock_fragment_bottom_left.png Apply palettes to some field effect pngs 2022-01-14 12:51:13 -05:00
deoxys_rock_fragment_bottom_right.png Apply palettes to some field effect pngs 2022-01-14 12:51:13 -05:00
deoxys_rock_fragment_top_left.png Apply palettes to some field effect pngs 2022-01-14 12:51:13 -05:00
deoxys_rock_fragment_top_right.png Apply palettes to some field effect pngs 2022-01-14 12:51:13 -05:00
emote_x.png Port pokefirered's Vs. Seeker to pokeemerald (#3256) 2023-11-26 18:58:43 +01:00
emotion_double_exclamation.png Port pokefirered's Vs. Seeker to pokeemerald (#3256) 2023-11-26 18:58:43 +01:00
emotion_exclamation.png Apply palettes to some field effect pngs 2022-01-14 12:51:13 -05:00
emotion_heart.png Apply palettes to some field effect pngs 2022-01-14 12:51:13 -05:00
emotion_question.png Apply palettes to some field effect pngs 2022-01-14 12:51:13 -05:00
field_move_streaks.bin Move more graphics out of misc 2022-01-14 12:29:30 -05:00
field_move_streaks.png Move more graphics out of misc 2022-01-14 12:29:30 -05:00
field_move_streaks_indoors.bin Move more graphics out of misc 2022-01-14 12:29:30 -05:00
field_move_streaks_indoors.png Move more graphics out of misc 2022-01-14 12:29:30 -05:00
ground_impact_dust.png Move field effects data and graphics into own directory, and cleanup naming for object events 2020-02-12 17:32:51 -06:00
hof_monitor_big.png Apply palettes to some field effect pngs 2022-01-14 12:51:13 -05:00
hof_monitor_small.png Apply palettes to some field effect pngs 2022-01-14 12:51:13 -05:00
hot_springs_water.png Move field effects data and graphics into own directory, and cleanup naming for object events 2020-02-12 17:32:51 -06:00
jump_big_splash.png Continue documenting overworld/field effects 2020-06-29 01:26:29 -04:00
jump_long_grass.png Name unknown_16.png 2022-03-14 15:54:47 -04:00
jump_small_splash.png Continue documenting overworld/field effects 2020-06-29 01:26:29 -04:00
jump_tall_grass.png Continue documenting overworld/field effects 2020-06-29 01:26:29 -04:00
long_grass.png Move field effects data and graphics into own directory, and cleanup naming for object events 2020-02-12 17:32:51 -06:00
mountain_disguise.png Move field effects data and graphics into own directory, and cleanup naming for object events 2020-02-12 17:32:51 -06:00
pokeball_glow.png Apply palettes to some field effect pngs 2022-01-14 12:51:13 -05:00
record_mix_lights.png Document more misc field effects 2020-06-29 16:32:46 -04:00
ripple.png Move field effects data and graphics into own directory, and cleanup naming for object events 2020-02-12 17:32:51 -06:00
sand_disguise_placeholder.png Move field effects data and graphics into own directory, and cleanup naming for object events 2020-02-12 17:32:51 -06:00
sand_footprints.png Move field effects data and graphics into own directory, and cleanup naming for object events 2020-02-12 17:32:51 -06:00
sand_pile.png Document some overworld and field effects 2020-06-23 15:48:53 -04:00
secret_power_cave.png Document more misc field effects 2020-06-29 16:32:46 -04:00
secret_power_shrub.png Document more misc field effects 2020-06-29 16:32:46 -04:00
secret_power_tree.png Document more misc field effects 2020-06-29 16:32:46 -04:00
shadow_extra_large.png Move field effects data and graphics into own directory, and cleanup naming for object events 2020-02-12 17:32:51 -06:00
shadow_large.png Move field effects data and graphics into own directory, and cleanup naming for object events 2020-02-12 17:32:51 -06:00
shadow_medium.png Move field effects data and graphics into own directory, and cleanup naming for object events 2020-02-12 17:32:51 -06:00
shadow_small.png Move field effects data and graphics into own directory, and cleanup naming for object events 2020-02-12 17:32:51 -06:00
short_grass.png Move field effects data and graphics into own directory, and cleanup naming for object events 2020-02-12 17:32:51 -06:00
small_sparkle.png Document some overworld and field effects 2020-06-23 15:48:53 -04:00
sparkle.png Document some overworld and field effects 2020-06-23 15:48:53 -04:00
splash.png Move field effects data and graphics into own directory, and cleanup naming for object events 2020-02-12 17:32:51 -06:00
spotlight.png Move more graphics out of misc 2022-01-14 12:29:30 -05:00
surf_blob.png Move field effects data and graphics into own directory, and cleanup naming for object events 2020-02-12 17:32:51 -06:00
tall_grass.png Move field effects data and graphics into own directory, and cleanup naming for object events 2020-02-12 17:32:51 -06:00
tree_disguise.png Move field effects data and graphics into own directory, and cleanup naming for object events 2020-02-12 17:32:51 -06:00
unknown_17.png Move field effects data and graphics into own directory, and cleanup naming for object events 2020-02-12 17:32:51 -06:00
unused_grass_2.png Continue documenting overworld/field effects 2020-06-29 01:26:29 -04:00
unused_grass_3.png Continue documenting overworld/field effects 2020-06-29 01:26:29 -04:00
unused_sand.png Clean up field effect doc 2020-07-02 05:05:13 -04:00
water_surfacing.png Continue documenting overworld/field effects 2020-06-29 01:26:29 -04:00