a64e1c63c1
* Made gBattleMoves handle the InGame name and description of battle moves No more multiple arrays in separate, individual files. Note: -Keep an eye on Task_LearnedMove. * Reintroduced move names Misc: -Fixed Trick-or-Treat and Light of Ruin's expanded names. -Introduced a new field for Z-Move names, and a constant for their name length. -Added a few TODOs to GetBattleMoveName. -Updated GetMaxMoveName and GetZMoveName. There's no reason not to let GetBattleMoveName handle everything on its own. * Updated GetBattleMoveName to handle Z-Move Names Misc: -Removed pointless TODO about MOVE_NAME_LENGTH. -The compiler doesn't allow to have a move name with a value higher than MOVE_NAME_LENGTH, therefore it's pointless to worry about it. * Fixed a couple of expanded move names * Removed zMoveName variable of struct BattleMove and extended the name variable's size * Ditched no longer used MOVE_NAME_LENGTH constant * Corrected the names of the max moves I should have done this after updating the size of the name variable of the struct BattleMove, but I didn't think about it at all until Cancer Fairy indirectly gave me the idea. * Fixed U-turn's name * Brought back MOVE_NAME_LENGTH I think it doesn't make sense to have a Z_MOVE_NAME_LENGTH because the length in question is used for all battle moves, not just the Z-Moves. * Introduced a union for Move/Z-Move names in the struct BattleMove * Fixed the union for gBattleMoves move names Also updated GetBattleMoveName to properly handle Max Move names. Also also renamed the "zMoveName" variable to "bigMoveName" which better reflects its purpose. Z-Move names weren't the only thing it covered, since it also handles Max Move names. * Removed deprecated GetZMoveName and GetMaxMoveName * Reintroduced mention to gMoveNames in sGFRomHeader * Fixed move names and ported move descriptions * Fused the struct ContestMove into the struct BattleMove * Removed no longer used Z_MOVE_NAME_LENGTH constant * Renamed the struct BattleMove's bigMoveName variable and introduced macros to prettify move names * Reintroduced the contest parameters for Pokémon moves * Renamed gBattleMoves to gMovesInfo This is consistent with gSpeciesInfo, the array that contains most of the species data. * Renamed the BattleMove struct to MovesInfo This is consistent with the struct SpeciesInfo, which contains the variables used by the gSpeciesInfo array. * Removed empty lines separating battle params from contest params in gMovesInfo * Renamed MovesInfo to MoveInfo * Added Cancer Fairy's HANDLE_EXPANDED_MOVE_NAME macro Used to handle moves with expanded names in a more comfortable manner. Also fixed Trick-or-Treat's expanded name. * Renamed GetBattleMoveName to GetMoveName * Added a comment pointing out that the shared move descriptions are shared move descriptions * Re-aligned one of the escape characters of CHECK_MOVE_FLAG * Renamed the battle_moves.h file to moves_info.h instead for consistency's sake * Applied Eduardo's adjustments * Using compound string for regular move names as well, saving 1180 bytes and making their use consistent * Move description formatting * Updated Pursuit test after merge * Renamed the BATTLE_CATEGORY constants to DAMAGE_CATEGORY --------- Co-authored-by: Nephrite <thechurchofcage@gmail.com> Co-authored-by: Bassoonian <iasperbassoonian@gmail.com> Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
230 lines
8.2 KiB
C
230 lines
8.2 KiB
C
#include "global.h"
|
|
#include "test/battle.h"
|
|
|
|
ASSUMPTIONS
|
|
{
|
|
ASSUME(gMovesInfo[MOVE_ALLY_SWITCH].effect == EFFECT_ALLY_SWITCH);
|
|
}
|
|
|
|
SINGLE_BATTLE_TEST("Ally Switch fails in a single battle")
|
|
{
|
|
GIVEN {
|
|
PLAYER(SPECIES_WOBBUFFET);
|
|
OPPONENT(SPECIES_WOBBUFFET);
|
|
} WHEN {
|
|
TURN { MOVE(player, MOVE_ALLY_SWITCH); }
|
|
} SCENE {
|
|
MESSAGE("Wobbuffet used Ally Switch!");
|
|
NOT ANIMATION(ANIM_TYPE_MOVE, MOVE_ALLY_SWITCH, player);
|
|
MESSAGE("But it failed!");
|
|
}
|
|
}
|
|
|
|
DOUBLE_BATTLE_TEST("Ally Switch fails if there is no partner")
|
|
{
|
|
GIVEN {
|
|
PLAYER(SPECIES_WOBBUFFET);
|
|
PLAYER(SPECIES_WOBBUFFET) { HP(1); }
|
|
OPPONENT(SPECIES_WOBBUFFET);
|
|
OPPONENT(SPECIES_WOBBUFFET);
|
|
} WHEN {
|
|
TURN { MOVE(opponentLeft, MOVE_TACKLE, target:playerRight); }
|
|
TURN { MOVE(playerLeft, MOVE_ALLY_SWITCH); }
|
|
} SCENE {
|
|
MESSAGE("Wobbuffet fainted!");
|
|
MESSAGE("Wobbuffet used Ally Switch!");
|
|
NOT ANIMATION(ANIM_TYPE_MOVE, MOVE_ALLY_SWITCH, playerLeft);
|
|
MESSAGE("But it failed!");
|
|
}
|
|
}
|
|
|
|
DOUBLE_BATTLE_TEST("Ally Switch changes the position of battlers")
|
|
{
|
|
GIVEN {
|
|
ASSUME(gMovesInfo[MOVE_SCREECH].effect == EFFECT_DEFENSE_DOWN_2);
|
|
ASSUME(gMovesInfo[MOVE_SCREECH].target == MOVE_TARGET_SELECTED);
|
|
PLAYER(SPECIES_WOBBUFFET) { Speed(5); } // Wobb is playerLeft, but it'll be Wynaut after Ally Switch
|
|
PLAYER(SPECIES_WYNAUT) { Speed(4); }
|
|
OPPONENT(SPECIES_KADABRA) { Speed(3); }
|
|
OPPONENT(SPECIES_ABRA) { Speed(2); }
|
|
} WHEN {
|
|
TURN { MOVE(playerLeft, MOVE_ALLY_SWITCH); MOVE(opponentLeft, MOVE_SCREECH, target:playerLeft); MOVE(opponentRight, MOVE_SCREECH, target:playerLeft); }
|
|
} SCENE {
|
|
MESSAGE("Wobbuffet used Ally Switch!");
|
|
ANIMATION(ANIM_TYPE_MOVE, MOVE_ALLY_SWITCH, playerLeft);
|
|
MESSAGE("Wobbuffet and Wynaut switched places!");
|
|
|
|
MESSAGE("Foe Kadabra used Screech!");
|
|
ANIMATION(ANIM_TYPE_GENERAL, B_ANIM_STATS_CHANGE, playerLeft);
|
|
MESSAGE("Wynaut's Defense harshly fell!");
|
|
|
|
MESSAGE("Foe Abra used Screech!");
|
|
ANIMATION(ANIM_TYPE_GENERAL, B_ANIM_STATS_CHANGE, playerLeft);
|
|
MESSAGE("Wynaut's Defense harshly fell!");
|
|
} THEN {
|
|
EXPECT_EQ(playerLeft->speed, 4);
|
|
EXPECT_EQ(playerLeft->species, SPECIES_WYNAUT);
|
|
EXPECT_EQ(playerRight->speed, 5);
|
|
EXPECT_EQ(playerRight->species, SPECIES_WOBBUFFET);
|
|
}
|
|
}
|
|
|
|
DOUBLE_BATTLE_TEST("Ally Switch does not redirect the target of Snipe Shot")
|
|
{
|
|
GIVEN {
|
|
ASSUME(gMovesInfo[MOVE_SNIPE_SHOT].effect == EFFECT_SNIPE_SHOT);
|
|
PLAYER(SPECIES_WOBBUFFET); // Wobb is playerLeft, but it'll be Wynaut after Ally Switch
|
|
PLAYER(SPECIES_WYNAUT);
|
|
OPPONENT(SPECIES_KADABRA);
|
|
OPPONENT(SPECIES_ABRA);
|
|
} WHEN {
|
|
TURN { MOVE(playerLeft, MOVE_ALLY_SWITCH); MOVE(opponentLeft, MOVE_SNIPE_SHOT, target:playerLeft); } // Kadabra targets Wobb and Snipe Shot ignores Ally Switch position change.
|
|
} SCENE {
|
|
MESSAGE("Wobbuffet used Ally Switch!");
|
|
ANIMATION(ANIM_TYPE_MOVE, MOVE_ALLY_SWITCH, playerLeft);
|
|
MESSAGE("Wobbuffet and Wynaut switched places!");
|
|
|
|
MESSAGE("Foe Kadabra used Snipe Shot!");
|
|
ANIMATION(ANIM_TYPE_MOVE, MOVE_SNIPE_SHOT, opponentLeft);
|
|
HP_BAR(playerRight);
|
|
}
|
|
}
|
|
|
|
DOUBLE_BATTLE_TEST("Ally Switch does not redirect moves done by pokemon with Stalwart and Propeller Tail")
|
|
{
|
|
u16 ability;
|
|
PARAMETRIZE { ability = ABILITY_STALWART; }
|
|
PARAMETRIZE { ability = ABILITY_PROPELLER_TAIL; }
|
|
PARAMETRIZE { ability = ABILITY_TELEPATHY; }
|
|
|
|
GIVEN {
|
|
PLAYER(SPECIES_WOBBUFFET); // Wobb is playerLeft, but it'll be Wynaut after Ally Switch
|
|
PLAYER(SPECIES_WYNAUT);
|
|
OPPONENT(SPECIES_KADABRA) { Ability(ability); }
|
|
OPPONENT(SPECIES_ABRA);
|
|
} WHEN {
|
|
TURN { MOVE(playerLeft, MOVE_ALLY_SWITCH); MOVE(opponentLeft, MOVE_TACKLE, target:playerRight); } // Kadabra targets playerRight Wynaut.
|
|
} SCENE {
|
|
MESSAGE("Wobbuffet used Ally Switch!");
|
|
ANIMATION(ANIM_TYPE_MOVE, MOVE_ALLY_SWITCH, playerLeft);
|
|
MESSAGE("Wobbuffet and Wynaut switched places!");
|
|
|
|
MESSAGE("Foe Kadabra used Tackle!");
|
|
ANIMATION(ANIM_TYPE_MOVE, MOVE_TACKLE, opponentLeft);
|
|
HP_BAR((ability == ABILITY_STALWART || ability == ABILITY_PROPELLER_TAIL) ? playerLeft : playerRight);
|
|
}
|
|
}
|
|
|
|
DOUBLE_BATTLE_TEST("Ally Switch has no effect on parnter's chosen move")
|
|
{
|
|
u16 chosenMove;
|
|
struct BattlePokemon *chosenTarget = NULL;
|
|
|
|
PARAMETRIZE { chosenMove = MOVE_TACKLE; chosenTarget = opponentLeft; }
|
|
PARAMETRIZE { chosenMove = MOVE_TACKLE; chosenTarget = opponentRight; }
|
|
PARAMETRIZE { chosenMove = MOVE_POUND; chosenTarget = opponentLeft; }
|
|
PARAMETRIZE { chosenMove = MOVE_POUND; chosenTarget = opponentRight; }
|
|
|
|
GIVEN {
|
|
PLAYER(SPECIES_WOBBUFFET);
|
|
PLAYER(SPECIES_WYNAUT) { Moves(MOVE_TACKLE, MOVE_POUND, MOVE_CELEBRATE, MOVE_SCRATCH); }
|
|
OPPONENT(SPECIES_KADABRA);
|
|
OPPONENT(SPECIES_ABRA);
|
|
} WHEN {
|
|
TURN { MOVE(playerLeft, MOVE_ALLY_SWITCH); MOVE(playerRight, chosenMove, target:chosenTarget); }
|
|
} SCENE {
|
|
MESSAGE("Wobbuffet used Ally Switch!");
|
|
ANIMATION(ANIM_TYPE_MOVE, MOVE_ALLY_SWITCH, playerLeft);
|
|
MESSAGE("Wobbuffet and Wynaut switched places!");
|
|
|
|
ANIMATION(ANIM_TYPE_MOVE, chosenMove, playerLeft);
|
|
HP_BAR(chosenTarget);
|
|
}
|
|
}
|
|
|
|
DOUBLE_BATTLE_TEST("Ally Switch - move fails if the target was ally which changed position")
|
|
{
|
|
u32 move = MOVE_NONE;
|
|
|
|
PARAMETRIZE { move = MOVE_COACHING; }
|
|
PARAMETRIZE { move = MOVE_AROMATIC_MIST; }
|
|
PARAMETRIZE { move = MOVE_HOLD_HANDS; }
|
|
|
|
GIVEN {
|
|
PLAYER(SPECIES_WOBBUFFET);
|
|
PLAYER(SPECIES_WYNAUT);
|
|
OPPONENT(SPECIES_KADABRA);
|
|
OPPONENT(SPECIES_ABRA);
|
|
} WHEN {
|
|
TURN { MOVE(playerLeft, MOVE_ALLY_SWITCH); MOVE(playerRight, move, target:playerLeft); }
|
|
} SCENE {
|
|
MESSAGE("Wobbuffet used Ally Switch!");
|
|
ANIMATION(ANIM_TYPE_MOVE, MOVE_ALLY_SWITCH, playerLeft);
|
|
MESSAGE("Wobbuffet and Wynaut switched places!");
|
|
|
|
NOT ANIMATION(ANIM_TYPE_MOVE, move, playerLeft);
|
|
MESSAGE("But it failed!");
|
|
}
|
|
}
|
|
|
|
// Verified on Showdown, even though Bulbapedia says otherwise.
|
|
DOUBLE_BATTLE_TEST("Acupressure works after ally used Ally Switch")
|
|
{
|
|
struct BattlePokemon *battlerTarget = NULL;
|
|
|
|
PARAMETRIZE { battlerTarget = playerLeft; }
|
|
PARAMETRIZE { battlerTarget = playerRight; }
|
|
|
|
GIVEN {
|
|
PLAYER(SPECIES_WOBBUFFET);
|
|
PLAYER(SPECIES_WYNAUT);
|
|
OPPONENT(SPECIES_KADABRA);
|
|
OPPONENT(SPECIES_ABRA);
|
|
} WHEN {
|
|
TURN { MOVE(playerLeft, MOVE_ALLY_SWITCH); MOVE(playerRight, MOVE_ACUPRESSURE, target:battlerTarget); }
|
|
} SCENE {
|
|
MESSAGE("Wobbuffet used Ally Switch!");
|
|
ANIMATION(ANIM_TYPE_MOVE, MOVE_ALLY_SWITCH, playerLeft);
|
|
MESSAGE("Wobbuffet and Wynaut switched places!");
|
|
|
|
ANIMATION(ANIM_TYPE_MOVE, MOVE_ACUPRESSURE);
|
|
ANIMATION(ANIM_TYPE_GENERAL, B_ANIM_STATS_CHANGE, battlerTarget);
|
|
NOT MESSAGE("But it failed!");
|
|
}
|
|
}
|
|
|
|
DOUBLE_BATTLE_TEST("Ally Switch increases the Protect-like moves counter")
|
|
{
|
|
GIVEN {
|
|
ASSUME(B_ALLY_SWITCH_FAIL_CHANCE >= GEN_9);
|
|
PLAYER(SPECIES_WOBBUFFET);
|
|
PLAYER(SPECIES_WOBBUFFET);
|
|
OPPONENT(SPECIES_WOBBUFFET);
|
|
OPPONENT(SPECIES_WOBBUFFET);
|
|
} WHEN {
|
|
TURN { MOVE(playerLeft, MOVE_ALLY_SWITCH); }
|
|
} THEN {
|
|
EXPECT(gDisableStructs[B_POSITION_PLAYER_RIGHT].protectUses == 1);
|
|
}
|
|
}
|
|
|
|
DOUBLE_BATTLE_TEST("Ally Switch works if ally used two-turn move like Dig")
|
|
{
|
|
GIVEN {
|
|
PLAYER(SPECIES_WOBBUFFET);
|
|
PLAYER(SPECIES_WYNAUT);
|
|
OPPONENT(SPECIES_WOBBUFFET);
|
|
OPPONENT(SPECIES_WOBBUFFET);
|
|
} WHEN {
|
|
TURN { MOVE(playerRight, MOVE_DIG, target:opponentRight); }
|
|
TURN { MOVE(playerLeft, MOVE_ALLY_SWITCH); SKIP_TURN(playerRight); }
|
|
} SCENE {
|
|
MESSAGE("Wynaut used Dig!");
|
|
MESSAGE("Wobbuffet used Ally Switch!");
|
|
ANIMATION(ANIM_TYPE_MOVE, MOVE_ALLY_SWITCH, playerLeft);
|
|
MESSAGE("Wobbuffet and Wynaut switched places!");
|
|
NOT MESSAGE("Wynaut used -!");
|
|
ANIMATION(ANIM_TYPE_MOVE, MOVE_DIG);
|
|
HP_BAR(opponentRight);
|
|
}
|
|
}
|