a64e1c63c1
* Made gBattleMoves handle the InGame name and description of battle moves No more multiple arrays in separate, individual files. Note: -Keep an eye on Task_LearnedMove. * Reintroduced move names Misc: -Fixed Trick-or-Treat and Light of Ruin's expanded names. -Introduced a new field for Z-Move names, and a constant for their name length. -Added a few TODOs to GetBattleMoveName. -Updated GetMaxMoveName and GetZMoveName. There's no reason not to let GetBattleMoveName handle everything on its own. * Updated GetBattleMoveName to handle Z-Move Names Misc: -Removed pointless TODO about MOVE_NAME_LENGTH. -The compiler doesn't allow to have a move name with a value higher than MOVE_NAME_LENGTH, therefore it's pointless to worry about it. * Fixed a couple of expanded move names * Removed zMoveName variable of struct BattleMove and extended the name variable's size * Ditched no longer used MOVE_NAME_LENGTH constant * Corrected the names of the max moves I should have done this after updating the size of the name variable of the struct BattleMove, but I didn't think about it at all until Cancer Fairy indirectly gave me the idea. * Fixed U-turn's name * Brought back MOVE_NAME_LENGTH I think it doesn't make sense to have a Z_MOVE_NAME_LENGTH because the length in question is used for all battle moves, not just the Z-Moves. * Introduced a union for Move/Z-Move names in the struct BattleMove * Fixed the union for gBattleMoves move names Also updated GetBattleMoveName to properly handle Max Move names. Also also renamed the "zMoveName" variable to "bigMoveName" which better reflects its purpose. Z-Move names weren't the only thing it covered, since it also handles Max Move names. * Removed deprecated GetZMoveName and GetMaxMoveName * Reintroduced mention to gMoveNames in sGFRomHeader * Fixed move names and ported move descriptions * Fused the struct ContestMove into the struct BattleMove * Removed no longer used Z_MOVE_NAME_LENGTH constant * Renamed the struct BattleMove's bigMoveName variable and introduced macros to prettify move names * Reintroduced the contest parameters for Pokémon moves * Renamed gBattleMoves to gMovesInfo This is consistent with gSpeciesInfo, the array that contains most of the species data. * Renamed the BattleMove struct to MovesInfo This is consistent with the struct SpeciesInfo, which contains the variables used by the gSpeciesInfo array. * Removed empty lines separating battle params from contest params in gMovesInfo * Renamed MovesInfo to MoveInfo * Added Cancer Fairy's HANDLE_EXPANDED_MOVE_NAME macro Used to handle moves with expanded names in a more comfortable manner. Also fixed Trick-or-Treat's expanded name. * Renamed GetBattleMoveName to GetMoveName * Added a comment pointing out that the shared move descriptions are shared move descriptions * Re-aligned one of the escape characters of CHECK_MOVE_FLAG * Renamed the battle_moves.h file to moves_info.h instead for consistency's sake * Applied Eduardo's adjustments * Using compound string for regular move names as well, saving 1180 bytes and making their use consistent * Move description formatting * Updated Pursuit test after merge * Renamed the BATTLE_CATEGORY constants to DAMAGE_CATEGORY --------- Co-authored-by: Nephrite <thechurchofcage@gmail.com> Co-authored-by: Bassoonian <iasperbassoonian@gmail.com> Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
160 lines
5.4 KiB
C
160 lines
5.4 KiB
C
#include "global.h"
|
|
#include "test/battle.h"
|
|
|
|
ASSUMPTIONS
|
|
{
|
|
ASSUME(gMovesInfo[MOVE_WATER_GUN].power != 0);
|
|
}
|
|
|
|
SINGLE_BATTLE_TEST("Battle Bond does not transform species other than Greninja")
|
|
{
|
|
GIVEN {
|
|
PLAYER(SPECIES_WOBBUFFET) { Ability(ABILITY_BATTLE_BOND); }
|
|
OPPONENT(SPECIES_WOBBUFFET) { HP(1); }
|
|
OPPONENT(SPECIES_WOBBUFFET);
|
|
} WHEN {
|
|
TURN { MOVE(player, MOVE_WATER_GUN); SEND_OUT(opponent, 1); }
|
|
} SCENE {
|
|
HP_BAR(opponent);
|
|
MESSAGE("Foe Wobbuffet fainted!");
|
|
NONE_OF {
|
|
ABILITY_POPUP(player, ABILITY_BATTLE_BOND);
|
|
MESSAGE("Wobbuffet became fully charged due to its bond with its trainer!");
|
|
}
|
|
} THEN {
|
|
EXPECT(player->species == SPECIES_WOBBUFFET);
|
|
}
|
|
}
|
|
|
|
// Battle Bond transforms the pokemon when fainting any battler(opposing or partner), unless it's the last pokemon and the battle ends.
|
|
SINGLE_BATTLE_TEST("Battle Bond transforms player's Greninja - Singles")
|
|
{
|
|
u32 monsCountPlayer, monsCountOpponent;
|
|
|
|
PARAMETRIZE {monsCountPlayer = 1; monsCountOpponent = 1; }
|
|
PARAMETRIZE {monsCountPlayer = 1; monsCountOpponent = 2; }
|
|
PARAMETRIZE {monsCountPlayer = 2; monsCountOpponent = 1; }
|
|
PARAMETRIZE {monsCountPlayer = 2; monsCountOpponent = 2; }
|
|
|
|
GIVEN {
|
|
PLAYER(SPECIES_GRENINJA_BATTLE_BOND);
|
|
if (monsCountPlayer == 2) {
|
|
PLAYER(SPECIES_WOBBUFFET);
|
|
}
|
|
OPPONENT(SPECIES_WOBBUFFET) { HP(1); }
|
|
if (monsCountOpponent == 2) {
|
|
OPPONENT(SPECIES_WOBBUFFET);
|
|
}
|
|
} WHEN {
|
|
if (monsCountOpponent == 2) {
|
|
TURN { MOVE(player, MOVE_WATER_GUN); SEND_OUT(opponent, 1); }
|
|
} else {
|
|
TURN { MOVE(player, MOVE_WATER_GUN); }
|
|
}
|
|
|
|
} SCENE {
|
|
HP_BAR(opponent);
|
|
MESSAGE("Foe Wobbuffet fainted!");
|
|
if (monsCountOpponent != 1) {
|
|
ABILITY_POPUP(player, ABILITY_BATTLE_BOND);
|
|
MESSAGE("Greninja became fully charged due to its bond with its trainer!");
|
|
MESSAGE("Greninja became Ash-Greninja!");
|
|
} else {
|
|
NONE_OF {
|
|
ABILITY_POPUP(player, ABILITY_BATTLE_BOND);
|
|
MESSAGE("Greninja became fully charged due to its bond with its trainer!");
|
|
}
|
|
}
|
|
} FINALLY {
|
|
if (monsCountOpponent != 1) {
|
|
EXPECT(player->species == SPECIES_GRENINJA_ASH);
|
|
} else {
|
|
EXPECT(player->species == SPECIES_GRENINJA_BATTLE_BOND);
|
|
}
|
|
}
|
|
}
|
|
|
|
SINGLE_BATTLE_TEST("Battle Bond transforms opponent's Greninja - Singles")
|
|
{
|
|
u32 monsCountPlayer, monsCountOpponent;
|
|
|
|
PARAMETRIZE {monsCountPlayer = 1; monsCountOpponent = 1; }
|
|
PARAMETRIZE {monsCountPlayer = 1; monsCountOpponent = 2; }
|
|
PARAMETRIZE {monsCountPlayer = 2; monsCountOpponent = 1; }
|
|
PARAMETRIZE {monsCountPlayer = 2; monsCountOpponent = 2; }
|
|
|
|
GIVEN {
|
|
OPPONENT(SPECIES_GRENINJA_BATTLE_BOND);
|
|
if (monsCountOpponent == 2) {
|
|
OPPONENT(SPECIES_WOBBUFFET);
|
|
}
|
|
PLAYER(SPECIES_WOBBUFFET) {HP(1); }
|
|
if (monsCountPlayer == 2) {
|
|
PLAYER(SPECIES_WOBBUFFET);
|
|
}
|
|
} WHEN {
|
|
if (monsCountPlayer == 2) {
|
|
TURN { MOVE(opponent, MOVE_WATER_GUN); SEND_OUT(player, 1); }
|
|
} else {
|
|
TURN { MOVE(opponent, MOVE_WATER_GUN); }
|
|
}
|
|
|
|
} SCENE {
|
|
HP_BAR(player);
|
|
MESSAGE("Wobbuffet fainted!");
|
|
if (monsCountPlayer != 1) {
|
|
ABILITY_POPUP(opponent, ABILITY_BATTLE_BOND);
|
|
MESSAGE("Foe Greninja became fully charged due to its bond with its trainer!");
|
|
MESSAGE("Foe Greninja became Ash-Greninja!");
|
|
} else {
|
|
NONE_OF {
|
|
ABILITY_POPUP(opponent, ABILITY_BATTLE_BOND);
|
|
MESSAGE("Foe Greninja became fully charged due to its bond with its trainer!");
|
|
}
|
|
}
|
|
} FINALLY {
|
|
if (monsCountPlayer != 1) {
|
|
EXPECT(opponent->species == SPECIES_GRENINJA_ASH);
|
|
} else {
|
|
EXPECT(opponent->species == SPECIES_GRENINJA_BATTLE_BOND);
|
|
}
|
|
}
|
|
}
|
|
|
|
DOUBLE_BATTLE_TEST("Battle Bond transforms player's Greninja when fainting its Ally")
|
|
{
|
|
u32 monsCountPlayer, monsCountOpponent;
|
|
|
|
PARAMETRIZE {monsCountPlayer = 2; monsCountOpponent = 2; }
|
|
PARAMETRIZE {monsCountPlayer = 2; monsCountOpponent = 3; }
|
|
PARAMETRIZE {monsCountPlayer = 3; monsCountOpponent = 2; }
|
|
PARAMETRIZE {monsCountPlayer = 3; monsCountOpponent = 3; }
|
|
|
|
GIVEN {
|
|
PLAYER(SPECIES_GRENINJA_BATTLE_BOND);
|
|
PLAYER(SPECIES_WOBBUFFET) { HP(1); }
|
|
if (monsCountPlayer == 3) {
|
|
PLAYER(SPECIES_WOBBUFFET);
|
|
}
|
|
OPPONENT(SPECIES_WOBBUFFET) { HP(1); }
|
|
OPPONENT(SPECIES_WOBBUFFET);
|
|
if (monsCountOpponent == 3) {
|
|
OPPONENT(SPECIES_WOBBUFFET);
|
|
}
|
|
} WHEN {
|
|
if (monsCountPlayer == 3) {
|
|
TURN { MOVE(playerLeft, MOVE_WATER_GUN, target:playerRight); SEND_OUT(playerRight, 2); }
|
|
} else {
|
|
TURN { MOVE(playerLeft, MOVE_WATER_GUN, target:playerRight); }
|
|
}
|
|
|
|
} SCENE {
|
|
HP_BAR(playerRight);
|
|
MESSAGE("Wobbuffet fainted!");
|
|
ABILITY_POPUP(playerLeft, ABILITY_BATTLE_BOND);
|
|
MESSAGE("Greninja became fully charged due to its bond with its trainer!");
|
|
MESSAGE("Greninja became Ash-Greninja!");
|
|
} FINALLY {
|
|
EXPECT(playerLeft->species == SPECIES_GRENINJA_ASH);
|
|
}
|
|
}
|