enum architecture requiring the use of cloning

devraza commented

2025-02-21 00:24:43 +00:00

Owner

Though I'm not exactly sure if it could be done better, the way the architecture has been implemented (#1) means that instead of using more efficient mutable references to update the application state, a new application state (or portions of it) is created every time a modification is required.

So, though the architecture simplifies the codebase, it's also less efficient, which I'd like to avoid if possible.

I've reversed the merge for now, but if this issue can be resolved I'll look into a relevant PR.

Though I'm not exactly sure if it could be done better, the way the architecture has been implemented (#1) means that instead of using more efficient mutable references to update the application state, a new application state (or portions of it) is created every time a modification is required. So, though the architecture simplifies the codebase, it's also less efficient, which I'd like to avoid if possible. I've reversed the merge for now, but if this issue can be resolved I'll look into a relevant PR.