From 7e96be21ae3147667fa648b154d3d4308e78a04a Mon Sep 17 00:00:00 2001
From: Michel Heily <michelheily@gmail.com>
Date: Fri, 2 Jul 2021 12:44:12 +0300
Subject: [PATCH] perf: Move `pc` to the beginning of the CPU struct

Former-commit-id: 1b17095bee5c6010d3792fc220a8abcf3a373207
Former-commit-id: 5e65dad6398ef6e9d907d086c982fd70e85c9184
---
 core/build.rs                   | 11 +++++++++--
 core/src/arm7tdmi/cpu.rs        |  2 +-
 core/src/arm7tdmi/thumb/exec.rs | 13 ++++++-------
 3 files changed, 16 insertions(+), 10 deletions(-)

diff --git a/core/build.rs b/core/build.rs
index 7a260b6..0eaa9e6 100644
--- a/core/build.rs
+++ b/core/build.rs
@@ -30,10 +30,17 @@ fn thumb_decode(i: u16) -> (&'static str, String) {
     } else if i & 0xe000 == 0x2000 {
         (
             "DataProcessImm",
-            String::from("exec_thumb_data_process_imm"),
+            format!(
+                "exec_thumb_data_process_imm::<{OP}, {RD}>",
+                OP = i.bit_range(11..13) as u8,
+                RD = i.bit_range(8..11)
+            ),
         )
     } else if i & 0xfc00 == 0x4000 {
-        ("AluOps", String::from("exec_thumb_alu_ops"))
+        (
+            "AluOps",
+            format!("exec_thumb_alu_ops::<{OP}>", OP = i.bit_range(6..10) as u16),
+        )
     } else if i & 0xfc00 == 0x4400 {
         (
             "HiRegOpOrBranchExchange",
diff --git a/core/src/arm7tdmi/cpu.rs b/core/src/arm7tdmi/cpu.rs
index 5126412..76b1b07 100644
--- a/core/src/arm7tdmi/cpu.rs
+++ b/core/src/arm7tdmi/cpu.rs
@@ -113,11 +113,11 @@ impl Default for DebuggerState {
 
 #[derive(Clone, Debug)]
 pub struct Core<I: MemoryInterface> {
+    pub pc: u32,
     pub(super) bus: Shared<I>,
 
     next_fetch_access: MemoryAccess,
     pipeline: [u32; 2],
-    pub pc: u32,
     pub gpr: [u32; 15],
 
     pub cpsr: RegPSR,
diff --git a/core/src/arm7tdmi/thumb/exec.rs b/core/src/arm7tdmi/thumb/exec.rs
index 422f1f1..04f741b 100644
--- a/core/src/arm7tdmi/thumb/exec.rs
+++ b/core/src/arm7tdmi/thumb/exec.rs
@@ -62,11 +62,10 @@ impl<I: MemoryInterface> Core<I> {
 
     /// Format 3
     /// Execution Time: 1S
-    pub(in super::super) fn exec_thumb_data_process_imm(&mut self, insn: u16) -> CpuAction {
+    pub(in super::super) fn exec_thumb_data_process_imm<const OP: u8, const RD: usize>(&mut self, insn: u16) -> CpuAction {
         use OpFormat3::*;
-        let op = insn.format3_op();
-        let rd = insn.bit_range(8..11) as usize;
-        let op1 = self.gpr[rd];
+        let op = OpFormat3::from_u8(OP).unwrap();
+        let op1 = self.gpr[RD];
         let op2_imm = (insn & 0xff) as u32;
         let mut carry = self.cpsr.C();
         let mut overflow = self.cpsr.V();
@@ -78,7 +77,7 @@ impl<I: MemoryInterface> Core<I> {
         let arithmetic = op == ADD || op == SUB;
         self.alu_update_flags(result, arithmetic, carry, overflow);
         if op != CMP {
-            self.gpr[rd] = result as u32;
+            self.gpr[RD] = result as u32;
         }
 
         CpuAction::AdvancePC(Seq)
@@ -89,7 +88,7 @@ impl<I: MemoryInterface> Core<I> {
     ///     1S      for  AND,EOR,ADC,SBC,TST,NEG,CMP,CMN,ORR,BIC,MVN
     ///     1S+1I   for  LSL,LSR,ASR,ROR
     ///     1S+mI   for  MUL on ARMv4 (m=1..4; depending on MSBs of incoming Rd value)
-    pub(in super::super) fn exec_thumb_alu_ops(&mut self, insn: u16) -> CpuAction {
+    pub(in super::super) fn exec_thumb_alu_ops<const OP: u16>(&mut self, insn: u16) -> CpuAction {
         let rd = (insn & 0b111) as usize;
         let rs = insn.rs();
         let dst = self.get_reg(rd);
@@ -99,7 +98,7 @@ impl<I: MemoryInterface> Core<I> {
         let mut overflow = self.cpsr.V();
 
         use ThumbAluOps::*;
-        let op = insn.format4_alu_op();
+        let op = ThumbAluOps::from_u16(OP).unwrap();
 
         macro_rules! shifter_op {
             ($bs_op:expr) => {{