devraza/rustboyadvance-ng
Archived
1
Fork 0
Code Issues Pull requests Packages Projects Releases 1 Wiki Activity

core: cartridge: Don't error when the checksum is invalid.

Browse source 
A lot of test ROMs i'm using don't bother to calculate the checksum :\


Former-commit-id: da02a70271c34bc26e560ea18b3f5052ee171a65
Former-commit-id: 332d917e47b268ae649574844d14cab2da65197d
This commit is contained in:
Michel Heily 2020-10-17 06:43:13 -07:00
parent a3546cbe07
commit e14c5996d4
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
core/src/cartridge/header.rs
View file

@ -56,10 +56,12 @@ pub fn parse(bytes: &[u8]) -> GBAResult<CartridgeHeader> {
}
let checksum = bytes[0xbd];
if calculate_checksum(&bytes[0xa0..=0xbc]) != checksum {
return Err(GBAError::CartridgeLoadError(
"invalid header checksum".to_string(),
));
let calculated_checksum = calculate_checksum(&bytes[0xa0..=0xbc]);
if calculated_checksum != checksum {
warn!(
"invalid header checksum, calculated {:02x} but expected {:02x}",
calculated_checksum, checksum
);
}
let game_title = from_utf8(&bytes[0xa0..0xac])