atiran/porymap
3
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Early exit magic fill if it would be a no-op

Browse source
This commit is contained in:
Marcus Huderle 2020-06-27 17:14:37 -05:00
parent 370221a974
commit 7392105297
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/ui/mappixmapitem.cpp
View file

@ -322,6 +322,11 @@ void MapPixmapItem::magicFill(
bool fromScriptCall) { bool fromScriptCall) {
Block *block = map->getBlock(initialX, initialY); Block *block = map->getBlock(initialX, initialY);
if (block) { if (block) {
if (selectedMetatiles->length() == 1 && selectedMetatiles->value(0) == block->tile) {
logInfo("early exit");
return;
}
bool setCollisions = selectedCollisions && selectedCollisions->length() == selectedMetatiles->length(); bool setCollisions = selectedCollisions && selectedCollisions->length() == selectedMetatiles->length();
uint16_t tile = block->tile; uint16_t tile = block->tile;
for (int y = 0; y < map->getHeight(); y++) { for (int y = 0; y < map->getHeight(); y++) {