atiran/sovereignx
3
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Note overflow in ModifyStatByNature

Browse source
This commit is contained in:
GriffinR 2019-10-04 00:58:47 -04:00 committed by huderlem
parent 48e54ae387
commit a6847ca1d9
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/pokemon.c
View file

@ -5724,9 +5724,9 @@ u16 ModifyStatByNature(u8 nature, u16 n, u8 statIndex)
switch (gNatureStatTable[nature][statIndex - 1])
{
case 1:
return (u16)(n * 110) / 100;
return (u16)(n * 110) / 100; // NOTE: will overflow for n > 595 because the intermediate value is cast to u16 before the division. Fix by removing (u16) cast
case -1:
return (u16)(n * 90) / 100;
return (u16)(n * 90) / 100; // NOTE: will overflow for n > 728, see above
}
return n;