Nephrite
be2e3cf056
Updated primary/secondary macros
...
Makes things just a little easier to keep track of where move effects are being set and run
2023-12-30 19:41:03 +09:00
kittenchilly
66a638f7b4
Change Ivy Cudgel to be based on Ogerpon form rather than held item ( #3865 )
...
* Change Ivy Cudgel to be based on Ogerpon form rather than held item
* Update ivy_cudgel.c
* Address reviews
* Update test/battle/move_effect/ivy_cudgel.c
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-12-30 11:40:58 +01:00
Martin Griffin
ed850d3f6c
VSync BENCHMARKs and avoid AdvanceRandom in tests ( #3866 )
2023-12-30 11:10:40 +01:00
Martin Griffin
515aa367bf
VSync BENCHMARKs and avoid AdvanceRandom in tests ( #3867 )
2023-12-30 11:10:21 +01:00
Nephrite
b6da1a1e1d
Tweaked helper functions
2023-12-30 17:42:53 +09:00
Nephrite
f5ae8e0686
Rapid Spin uses additional effects + test
2023-12-30 17:02:59 +09:00
Nephrite
e7de08eca2
Unified Sonic Boom & Dragon Rage
...
Not really in scope, but what the hell
2023-12-30 15:40:50 +09:00
Martin Griffin
ab900e38df
Merge remote-tracking branch 'rhh/master' into upcoming
2023-12-29 19:48:21 +00:00
Bassoonian
245026353d
Remove leftover TID placeholder move defines ( #3864 )
2023-12-29 18:59:14 +00:00
kittenchilly
ecba468a96
Fix item effect for SV evolution items ( #3858 )
...
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-12-29 15:03:42 +01:00
Bassoonian
1662dc3478
Merge branch 'upcoming' into berryexpansion
2023-12-29 14:32:10 +01:00
Bassoonian
6bc0bf9f8b
Ability refactor ( #3861 )
...
* Ability refactor
* Adds abilities to RHH rom header
---------
Co-authored-by: Martin Griffin <martinrgriffin@gmail.com>
2023-12-29 14:25:24 +01:00
Ninjdai
16a3954f0e
Add MOVES_COUNT and NUM_SPECIES to RHH rom header ( #3831 )
...
* Add MOVES_COUNT and NUM_SPECIES to RHH rom header
2023-12-29 13:12:17 +00:00
DizzyEggg
604b823ffd
Missing Strength sap tests ( #3860 )
...
* add missing strength sap tests
* a
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-12-29 13:39:54 +01:00
Nephrite
9d68f4ab6f
Added Throat Chop test
...
I don't know why it used to work through subs but now it won't
2023-12-29 20:17:57 +09:00
Nephrite
39773c0659
Burn Up and Double Shock
...
Both working by applying an additional effect; added a generic "jumpifnotcurrentmoveargtype" type command to make it possible, relpacing secret power's function
2023-12-29 12:44:38 +09:00
Nephrite
7c38056da7
Review fixes
...
Added more move effect considerations to AI; redid way it calculates secondaryEffectChance; misc fixes
2023-12-29 12:04:42 +09:00
Bassoonian
bc4d4d21e4
Fix 3851 ( #3857 )
2023-12-29 00:33:18 +01:00
Eduardo Quezada D'Ottone
0a40cd15d1
Non-tagged release
2023-12-28 19:54:06 -03:00
Bassoonian
d3f971f0e8
Version 1.7.1 ( #3855 )
2023-12-28 19:50:21 -03:00
kittenchilly
94a650a203
Add Fillet Away + Belly Drum tweaks ( #3616 )
...
* Add Fillet Away
* Fillet Away and Belly Drum tests
* More tests
* Update fillet_away.c
* Update fillet_away.c
* Newlines
* Update battle_scripts_1.s
* Update belly_drum.c
* Address reviews
* Fix order
* Swords Dance assume
* Update belly_drum.c
* Try some stuff
* Fix hp not being halved in certain cases
* Update battle_scripts_1.s
* AI stuff
2023-12-28 23:27:09 +01:00
kittenchilly
1e958ada8c
Add Indigo Disk item data ( #3854 )
2023-12-28 23:00:34 +01:00
Nephrite
417a02c95e
Fixed Make it Rain
...
To do: misc fixes here and there, maybe do Burn Up/Double Shock, Dragon Rage/SonicBoom...
2023-12-29 01:40:43 +09:00
Bassoonian
fde3fc0a52
Metronome move fix ( #3852 )
...
* Draft Indigo Disk move data
* Add basic defines (flags, targets and priority missing)
* Update move flags
* Temper Flare is Stomping Tantrum
* Fix failing tests
* Disable Burning Bulwark for now
2023-12-28 16:57:29 +01:00
Bassoonian
bc3737772a
Define new abilities ( #3838 )
...
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2023-12-28 12:33:29 +01:00
Bassoonian
872ddf32c6
The Indigo Disk Moves ( #3704 )
...
* Draft Indigo Disk move data
* Add basic defines (flags, targets and priority missing)
* Update move flags
* Temper Flare is Stomping Tantrum
* Forgot to push, please squash :D
* Fix failing tests
2023-12-28 12:21:52 +01:00
kittenchilly
28f17772ec
Implement Pokemon Box Link functionality ( #3837 )
...
* Implement Pokemon Box Link functionality
* Update item_use.c
* Update item_use.c
* Can only use box link if the map allows escape
* Revert "Can only use box link if the map allows escape"
This reverts commit be5b46b6c4
.
* Overworld_IsEscapingAllowed
---------
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2023-12-28 11:47:00 +01:00
tertu
c57b1548a0
Replace at least some shuffle algorithms with Shuffle ( #3801 )
...
Most of these are the poor-quality and slow "naive shuffle", but some might be better.
In any case, Shuffle is known good.
2023-12-28 09:58:35 +00:00
kittenchilly
4f61d44dfe
Add Treasure Factor to Nugget and Tiny Mushroom ( #3836 )
2023-12-28 00:02:51 +01:00
GriffinR
6c96641035
Merge pull request #1969 from Kurausukun/macros
...
Safeguard SQUARE and CUBE Macro Arguments in Parentheses
2023-12-27 17:39:37 -05:00
Kurausukun
7567b0a57a
safeguard SQUARE and CUBE macro arguments in parentheses
2023-12-27 17:29:35 -05:00
Bassoonian
88b0bd6394
Add gen9 item prices + configs ( #3834 )
...
* Add gen9 item prices + configs
* Adjust gen 1 PP item costs
---------
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2023-12-27 22:48:56 +01:00
DizzyEggg
3e321d1172
fix ally switch dig issue ( #3835 )
2023-12-27 15:35:42 -05:00
Frank DeBlasio
f5e0b3df23
Changed SHINY_ODDS to FALSE in pokedex_plus_hgss.c ( #3832 )
2023-12-27 20:28:44 +01:00
Martin Griffin
3ad66028e9
Backwards-compatible BoxPokémon Refactor ( #3438 )
...
* Check progress in non-battle PARAMETRIZEd tests
* Overworld Script Tests
* Backward-compatible BoxPokemon Refactor
Reuses space that contains zeros to provide space for:
- HP/status in the box
- 12-character nicknames
- Up to 63 PokéBalls
- Shininess separate from PID
- Hidden Nature
- Hyper Training
- Dynamax Level
- Gigantamax Factor
- Terastallization Types
- Shadow
Implements:
- OW_PC_HEAL to switch between Gen7- and Gen8+ behavior
- Nature Mints
- Dynamax Candy
- Hyper Training commands (canhypertrain/hypertrain)
- Gigantamax Factor commands (hasgigantamaxfactor/togglegigantamaxfactor)
- Terastallization Type on the summary screen
- Prevents Gigantamax Factor Pokémon from evolving into a species without a Gigantamax form
* fixup! Backward-compatible BoxPokemon Refactor
* displaydexinfo fix from Jasper
2023-12-27 17:48:17 +01:00
Bassoonian
a4b819ac41
Merge branch 'upcoming' into berryexpansion
2023-12-27 14:00:12 +01:00
ghoulslash
a9d6832908
Separate AI flags by battler position ( #3003 )
...
* ai flags by battlerId
* fix recoded battle saved ai flags
* update aiFlags check in OpponentHandleChoosePokemon
* add header for TRAINER_CUSTOM_PARTNER define
* initialize flags in BattleAI_SetupAIData
* fix usage of TRAINER_CUSTOM_PARTNER
* remove whitespace
---------
Co-authored-by: ghoulslash <pokevoyager0@gmail.com>
2023-12-27 13:54:37 +01:00
Bassoonian
41ff985bb6
PCG fix ( #3830 )
2023-12-27 12:15:16 +01:00
Nephrite
77c722ea09
Obsoleted 22 more effects
...
Also added a better way of calculating battle_tv score properly; to do: Make it Rain
2023-12-27 17:43:20 +09:00
sbird
7f3264c151
[dynamic multichoice] fix -Wall warnings / errors
2023-12-26 14:29:11 +01:00
sbird
c27ea10eb1
Merge branch 'feature/dynmulti' into feature/dynmulti-expansion
2023-12-26 14:22:49 +01:00
Gabriel Cowley
3bae98f768
Fix P_FAMILY if blocks for Regigigas and Giratina ( #3823 )
2023-12-26 10:16:16 +01:00
Nephrite
cd5c59ae5a
Merge remote-tracking branch 'rhh/upcoming' into secondary_effects_overhaul
2023-12-26 13:19:10 +09:00
Nephrite
c5061f0161
Updated remaining moves which use secondaryEffectChance
...
secondaryEffectChance is no longer considered anywhere in the code; tidied up scripts and more
2023-12-26 13:12:11 +09:00
Nephrite
76b4e08e5e
Trapping moves, Secret Power, rampage moves
...
Also tidied up a lot of #ifs and commas in battle_moves.h
2023-12-26 10:46:11 +09:00
Alex
45da55eb14
Fixes Minior form change and likely other forms ( #3822 )
...
* Fixes Minior form change and likely other forms
* new fix
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-12-25 20:18:52 +01:00
Alex
166a1a4e63
Adds ability Embody Aspect + minor fix to Hospitality ( #3821 )
...
* Adds ability Embody Aspect + minor fix to Hospitality
* comment out failing tests related to neutralizing gas
* fixes neutralizing gas bug
* leftover
2023-12-25 18:28:16 +01:00
Nephrite
b0b9883625
Removed unused effects + fixed tests + removed secondaryEffectChance
...
To do: remaining moves that make use of `secondaryEffectChance` field
2023-12-25 12:53:15 +09:00
Nephrite
f3e67cf543
Removed all unused effects
...
Some util updates
2023-12-25 12:32:13 +09:00
Nephrite
cda445c2f5
Merge remote-tracking branch 'rhh/upcoming' into secondary_effects_overhaul_rebase
2023-12-25 12:19:38 +09:00