Eduardo Quezada D'Ottone
e5b58b04b6
Renamed healBlockBanned to healingMove ( #3981 )
...
* Renamed healBlockBanned to healingMove
* Fix fix
2024-01-12 18:41:45 +01:00
Biffalo XIII
a89f1eeb50
Revert "healBlockBanned -> healingMove ( #3976 )"
...
This reverts commit a947b20f31
.
2024-01-12 12:10:59 -03:00
Nephrite
1ced2bf324
Converted EFFECT_x defines to enum ( #3975 )
...
follow up PR
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
2024-01-12 07:30:58 -03:00
kittenchilly
a947b20f31
healBlockBanned -> healingMove ( #3976 )
2024-01-12 01:05:26 +01:00
Biffalo XIII
2cc26d935a
Merge branch '_RHH/master' into _RHH/upcoming
...
# Conflicts:
# data/battle_scripts_1.s
# include/config/pokemon.h
# src/birch_pc.c
2024-01-11 19:51:11 -03:00
Nephrite
f6efc75c1a
Move functions to battle_ai_util.c
2024-01-12 04:01:33 +09:00
Nephrite
baefa08bee
Merge remote-tracking branch 'rhh/upcoming' into secondary_effects_overhaul
2024-01-12 03:13:42 +09:00
Nephrite
a76e3c70ba
Applied more review fixes
2024-01-12 03:02:48 +09:00
Nephrite
3c93f97166
Apply suggestions from code review
...
Thanks, Edu
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
2024-01-12 02:13:55 +09:00
Bassoonian
a8a504ef25
Refactor dex completion (again) ( #3937 )
...
* Refactor dex completion
* Incorporate Alex's requests
* rename to dexForceRequired
* Revert GetPokedexRatingText argument type
* Apply suggestions from code review
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
* Revert "Revert GetPokedexRatingText argument type"
This reverts commit a9b0c28040
.
* Fix HasAllMons
* Fix oops
---------
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
2024-01-11 13:35:31 -03:00
Bassoonian
ce48616477
Add power item config ( #3961 )
2024-01-11 09:34:19 +01:00
Nephrite
c4616739d8
Merge remote-tracking branch 'rhh/upcoming' into secondary_effects_overhaul
2024-01-11 00:35:35 +09:00
Nephrite
67e76f2b59
Some more review fixes + Fling fix
...
Not the ideal solution but Fling now has a hardcoded check for Shield Dust and acts accordingly - a better long term solution inolves making a bunch of reusable MOVE_EFFECTS and rejigging attackcanceler but I didn't feel like doing that today...
2024-01-11 00:27:06 +09:00
Alex
4dc1b1dda3
Revert "Update catch curve for pokeballs ( #3685 )" ( #3955 )
...
This reverts commit 929ec54a39
.
2024-01-09 21:20:51 -03:00
Alex
c56acb944b
New Feature: Level Caps ( #3632 )
...
* New Feature: Level Caps
* B_LEVEL_CAP_EXP_UP and fixes
* 1 exp fix for hard level caps
* remove 1 exp hack
* Reviews applied
* fix u8/u16
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2024-01-09 18:47:23 +01:00
Alex
5498098438
Syrup Bomb / Sticky Syrup addition ( #3948 )
...
* Syrup Bomb / Sticky Syrup addition
* Update test/battle/move_effect/syrup_bomb.c
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
* Update src/battle_script_commands.c
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
---------
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2024-01-09 13:37:07 +01:00
Biffalo XIII
4a3954ff34
Merge branch '_RHH/master' into _RHH/upcoming
...
# Conflicts:
# src/birch_pc.c
# src/main.c
2024-01-09 09:19:12 -03:00
Ariel A
85aab338a9
Merge branch 'guillotine' into guillotine-expansion
2024-01-08 19:43:06 -05:00
Bassoonian
d73c9b0b9d
Fix some ball multiplier configs ( #3939 )
...
* Fix some ball multiplier configs
* Updated the comment of B_LURE_BALL_MODIFIER
* Specified the effects of B_LURE_BALL_MODIFIER in itsa state its effects in a more specific manner
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
* Corrected the comments of B_DREAM_BALL_MODIFIER, B_SPORT_BALL_MODIFIER and B_SAFARI_BALL_MODIFIER
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
* Turned the ternaries in the case for the Lure Ball's catch rate in Cmd_handleballthrow into a regular if/else if statement
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
---------
Co-authored-by: LOuroboros <lunosouroboros@gmail.com>
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
2024-01-08 18:26:05 -03:00
Ariel A
1ce961768e
Added automatic runtime decapitalization.
2024-01-07 20:21:14 -05:00
Bassoonian
7b0904c580
Fix extended berry stage palettes
2024-01-05 11:32:59 +01:00
Bassoonian
f9c21afb75
Dynamic regional dex rating ( #3900 )
2024-01-05 09:47:28 +01:00
Bassoonian
418e551960
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into berryexpansion
2024-01-05 00:32:21 +01:00
BiffaloXIII
8b80a54a7a
Removed footprint field when P_FOOTPRINTS is FALSE ( #3925 )
2024-01-04 21:54:03 +01:00
Bassoonian
1ee568ac6b
Remove leftover code for myself
2024-01-04 16:12:39 +00:00
Bassoonian
b948accc80
Remove redundant table
2024-01-04 16:07:12 +00:00
Bassoonian
b56a9e6286
Remove unused function
2024-01-04 16:04:00 +00:00
Frank DeBlasio
4d5c572d0c
Refactor trainer classes ( #3875 )
...
* Created TrainerClass struct
* Added money multiplier to TrainerClass struct
* Added Poke Balls to struct
* Condensed gTrainerClasses
* Simplified trainer Poke Balls
* Moved trainer classes into battle_main.c
* Removed complicated ball macro
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2024-01-04 13:30:42 +01:00
Bassoonian
f94e65a400
Footprint config ( #3902 )
...
* Footprint config
* Don't enable by default
2024-01-03 21:24:45 +01:00
Alex
34f51da5f8
Merge branch 'upcoming' into feature/dynmulti-expansion
2024-01-03 15:54:39 +01:00
ghoulslash
91dfa93d3b
fix genie storm move anims for both targets, add AnimEllipticalGustCentered, AnimParticleInVortex handles multiple targets, add dynamic pals based on move target in UnpackSelectedBattlePalettes ( #3895 )
...
Co-authored-by: ghoulslash <pokevoyager0@gmail.com>
2024-01-02 23:46:07 +01:00
aronson
3c21e23555
Allocate initialized sections for EWRAM and IWRAM ( #3892 )
2024-01-02 14:24:52 +00:00
Martin Griffin
d1ab525552
Revert "Allocate initialized sections for EWRAM and IWRAM ( #3877 )" ( #3891 )
...
This reverts commit f24deb9301
.
2024-01-02 13:54:42 +00:00
aronson
f24deb9301
Allocate initialized sections for EWRAM and IWRAM ( #3877 )
2024-01-02 13:46:01 +00:00
Nephrite
59d76c9321
A few fixes, added effects for Meteor Beam/Electro Shot
2024-01-02 20:27:50 +09:00
Nephrite
4556ecc71e
Removed PRIMARY/SECONDARY macros; added flags
...
Just a couple for now; cleaned up parts of setadditionaleffects
2024-01-02 20:06:49 +09:00
Nephrite
ab75ad6d02
Ability flags update ( #3886 )
...
* Added five ability flags
Omitted duplicate flags that are basically "can't copy" (Role Play, Receiver, Entrainment, Skill Swap), didn't bother adding Neutralizing Gas flag,
* Mold Breaker and Trace
* Gastro Acid, Simple Beam, Worry Seed
Decided to keep the Simple Beam/Worry Seed functions
* Entrainment done
* Skill Swap
* Doodle/Role Play + flag descriptions
Also adjusted Doodle test
* Wandering Spirit, Mummy, Neutralizing Gas
Neutralizing Gas really only needs to check for other mons with Neutralizing Gas, otherwise unsuppressable abilities are handled separately.
* Renamed flags
2024-01-01 15:03:34 +01:00
Nephrite
0980253cce
Merge branch 'upcoming' into secondary_effects_overhaul
2024-01-01 20:40:11 +09:00
kittenchilly
f6f287d637
Add Indigo Disk Pokemon data ( #3878 )
...
* Archaludon?
* more archuladon stuff
* Hydrapple and Gouging Fire
* Raging Bolt
* Iron Boulder and Iron Crown
* Terapagos
* Pecharunt
* Update gen_9.h
* Pokedex orders
2024-01-01 01:38:50 +01:00
Nephrite
923d22b42b
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into secondary_effects_overhaul_merge
2024-01-01 03:50:36 +09:00
Alex
15fa85ca2f
Merge branch 'upcoming' into feature/dynmulti-expansion
2023-12-31 00:16:44 +01:00
Bassoonian
a32e2ccc88
Move Ability AI scores to gAbilities ( #3862 )
...
* Ability refactor
* Adds abilities to RHH rom header
* Move Ability Ratings to gAbilities
* Add previously unknown ai ratings
---------
Co-authored-by: Martin Griffin <martinrgriffin@gmail.com>
Co-authored-by: DizzyEggg <jajkodizzy@wp.pl>
2023-12-30 23:07:18 +01:00
DizzyEggg
726c6f48e3
Fix weird stat drop anim ( #3870 )
...
* Fix weird stat drop anim
* PACKED define
2023-12-30 22:53:46 +01:00
DizzyEggg
b83b1f7e88
Merge branch 'upcoming' into feature/dynmulti-expansion
2023-12-30 22:41:59 +01:00
Bassoonian
9e051aa058
Merge branch 'master' of https://github.com/pret/pokeemerald into pretmergenewyears
2023-12-30 20:49:05 +01:00
Alex
cc32e378d6
Adds some Indigo Disk moves ( #3853 )
...
* Burning Bulwark
* Fickle Beam
* Alluring Voice
* Electro Shot
* forgot sheer force flag for alluring voice
* review changes
* additional alluring voice test
* Simple Allruing Voice animation
* Update battle.h
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-12-30 20:20:12 +01:00
Nephrite
9dfa0d264f
Merge branch 'upcoming' into secondary_effects_overhaul
2023-12-30 23:54:01 +09:00
Nephrite
60a0020833
Tweaked macro to be more appealing
2023-12-30 20:41:29 +09:00
Nephrite
ff51eb2b6c
Removed unused move effects, various ids, and one script command
2023-12-30 20:35:48 +09:00
Nephrite
e34373effc
Renamed seteffectwithchance to setadditionaleffects
...
Function no longer has ability to apply effects from moveEffect - for that, seteffectprimary or secondary is now recommended. Removed EFFECT_RAMPAGE, updated a few tests
2023-12-30 20:29:09 +09:00
kittenchilly
66a638f7b4
Change Ivy Cudgel to be based on Ogerpon form rather than held item ( #3865 )
...
* Change Ivy Cudgel to be based on Ogerpon form rather than held item
* Update ivy_cudgel.c
* Address reviews
* Update test/battle/move_effect/ivy_cudgel.c
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-12-30 11:40:58 +01:00
Martin Griffin
ed850d3f6c
VSync BENCHMARKs and avoid AdvanceRandom in tests ( #3866 )
2023-12-30 11:10:40 +01:00
Martin Griffin
515aa367bf
VSync BENCHMARKs and avoid AdvanceRandom in tests ( #3867 )
2023-12-30 11:10:21 +01:00
Nephrite
b6da1a1e1d
Tweaked helper functions
2023-12-30 17:42:53 +09:00
Nephrite
f5ae8e0686
Rapid Spin uses additional effects + test
2023-12-30 17:02:59 +09:00
Nephrite
e7de08eca2
Unified Sonic Boom & Dragon Rage
...
Not really in scope, but what the hell
2023-12-30 15:40:50 +09:00
Martin Griffin
ab900e38df
Merge remote-tracking branch 'rhh/master' into upcoming
2023-12-29 19:48:21 +00:00
Bassoonian
1662dc3478
Merge branch 'upcoming' into berryexpansion
2023-12-29 14:32:10 +01:00
Bassoonian
6bc0bf9f8b
Ability refactor ( #3861 )
...
* Ability refactor
* Adds abilities to RHH rom header
---------
Co-authored-by: Martin Griffin <martinrgriffin@gmail.com>
2023-12-29 14:25:24 +01:00
Nephrite
39773c0659
Burn Up and Double Shock
...
Both working by applying an additional effect; added a generic "jumpifnotcurrentmoveargtype" type command to make it possible, relpacing secret power's function
2023-12-29 12:44:38 +09:00
Nephrite
7c38056da7
Review fixes
...
Added more move effect considerations to AI; redid way it calculates secondaryEffectChance; misc fixes
2023-12-29 12:04:42 +09:00
Bassoonian
bc4d4d21e4
Fix 3851 ( #3857 )
2023-12-29 00:33:18 +01:00
Eduardo Quezada D'Ottone
0a40cd15d1
Non-tagged release
2023-12-28 19:54:06 -03:00
Bassoonian
d3f971f0e8
Version 1.7.1 ( #3855 )
2023-12-28 19:50:21 -03:00
kittenchilly
94a650a203
Add Fillet Away + Belly Drum tweaks ( #3616 )
...
* Add Fillet Away
* Fillet Away and Belly Drum tests
* More tests
* Update fillet_away.c
* Update fillet_away.c
* Newlines
* Update battle_scripts_1.s
* Update belly_drum.c
* Address reviews
* Fix order
* Swords Dance assume
* Update belly_drum.c
* Try some stuff
* Fix hp not being halved in certain cases
* Update battle_scripts_1.s
* AI stuff
2023-12-28 23:27:09 +01:00
kittenchilly
1e958ada8c
Add Indigo Disk item data ( #3854 )
2023-12-28 23:00:34 +01:00
Nephrite
417a02c95e
Fixed Make it Rain
...
To do: misc fixes here and there, maybe do Burn Up/Double Shock, Dragon Rage/SonicBoom...
2023-12-29 01:40:43 +09:00
Bassoonian
fde3fc0a52
Metronome move fix ( #3852 )
...
* Draft Indigo Disk move data
* Add basic defines (flags, targets and priority missing)
* Update move flags
* Temper Flare is Stomping Tantrum
* Fix failing tests
* Disable Burning Bulwark for now
2023-12-28 16:57:29 +01:00
Bassoonian
bc3737772a
Define new abilities ( #3838 )
...
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2023-12-28 12:33:29 +01:00
Bassoonian
872ddf32c6
The Indigo Disk Moves ( #3704 )
...
* Draft Indigo Disk move data
* Add basic defines (flags, targets and priority missing)
* Update move flags
* Temper Flare is Stomping Tantrum
* Forgot to push, please squash :D
* Fix failing tests
2023-12-28 12:21:52 +01:00
kittenchilly
28f17772ec
Implement Pokemon Box Link functionality ( #3837 )
...
* Implement Pokemon Box Link functionality
* Update item_use.c
* Update item_use.c
* Can only use box link if the map allows escape
* Revert "Can only use box link if the map allows escape"
This reverts commit be5b46b6c4
.
* Overworld_IsEscapingAllowed
---------
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2023-12-28 11:47:00 +01:00
Bassoonian
88b0bd6394
Add gen9 item prices + configs ( #3834 )
...
* Add gen9 item prices + configs
* Adjust gen 1 PP item costs
---------
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2023-12-27 22:48:56 +01:00
Martin Griffin
3ad66028e9
Backwards-compatible BoxPokémon Refactor ( #3438 )
...
* Check progress in non-battle PARAMETRIZEd tests
* Overworld Script Tests
* Backward-compatible BoxPokemon Refactor
Reuses space that contains zeros to provide space for:
- HP/status in the box
- 12-character nicknames
- Up to 63 PokéBalls
- Shininess separate from PID
- Hidden Nature
- Hyper Training
- Dynamax Level
- Gigantamax Factor
- Terastallization Types
- Shadow
Implements:
- OW_PC_HEAL to switch between Gen7- and Gen8+ behavior
- Nature Mints
- Dynamax Candy
- Hyper Training commands (canhypertrain/hypertrain)
- Gigantamax Factor commands (hasgigantamaxfactor/togglegigantamaxfactor)
- Terastallization Type on the summary screen
- Prevents Gigantamax Factor Pokémon from evolving into a species without a Gigantamax form
* fixup! Backward-compatible BoxPokemon Refactor
* displaydexinfo fix from Jasper
2023-12-27 17:48:17 +01:00
Bassoonian
a4b819ac41
Merge branch 'upcoming' into berryexpansion
2023-12-27 14:00:12 +01:00
ghoulslash
a9d6832908
Separate AI flags by battler position ( #3003 )
...
* ai flags by battlerId
* fix recoded battle saved ai flags
* update aiFlags check in OpponentHandleChoosePokemon
* add header for TRAINER_CUSTOM_PARTNER define
* initialize flags in BattleAI_SetupAIData
* fix usage of TRAINER_CUSTOM_PARTNER
* remove whitespace
---------
Co-authored-by: ghoulslash <pokevoyager0@gmail.com>
2023-12-27 13:54:37 +01:00
Nephrite
77c722ea09
Obsoleted 22 more effects
...
Also added a better way of calculating battle_tv score properly; to do: Make it Rain
2023-12-27 17:43:20 +09:00
sbird
c27ea10eb1
Merge branch 'feature/dynmulti' into feature/dynmulti-expansion
2023-12-26 14:22:49 +01:00
Nephrite
cd5c59ae5a
Merge remote-tracking branch 'rhh/upcoming' into secondary_effects_overhaul
2023-12-26 13:19:10 +09:00
Nephrite
c5061f0161
Updated remaining moves which use secondaryEffectChance
...
secondaryEffectChance is no longer considered anywhere in the code; tidied up scripts and more
2023-12-26 13:12:11 +09:00
Nephrite
76b4e08e5e
Trapping moves, Secret Power, rampage moves
...
Also tidied up a lot of #ifs and commas in battle_moves.h
2023-12-26 10:46:11 +09:00
Nephrite
b0b9883625
Removed unused effects + fixed tests + removed secondaryEffectChance
...
To do: remaining moves that make use of `secondaryEffectChance` field
2023-12-25 12:53:15 +09:00
Nephrite
f3e67cf543
Removed all unused effects
...
Some util updates
2023-12-25 12:32:13 +09:00
Nephrite
cda445c2f5
Merge remote-tracking branch 'rhh/upcoming' into secondary_effects_overhaul_rebase
2023-12-25 12:19:38 +09:00
Alex
1339256d5d
Adds Ability Hospitality ( #3818 )
...
* Adds Ability Hospitality
* fix agbcc
2023-12-25 01:43:57 +01:00
Bassoonian
c47a20a446
Fix gem boost description + test ( #3817 )
2023-12-25 01:14:01 +01:00
Bassoonian
77f0ab88d4
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into berryexpansion
2023-12-24 23:17:58 +01:00
Bassoonian
c115649349
Fix 6 stage Berry trees not growing properly
2023-12-24 23:08:15 +01:00
LOuroboros
58b03cb3bd
Implemented a CannotUseItemsInBattle function ( #3524 )
...
* Implemented a CannotUseItemsInBattle function
This fucntion is the result of merging CannotUseBagBattleItem and CannotUsePartyBattleItem. No reason to split the work between 2 functions when you can do it all with just 1.
Misc. Changes:
-Turned most of the if statements inside the function into "else if" statements for performance reasons.
-Refactored how the local variable "cannotUse" was used turning it into a bool.
* Made CannotUseItemsInBattle use a switch statement
Misc. Changes:
-Removed pointless parentheses from case EFFECT_ITEM_SET_FOCUS_ENERGY
-Removed pointless i loop variable from case EFFECT_ITEM_INCREASE_ALL_STATS and replaced a hardcoded 1 in its for loop.
-Turned the i loop variable declared at the top of the function into a u32 variable
-Removed pointless comments. The EFFECT_ITEM constants are readable enough to convey what sort of items they affect.
---------
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2023-12-24 22:10:01 +01:00
Nephrite
e87fe533c3
Superpower, CC, Hammer Arm
2023-12-24 23:43:12 +09:00
Nephrite
a8967da1c5
Overheat (and clones)
...
Also, Syrup Bomb (really weird script)
2023-12-24 23:27:21 +09:00
Nephrite
a244d7b8b6
Updated moves that raise the target's own stats
...
To do: moves like CC, Overheat that LOWER stats; did NOT remove the effect for raising all stats due to an AI function
2023-12-24 22:55:53 +09:00
Zimmermann Gyula
f700466e8d
Implement optional Gen1 type immunity logic. ( #3627 )
...
* Implement optional Gen1 type immunity logic.
* Add tests against Gen1 burn, freeze and paralysis.
* !fixup Expand tests with Gen1 paths.
* Fixup tests.
Remove superflous defines.
Explicitly ASSUME used move type and effect.
* Fix flipped definitions on Freezing Glare test.
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-12-23 16:34:24 +01:00
Alex
61e6365470
Fixes Photon Geyeser category + minor AI calc fixes ( #3807 )
2023-12-23 12:31:40 +01:00
Bassoonian
db0a9484ae
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into berryexpansion
2023-12-23 00:39:10 +01:00
DizzyEggg
1a7166c2bb
Tests do not allow to use SEND_OUT if the chosen mon is fainted ( #3752 )
...
* Tests dont allow to send out pokemon with 0 hp
* remove test test
* handle in-game 0 hp sent out
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-12-23 00:27:40 +01:00
tertu
fb28ce50ae
Optional high-quality RNG ( #3780 )
...
High-quality RNG, behind the HQ_RANDOM flag, enabled by default
Makes the shuffle test error a bit more tolerant
2023-12-22 17:39:15 +00:00
kittenchilly
505b8b63eb
Add Doodle + update ability banlists ( #3609 )
...
* Add Doodle
* Doodle test
* Oops
* Update battle_util.c
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-12-22 16:45:55 +01:00
DizzyEggg
cd0b4db09b
same lists for healing moves ( #3787 )
...
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2023-12-21 14:07:54 +01:00
fakuzatsu
2af6d65893
added ability to set flags in tests ( #3786 )
2023-12-21 13:01:13 +00:00
DizzyEggg
fcdc515be2
Fix rain dance/sunny day not blending opponent sprite ( #3785 )
2023-12-21 13:17:05 +01:00