DizzyEggg
3e321d1172
fix ally switch dig issue ( #3835 )
2023-12-27 15:35:42 -05:00
Frank DeBlasio
f5e0b3df23
Changed SHINY_ODDS to FALSE in pokedex_plus_hgss.c ( #3832 )
2023-12-27 20:28:44 +01:00
Martin Griffin
3ad66028e9
Backwards-compatible BoxPokémon Refactor ( #3438 )
...
* Check progress in non-battle PARAMETRIZEd tests
* Overworld Script Tests
* Backward-compatible BoxPokemon Refactor
Reuses space that contains zeros to provide space for:
- HP/status in the box
- 12-character nicknames
- Up to 63 PokéBalls
- Shininess separate from PID
- Hidden Nature
- Hyper Training
- Dynamax Level
- Gigantamax Factor
- Terastallization Types
- Shadow
Implements:
- OW_PC_HEAL to switch between Gen7- and Gen8+ behavior
- Nature Mints
- Dynamax Candy
- Hyper Training commands (canhypertrain/hypertrain)
- Gigantamax Factor commands (hasgigantamaxfactor/togglegigantamaxfactor)
- Terastallization Type on the summary screen
- Prevents Gigantamax Factor Pokémon from evolving into a species without a Gigantamax form
* fixup! Backward-compatible BoxPokemon Refactor
* displaydexinfo fix from Jasper
2023-12-27 17:48:17 +01:00
Bassoonian
a4b819ac41
Merge branch 'upcoming' into berryexpansion
2023-12-27 14:00:12 +01:00
ghoulslash
a9d6832908
Separate AI flags by battler position ( #3003 )
...
* ai flags by battlerId
* fix recoded battle saved ai flags
* update aiFlags check in OpponentHandleChoosePokemon
* add header for TRAINER_CUSTOM_PARTNER define
* initialize flags in BattleAI_SetupAIData
* fix usage of TRAINER_CUSTOM_PARTNER
* remove whitespace
---------
Co-authored-by: ghoulslash <pokevoyager0@gmail.com>
2023-12-27 13:54:37 +01:00
Bassoonian
41ff985bb6
PCG fix ( #3830 )
2023-12-27 12:15:16 +01:00
Nephrite
77c722ea09
Obsoleted 22 more effects
...
Also added a better way of calculating battle_tv score properly; to do: Make it Rain
2023-12-27 17:43:20 +09:00
sbird
7f3264c151
[dynamic multichoice] fix -Wall warnings / errors
2023-12-26 14:29:11 +01:00
sbird
c27ea10eb1
Merge branch 'feature/dynmulti' into feature/dynmulti-expansion
2023-12-26 14:22:49 +01:00
Gabriel Cowley
3bae98f768
Fix P_FAMILY if blocks for Regigigas and Giratina ( #3823 )
2023-12-26 10:16:16 +01:00
Nephrite
cd5c59ae5a
Merge remote-tracking branch 'rhh/upcoming' into secondary_effects_overhaul
2023-12-26 13:19:10 +09:00
Nephrite
c5061f0161
Updated remaining moves which use secondaryEffectChance
...
secondaryEffectChance is no longer considered anywhere in the code; tidied up scripts and more
2023-12-26 13:12:11 +09:00
Nephrite
76b4e08e5e
Trapping moves, Secret Power, rampage moves
...
Also tidied up a lot of #ifs and commas in battle_moves.h
2023-12-26 10:46:11 +09:00
Alex
45da55eb14
Fixes Minior form change and likely other forms ( #3822 )
...
* Fixes Minior form change and likely other forms
* new fix
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-12-25 20:18:52 +01:00
Alex
166a1a4e63
Adds ability Embody Aspect + minor fix to Hospitality ( #3821 )
...
* Adds ability Embody Aspect + minor fix to Hospitality
* comment out failing tests related to neutralizing gas
* fixes neutralizing gas bug
* leftover
2023-12-25 18:28:16 +01:00
Nephrite
b0b9883625
Removed unused effects + fixed tests + removed secondaryEffectChance
...
To do: remaining moves that make use of `secondaryEffectChance` field
2023-12-25 12:53:15 +09:00
Nephrite
f3e67cf543
Removed all unused effects
...
Some util updates
2023-12-25 12:32:13 +09:00
Nephrite
cda445c2f5
Merge remote-tracking branch 'rhh/upcoming' into secondary_effects_overhaul_rebase
2023-12-25 12:19:38 +09:00
Alex
1339256d5d
Adds Ability Hospitality ( #3818 )
...
* Adds Ability Hospitality
* fix agbcc
2023-12-25 01:43:57 +01:00
Bassoonian
c47a20a446
Fix gem boost description + test ( #3817 )
2023-12-25 01:14:01 +01:00
ghoulslash
5cc54f5c96
fix cotton down overwriting gBattlerAttacker ( #3783 )
...
Co-authored-by: ghoulslash <pokevoyager0@gmail.com>
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-12-24 23:19:59 +01:00
Bassoonian
77f0ab88d4
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into berryexpansion
2023-12-24 23:17:58 +01:00
Bassoonian
c2a5b71d46
Fix six stage berry graphical issues
2023-12-24 23:17:05 +01:00
Bassoonian
c115649349
Fix 6 stage Berry trees not growing properly
2023-12-24 23:08:15 +01:00
Bassoonian
9be8fed52c
Fix string with duplicate berry berry
2023-12-24 22:59:43 +01:00
LOuroboros
58b03cb3bd
Implemented a CannotUseItemsInBattle function ( #3524 )
...
* Implemented a CannotUseItemsInBattle function
This fucntion is the result of merging CannotUseBagBattleItem and CannotUsePartyBattleItem. No reason to split the work between 2 functions when you can do it all with just 1.
Misc. Changes:
-Turned most of the if statements inside the function into "else if" statements for performance reasons.
-Refactored how the local variable "cannotUse" was used turning it into a bool.
* Made CannotUseItemsInBattle use a switch statement
Misc. Changes:
-Removed pointless parentheses from case EFFECT_ITEM_SET_FOCUS_ENERGY
-Removed pointless i loop variable from case EFFECT_ITEM_INCREASE_ALL_STATS and replaced a hardcoded 1 in its for loop.
-Turned the i loop variable declared at the top of the function into a u32 variable
-Removed pointless comments. The EFFECT_ITEM constants are readable enough to convey what sort of items they affect.
---------
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2023-12-24 22:10:01 +01:00
Nephrite
31b3337cda
Updated moves that raise the target's own stats
...
Modified tests to use MoveHasMoveEffect
2023-12-24 23:52:08 +09:00
Nephrite
e87fe533c3
Superpower, CC, Hammer Arm
2023-12-24 23:43:12 +09:00
Nephrite
a8967da1c5
Overheat (and clones)
...
Also, Syrup Bomb (really weird script)
2023-12-24 23:27:21 +09:00
Nephrite
a244d7b8b6
Updated moves that raise the target's own stats
...
To do: moves like CC, Overheat that LOWER stats; did NOT remove the effect for raising all stats due to an AI function
2023-12-24 22:55:53 +09:00
kittenchilly
37f19ed39e
Fix Maushold-3 and Maushold-4 icons being swapped ( #3809 )
2023-12-23 17:34:52 +01:00
Zimmermann Gyula
f700466e8d
Implement optional Gen1 type immunity logic. ( #3627 )
...
* Implement optional Gen1 type immunity logic.
* Add tests against Gen1 burn, freeze and paralysis.
* !fixup Expand tests with Gen1 paths.
* Fixup tests.
Remove superflous defines.
Explicitly ASSUME used move type and effect.
* Fix flipped definitions on Freezing Glare test.
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-12-23 16:34:24 +01:00
Zimmermann Gyula
d2235a3657
Depreciate agbcc and clarify gcc version usage in install instructions. ( #3788 )
...
* Depreciate agbcc in install instructions.
* Clarify that Ubuntu 22.04 ships with GCC v10.
* Also clarify v13 usage on remote repos.
* Typo.
* Use Edu's reworded note from the Team Aqua discord.
https://discord.com/channels/976252009114140682/1023424424713650196/1187462445762101278
2023-12-23 12:43:46 +01:00
Alex
61e6365470
Fixes Photon Geyeser category + minor AI calc fixes ( #3807 )
2023-12-23 12:31:40 +01:00
Zimmermann Gyula
72615a7c35
Prevent infinite loop. ( #3808 )
...
Regression caused by fe1bad68b4
2023-12-23 12:29:12 +01:00
Bassoonian
662939d5f9
Add family defines
2023-12-23 00:41:47 +01:00
Bassoonian
db0a9484ae
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into berryexpansion
2023-12-23 00:39:10 +01:00
DizzyEggg
1a7166c2bb
Tests do not allow to use SEND_OUT if the chosen mon is fainted ( #3752 )
...
* Tests dont allow to send out pokemon with 0 hp
* remove test test
* handle in-game 0 hp sent out
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-12-23 00:27:40 +01:00
Alex
fd45b383b1
Fix Photon Geyser ( #3803 )
...
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-12-22 23:38:57 +01:00
Philipp AUER
5651bea82b
[battle_controller_player.c] refactor and fix buffer overread ( #3792 )
...
Co-authored-by: sbird <sbird@no.tld>
2023-12-22 23:24:12 +01:00
tertu
fb28ce50ae
Optional high-quality RNG ( #3780 )
...
High-quality RNG, behind the HQ_RANDOM flag, enabled by default
Makes the shuffle test error a bit more tolerant
2023-12-22 17:39:15 +00:00
Alex
63316daf30
Adds missing Doodle tests and fix ( #3800 )
2023-12-22 18:25:23 +01:00
kittenchilly
505b8b63eb
Add Doodle + update ability banlists ( #3609 )
...
* Add Doodle
* Doodle test
* Oops
* Update battle_util.c
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-12-22 16:45:55 +01:00
ghoulslash
38d67d9051
fix exp gain when defeating two opponents at once ( #3798 )
...
Co-authored-by: ghoulslash <pokevoyager0@gmail.com>
2023-12-22 16:24:46 +01:00
Alex
83e2f4bdf8
Adds ability Minds Eye + Tests ( #3782 )
...
* Implemented Mind's Eye with tests + Keen Eye tests
* AI test
* fix AI minds eye test
* Adds ability Minds Eye + Tests
* fix tests
---------
Co-authored-by: Eduardo Quezada <eduardo602002@gmail.com>
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-12-22 16:22:53 +01:00
Alex
566653aa63
Replace mons for gen9 abilities ( #3740 )
2023-12-22 15:05:35 +01:00
Bassoonian
f86648755a
Fix Mega Stone descriptions ( #3797 )
2023-12-22 14:11:02 +01:00
DizzyEggg
91741cb60f
fix debug menu toggling first flag ( #3796 )
2023-12-22 11:26:43 +01:00
ravepossum
c9e9b4906a
Make overworld weather-based terrain effects use B_MSG_TERRAIN_SET constants for intro text ( #3793 )
...
Co-authored-by: ravepossum <ravepossum@example.com>
2023-12-22 09:43:22 +01:00
LOuroboros
96cb4d3823
Added last CannotUseItemsInBattle tests ( #3789 )
...
* Added missing CannotUseItemsInBattle tests
* Removed individual assumptions for the EFFECT_ITEM_ESCAPE tests and added a single global one
* Added assumption for the move-related EFFECT_ITEM_ESCAPE test
* Moved the Mean Look assumption for consistency with other tests and to be extra safe
2023-12-21 20:06:12 +01:00