Eduardo Quezada D'Ottone
3d2e0d2065
Fixed Ursaluna's cry using P_GEN_9_CROSS_EVOS ( #4210 )
2024-02-18 10:21:56 +01:00
Wesmaster
45cee8124d
Fixed LastUsedBall not being saved and DisplayBall not being shown ( #4209 )
...
In #4168 b7d7709#4200 . The sizeof was done on the variable instead of the struct. This caused other variables in EWRAM to loose their value. I have no idea if this fix breaks what was intented to do in #4168 .
Also fixed the issue reported in my comment. When you run out of balls gLastThrownBall has a value, but you enter the if statement because you have no more balls. There the next in line ball is set to display but if there are non there is nothing to display. Afterwards when you get a new ball, you do not enter the if statement to update the gBallToDisplay because the ball is in the bag and gLastThrownBall is still set to not 0. Then it's checked if the bag has gBallToDisplay which does not point to a ball and therefor nothing is shown. Now we only update gBallToDisplay if there is actually a ball to display.
2024-02-17 20:26:45 +01:00
MelonSpeedruns
20a3d91de7
Fixed Basculegion Back Sprite Offset & Greninja forms animations ( #4198 )
2024-02-15 15:56:32 -03:00
Bassoonian
6a61e6525e
Fix height call ( #4195 )
2024-02-15 13:07:31 +01:00
cmy2008
ab2260a81e
Deleted a space ( #4194 )
2024-02-15 10:21:35 +01:00
Alex
3598a18703
Adds config for Soundproof change during Uproar status ( #4174 )
2024-02-11 10:40:30 +01:00
Bassoonian
b4fa0b1bf0
Clean up space/tabs difference ( #4163 )
2024-02-10 14:43:14 -03:00
Alex
b7d77099b5
Fixes Opportunist accumulating stat changes ( #4168 )
...
* Fixes Opportunist accumulating stat changes
* move memset to TurnValuesCleanUp
* Update test/battle/ability/opportunist.c
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2024-02-10 18:18:29 +01:00
Eduardo Quezada D'Ottone
8b871b7eb4
Fixed Disguise not ending the battle in the correct form ( #4167 )
...
* Fixed Disguise not ending the battle in the correct form
* Added TODO comments
2024-02-10 17:13:46 +01:00
Eduardo Quezada D'Ottone
0f312e3f76
Fixed Ogerpon shiny palettes ( #4165 )
2024-02-09 22:51:36 +01:00
Hungry Pickle
47abc33c84
Fixes Stench ability triggering on non-damaging attacks ( #4159 )
...
* Fixes Stench ability triggering on non-damaging attacks
* adds stench ability test
* added stench ability test for partner pokemon
---------
Co-authored-by: HungryPickle <beardybirdy@gmail.com>
2024-02-09 15:35:40 +01:00
Alex
e89f8e00ed
Fixes Hit Escape moves interaction with hold effects and switch in ab… ( #4091 )
...
* Fixes Hit Escape moves interaction with hold effects and switch in abilities
* leftover
* fix spelling
* fix desc.
2024-02-09 14:00:42 +01:00
DizzyEggg
31ac151e29
Fix Full Restore / Antidote not reseting Toxic Counter ( #4135 )
...
* Fix Full Restore / Antidote not reseting Toxic Counter
* Update battle_scripts_2.s
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2024-02-09 13:58:16 +01:00
Alex
452432533a
Kee berry ( #4149 )
...
* Fixes Kee Berry
* new line
* Fix fix
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2024-02-07 15:42:22 +01:00
Alex
fa5f507b1e
Fixes Mycelium Might speed bracker ( #4146 )
...
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2024-02-06 23:30:57 +01:00
Eduardo Quezada D'Ottone
6a71e14718
Added credits section to PR template ( #4141 )
2024-02-06 12:39:42 +01:00
ravepossum
8b70cea725
Fix screen select bar popping in too early for area screen in HGSS dex ( #4094 )
...
* fixing screen select bar popping in too early for area screen in HGSS pokedex
* exit early from select bar load function if dex is disabled
* remove unnecessary early exit
---------
Co-authored-by: ravepossum <ravepossum@example.com>
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2024-02-05 15:40:25 +01:00
DizzyEggg
065c0ec588
Fairy Lock animation fix ( #4111 )
...
* Fairy Lock animation fix
* remove comment
* fairy lock anim hopefully works
---------
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2024-02-04 23:23:03 +01:00
DizzyEggg
512ab98bfe
Fix disobedience not resetting multihit moves ( #4133 )
2024-02-04 16:13:27 +01:00
ravepossum
e75169fb87
Fix HGSS Dex List Decapped Tileset ( #4126 )
...
* fix decap HGSS dex tileset scroll bar
* more tileset fixes
---------
Co-authored-by: ravepossum <ravepossum@example.com>
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2024-02-03 20:07:47 +01:00
Alex
46d9adb326
Fixes Eerie Spell double pp and message drop ( #4127 )
...
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2024-02-03 19:34:52 +01:00
DizzyEggg
85eea4869d
Fix move animation crashing on some emulators because of division by zero ( #4121 )
...
* fix flip turn div by zero
* fix incinerate move anim div by zero
2024-02-03 16:56:50 +01:00
kaicardenas2
e828ae58a1
Non-Tagged Release ( #4109 )
2024-02-01 21:20:10 -03:00
Eduardo Quezada D'Ottone
2d24f96420
Version 1.7.3 ( #4106 )
...
* Version 1.7.3
* Latest changelog
2024-02-01 20:55:53 -03:00
DizzyEggg
1d9e692e31
Unused warnings are no longer treated as errrors by default ( #4092 )
2024-02-01 20:19:14 +01:00
Bassoonian
e8538ef585
Merge branch 'master' into _RHH/pr/master/unused
2024-02-01 13:48:44 +01:00
Alex
1a65894967
Fixes test description + small fix follow up ( #4100 )
...
* Fixes test description + small fix follow up
* fix fix
* Apply suggestions from code review
---------
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
2024-01-31 09:33:04 -03:00
Eduardo Quezada D'Ottone
5af733a391
Merge branch 'master' into _RHH/pr/master/unused
2024-01-31 08:18:55 -03:00
Eduardo Quezada
f7e5709745
Review changes
2024-01-31 08:18:43 -03:00
DizzyEggg
f5623595a0
Fix AI trying to switch into the same mon 2 times ( #4098 )
2024-01-30 16:14:33 +01:00
ravepossum
8b62828e3f
Fix HGSS Dex dark mode search palette ( #4095 )
...
Co-authored-by: ravepossum <ravepossum@example.com>
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
2024-01-29 17:51:10 -03:00
Eduardo Quezada D'Ottone
a2a38a57e0
Added passing "KNOWN_FAILING" to test summary ( #4063 )
...
* Added passing "KNOWN_FAILING" to test summary
* Added test names for passing KNOWN_FAILING to summary
* Removed unused function
2024-01-29 17:01:50 -03:00
Eduardo Quezada
a0bcdbff42
Workflow test worked, undoing changes
2024-01-29 13:31:42 -03:00
Eduardo Quezada
e8a6c46391
Only do unused error under RHH's repo + workflow test
2024-01-29 13:19:01 -03:00
Eduardo Quezada
2988883a12
Unused warnings are not treated as errrors by default
2024-01-29 12:52:03 -03:00
Eduardo Quezada
127a7e9600
Backported gHeap alignment fix from upstream pret
2024-01-29 01:18:12 +01:00
Alex
9bcd46bce8
Fixes Pursuit, Tangling Hair interaction ( #4086 )
2024-01-28 19:15:53 +01:00
johannakullmann
3e50480cab
Fixed graphics bug with Steven double battle ( #4078 )
...
Caused the wrong palette to be used during Steven's ball throw animation in the Mossdeep Space Center fight.
2024-01-27 15:59:39 +01:00
Bassoonian
e995927d13
Add extra key item bag space checks ( #4066 )
...
* Fix 4019
* I am exceedingly brilliant in my failure to build before pushing
2024-01-26 21:11:04 +01:00
Alex
91f429b5e5
Fixes Glimmering Charm ( #4047 )
...
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
2024-01-22 13:55:08 +01:00
Bassoonian
b99ec5d43c
Update level_up_learnsets.h ( #4046 )
2024-01-22 00:07:19 +01:00
Alex
0ec777dd24
Fixes Mind Blown / Magic Guard interaction and renames Steel Beam effect ( #4043 )
...
* Fixes Mind Blown / Magic Guard interaction and renames Steel Beam effect
* review fixes
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2024-01-21 23:42:01 +01:00
Mathew Arnold
a01d442f36
Fixed Kingra's learnset gen ( #4044 )
...
In level_up_learnsets.h, Kingdra's learnset was inside a check for P_GEN_4_CROSS_EVOS. As a Gen 2 Pokemon, this has been updated to check for P_GEN_2_CROSS_EVOS instead.
2024-01-21 18:23:55 +01:00
Bassoonian
9286b80866
Remove illegal moves from teachable learnsets ( #4042 )
...
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2024-01-21 13:02:45 +01:00
Alex
35e2157c09
Fixes ability Corrosion ( #4037 )
...
* Fixes ability Corrosion
* forgot AI_CanPoisonType
* More tests
* review comments applied
* more review changes
* simplify CanPosionType (original state)
* remove redundant function
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2024-01-21 12:27:58 +01:00
Alex
04fa3aa725
Fixes Emergency Exit when hp is restored over tag out range ( #4041 )
...
* Fixes Emergency Exit when hp is restored over tag out range
* Update test/battle/ability/emergency_exit.c
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2024-01-21 11:08:25 +01:00
Bassoonian
53a46b7a29
Remove faulty teachable learnset moves ( #4039 )
2024-01-21 10:25:37 +01:00
Philipp AUER
73a1fa30e9
fix: emergency exit cutoff off by 1 on odd max hp ( #4040 )
...
* fix: emergency exit cutoff off by 1 on odd max hp
* squash!: newline at end of file
---------
Co-authored-by: sbird <sbird@no.tld>
2024-01-21 09:11:10 +01:00
Alex
d125da7797
Fixes Life Orb + Eject Pack / Red Card interaction ( #4038 )
...
* Fixes Life Orb + Eject Pack / Red Card interaction
* fix test
2024-01-20 22:48:34 +01:00
Bassoonian
f3342de00b
Condense Oinkologne teachable learnsets ( #4026 )
...
* Condense Oinkologne teachable learnsets
* Fix redundant backslash
2024-01-19 17:01:14 +01:00
