* Fixed Shaymin form change with incorrect status condition
* Fixed Shaymin receiving damage again after changing form
* PR feedback updates - fixed missing commas in battle script
* Added Shaymin form change test by @AlexOn1ine
* Fixed some moves' on-hit effects bypassing Substitutes where they shouldn't.
Fixed Sparkling Aria interaction with Shield Dust in Singles vs Doubles.
Fixed Wake-Up Slap and Smelling Salts getting boosted damage where they shouldn't vs Substitutes.
* Cleaned up check for Sparkling Aria+Shield Dust interaction and fixed for agbcc.
Fixed logic for checking if moves should do extra damage on statused targets.
Wrote tests for Wake-Up Slap and Smelling Salts receicing extra damage on statused targets.
Wrote tests to check Thousand Arrows type effectiveness vs ungrounded Flying types.
* Update src/battle_util.c
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
* Update src/battle_script_commands.c
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
* Update src/battle_script_commands.c
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
* Update test/battle/ability/shield_dust.c
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
* Update test/battle/item_effect/covert_cloak.c
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
* Update test/battle/item_effect/covert_cloak.c
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
* Update test/battle/item_effect/covert_cloak.c
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
* Update test/battle/move_effect/smelling_salts.c
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
* Update test/battle/move_effect/thousand_arrows.c
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
* Update test/battle/move_effect/wake_up_slap.c
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
* Update test/battle/move_effect/wake_up_slap.c
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
* Update test/battle/move_effect/wake_up_slap.c
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
---------
Co-authored-by: Hedara <hedara90@gmail.com>
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
* Update IsDamageMoveUsable to check for Steel Roller viability
* Condense terrain flag checks and renamed IsDamageMoveUsable
IsDamageMoveUsable is now named IsDamageMoveUnusable to more accurately reflect the boolean it returns.
* Made the AI aware of when more moves will fail against Dynamax Pokemon
Turns out Dynamax Pokemon are immune to quite a few moves. The AI is only aware of one of these at present--the Low Kick/Grass Knot effect, which I learned when the AI tried to Heavy Slam my Dynamaxed Pokemon. These additional cases should prevent the AI from selecting moves that have no effect against Dynamax Pokemon, though it may still select moves whose secondary effect won't work on Dynamaxed Pokemon (such as Fake Out or Circle Throw).
* Update battle_ai_util.c
Now handles damaging moves that Dynamax Pokemon are immune to
* Update scores for Status moves Dynamax Pokemon are immune to
* Extra parentheses oops
* Update pokemon.h
Added "doesntAffectDynamax" flag to MoveInfo
* Update pokemon.h
Replaced comma with semicolon (I'm using the online editor for this lol, sorry for all the commits)
* Update moves_info.h
Set the "doesntAffectDynamax" flag to TRUE for moves that have no effect on Dynamaxed targets.
* Update battle_dynamax.c
IsMoveBlockedByDynamax now simply returns the move's "doesntAffectDynamax" flag.
* Revert "Update pokemon.h"
This reverts commit 7edde776f8.
Revert "Update pokemon.h"
This reverts commit ed01b18d75.
Revert "Update moves_info.h"
This reverts commit bc42e7bccf.
Revert "Update battle_dynamax.c"
This reverts commit 29dbdce850.
* Update battle_ai_main.c
Made the new conditions consistent as separate checks.
* Update battle_ai_main.c
Whitespace formatting fixes. Sorry, lost track of what I'd changed and what I hadn't.
* A bunch of sprite fixes
- New Basculin Blue and White animations to fix their entry animations
- New Xerneas Neutral entry animation derived from its Active form animation
- Recolored Iron Hands and Iron Bundle back sprites
* Requested changes
* Updated Mega Mewtwo Y sprite to fix transparent eye pixel
* Updated Keldeo Resolute sprite to a two framed animation
* Updated Keldeo Resolute sprite to increase definition to facial features
* Improved Keldeo Resolutes second frame to match BW2 original & changed front animation
* Added Meloetta Pirouette front anim
* Updated Meloetta Pirouette anim frame to a dip
* stat stage related AI fixes
* add more ai fixes and 2 tests
* use legal ability in tests
* Fix test and remove mold breaker check
* Use DoesBattlerIgnoreAbilityChecks
* Changed Dubious Disc description to prevent overflow
The first line of the Dubious Disc description was too long. A few letters would escape the box in the Bag and in Marts. This brings them in line.
* Changed Ice Beam and Blizzard Frostbite descriptions
These descriptions also overflowed, even more so than the Dubious Disc.
* Update IsDamageMoveUsable to check for Steel Roller viability
* Condense terrain flag checks and renamed IsDamageMoveUsable
IsDamageMoveUsable is now named IsDamageMoveUnusable to more accurately reflect the boolean it returns.
* Made the AI aware of when more moves will fail against Dynamax Pokemon
Turns out Dynamax Pokemon are immune to quite a few moves. The AI is only aware of one of these at present--the Low Kick/Grass Knot effect, which I learned when the AI tried to Heavy Slam my Dynamaxed Pokemon. These additional cases should prevent the AI from selecting moves that have no effect against Dynamax Pokemon, though it may still select moves whose secondary effect won't work on Dynamaxed Pokemon (such as Fake Out or Circle Throw).
* Update battle_ai_util.c
Now handles damaging moves that Dynamax Pokemon are immune to
* Fixed test folders + Chud Chew test name fixes
* Adjusted file names + merged Burn Up and Double Shock files
* Added Spit Up/Swallow files that point to Stockpile's file
* Multiple changes (see description)
- Moved secondary effect files to their own folder.
- Split hit_set_entry_hazards.c to separate files for Spikes/Stealth Rock.
- Grouped Hex/Venoshock to the same file
* Fixes Costar, Zero to Hero, Supreme Overlord and Ruin abilities' switch-in messages
* Fixed typo in Supreme Overlord's String Id
* Fixes spacing in battle_string_ids.h
* Update IsDamageMoveUsable to check for Steel Roller viability
* Condense terrain flag checks and renamed IsDamageMoveUsable
IsDamageMoveUsable is now named IsDamageMoveUnusable to more accurately reflect the boolean it returns.
* Fixed forseen moves not triggering Color Change and added tests for Color Change
* Added issue number to Known Failing test
---------
Co-authored-by: Hedara <hedara90@gmail.com>
