Nephrite
cd5c59ae5a
Merge remote-tracking branch 'rhh/upcoming' into secondary_effects_overhaul
2023-12-26 13:19:10 +09:00
Nephrite
c5061f0161
Updated remaining moves which use secondaryEffectChance
...
secondaryEffectChance is no longer considered anywhere in the code; tidied up scripts and more
2023-12-26 13:12:11 +09:00
Alex
166a1a4e63
Adds ability Embody Aspect + minor fix to Hospitality ( #3821 )
...
* Adds ability Embody Aspect + minor fix to Hospitality
* comment out failing tests related to neutralizing gas
* fixes neutralizing gas bug
* leftover
2023-12-25 18:28:16 +01:00
Nephrite
b0b9883625
Removed unused effects + fixed tests + removed secondaryEffectChance
...
To do: remaining moves that make use of `secondaryEffectChance` field
2023-12-25 12:53:15 +09:00
Nephrite
cda445c2f5
Merge remote-tracking branch 'rhh/upcoming' into secondary_effects_overhaul_rebase
2023-12-25 12:19:38 +09:00
Alex
1339256d5d
Adds Ability Hospitality ( #3818 )
...
* Adds Ability Hospitality
* fix agbcc
2023-12-25 01:43:57 +01:00
Nephrite
31b3337cda
Updated moves that raise the target's own stats
...
Modified tests to use MoveHasMoveEffect
2023-12-24 23:52:08 +09:00
Nephrite
e87fe533c3
Superpower, CC, Hammer Arm
2023-12-24 23:43:12 +09:00
Nephrite
a8967da1c5
Overheat (and clones)
...
Also, Syrup Bomb (really weird script)
2023-12-24 23:27:21 +09:00
Zimmermann Gyula
f700466e8d
Implement optional Gen1 type immunity logic. ( #3627 )
...
* Implement optional Gen1 type immunity logic.
* Add tests against Gen1 burn, freeze and paralysis.
* !fixup Expand tests with Gen1 paths.
* Fixup tests.
Remove superflous defines.
Explicitly ASSUME used move type and effect.
* Fix flipped definitions on Freezing Glare test.
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-12-23 16:34:24 +01:00
DizzyEggg
1a7166c2bb
Tests do not allow to use SEND_OUT if the chosen mon is fainted ( #3752 )
...
* Tests dont allow to send out pokemon with 0 hp
* remove test test
* handle in-game 0 hp sent out
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-12-23 00:27:40 +01:00
tertu
fb28ce50ae
Optional high-quality RNG ( #3780 )
...
High-quality RNG, behind the HQ_RANDOM flag, enabled by default
Makes the shuffle test error a bit more tolerant
2023-12-22 17:39:15 +00:00
Alex
63316daf30
Adds missing Doodle tests and fix ( #3800 )
2023-12-22 18:25:23 +01:00
kittenchilly
505b8b63eb
Add Doodle + update ability banlists ( #3609 )
...
* Add Doodle
* Doodle test
* Oops
* Update battle_util.c
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-12-22 16:45:55 +01:00
Alex
83e2f4bdf8
Adds ability Minds Eye + Tests ( #3782 )
...
* Implemented Mind's Eye with tests + Keen Eye tests
* AI test
* fix AI minds eye test
* Adds ability Minds Eye + Tests
* fix tests
---------
Co-authored-by: Eduardo Quezada <eduardo602002@gmail.com>
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-12-22 16:22:53 +01:00
Alex
566653aa63
Replace mons for gen9 abilities ( #3740 )
2023-12-22 15:05:35 +01:00
fakuzatsu
2af6d65893
added ability to set flags in tests ( #3786 )
2023-12-21 13:01:13 +00:00
Nephrite
1708c80200
Removed ALWAYS_CRIT, renamed critBoost ( #3779 )
...
Replaced ALWAYS_CRIT with an alwaysCriticalHit flag to account for the fact that in earlier generations, there is no crit stage at which crits are guaranteed. Renamed critBoost to criticalHitStage (at Edu's prompting). Reorder .criticalHitStage defines in battle_moves.h to be aligned with struct order.
2023-12-20 16:16:02 +01:00
DizzyEggg
6137db102e
Ally Switch ( #3533 )
...
* ally switch move animation
* Ally Switch anim done
* ally switch test and improve animation
* derp
* add ally switch known failing test for ally targeting moves
* moves which targetted ally fail after ally switch
* ally switch works like protect
---------
Co-authored-by: root <root@LAPTOP-3SNV7DEQ>
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2023-12-20 15:26:28 +01:00
Martin Griffin
50cbcebc81
Merge remote-tracking branch 'rhh/master' into upcoming
2023-12-20 12:56:35 +00:00
Alex
069769710b
Fixes Item Metronome damage ( #3767 )
...
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-12-20 11:24:12 +01:00
Eduardo Quezada D'Ottone
442620cf6b
Renamed Battle Move "Split" to the proper "Category" ( #3774 )
2023-12-20 10:08:26 +01:00
Martin Griffin
13a4bf5838
Merge remote-tracking branch 'rhh/master' into upcoming
2023-12-19 18:08:13 +00:00
Nephrite
4a1a6c5625
Battlemove refactored (recoil, crit and Z moves) ( #3575 )
...
* Unified EFFECT_RECOIL
Combined EFFECT_RECOIL_25/33/50/33_STATUS into a single EFFECT; added an extra field to BattleMove 'secondaryData' that contains the franction of HP recoil; argument still holds status effect for Flare Blitz/Volt Tackle
* BattleMove struct change
Added critrate, recoil, multihit fields, made zMove into a union of effect/powerOverride for status/non-status moves respectively. Added new recoil field and zMove field to all moves. To-do: crit rate, multihit
* Critrate field added
Moves use a critRate field instead of a flag - obsoletes EFFECT_ALWAYS_CRIT
* Just a little define
Makes clear that critBoost = 3 means ALWAYS CRIT
* Added a proper recoil field
Just to make it unambiguous and flexible - can finally have a move with 69% recoil.
* Fixed AI damage calculation for multi-strike moves
* Fixes + removed unused effects
* Tests fixes
Two to fix: pass when run in isolation but not when the whole group is run, which is annoying...
* Minor fixes
* Minor tweaks
* Fixed move effects
* recoil tests
---------
Co-authored-by: Alex <alexthenotes@gmail.com>
2023-12-19 16:10:07 +01:00
DizzyEggg
e8e9d37640
Prankster tests + fixes ( #3766 )
...
* Prankster tests + partial fix
* Fix Prankster tests and some edge cases
---------
Co-authored-by: Alex <alexthenotes@gmail.com>
2023-12-19 11:17:31 +01:00
DizzyEggg
1ec0333432
Fix Ion Deluge interaction with VoltAbsorb/LightRod ( #3764 )
...
* Fix Ion Deluge interaction with VoltAbsorb/LightRod
* Use move target all battlers for ion deluge fix
* fix teatime failing
---------
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2023-12-18 16:57:56 +01:00
DizzyEggg
59a159c338
Fix Ice Face ignoring move effects ( #3755 )
...
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2023-12-18 16:02:07 +01:00
DizzyEggg
64f8635496
fix telekinesis not working ( #3763 )
...
* fix telekinesis not working
* typo
* remove one roost known failing
---------
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2023-12-18 15:50:03 +01:00
DizzyEggg
e1d4bcc04e
fix frisk msg + tests ( #3762 )
2023-12-18 15:13:14 +01:00
Eduardo Quezada
c505abd53d
Merge branch 'RHH/master' into RHH/upcoming
2023-12-17 18:13:26 -03:00
DizzyEggg
e22ac51617
Fix Innards Out doing dmg after Gastro Acid / vs Magic Guard ( #3758 )
...
* gastro acid stays for fainted mons
* Innards Out does not damage Magic Guard Pokemon
2023-12-17 21:47:12 +01:00
Eduardo Quezada
d92c046a80
Merge branch 'RHH/master' into RHH/upcoming
2023-12-17 17:31:10 -03:00
DizzyEggg
76a7513dcd
Fix Magician Life orb recoil when stealing ( #3753 )
...
* Fix Magician Life orb recoil
* get rid of unneeded assume
2023-12-17 19:50:43 +01:00
DizzyEggg
d79fe11bb1
get rid of known failing in ai test ( #3748 )
...
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
2023-12-17 15:11:02 +01:00
DizzyEggg
3df101a6a0
fix baton pass not passing embargo ( #3745 )
...
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2023-12-17 00:25:16 +01:00
Eduardo Quezada D'Ottone
ef6edcf098
Fixed Ivy Cudgel test name ( #3742 )
2023-12-16 09:22:36 +01:00
Eduardo Quezada
fbbee39886
Merge branch 'RHH/master' into RHH/upcoming
...
# Conflicts:
# src/battle_main.c
2023-12-15 18:50:20 -03:00
Alex
94ffeb2cf8
Fix Quick Claw chance ( #3737 )
2023-12-15 17:05:11 +01:00
Bassoonian
0fd08a32ac
Add status form change
2023-12-15 11:17:35 +01:00
Eduardo Quezada D'Ottone
c44e133d8c
Updated Gen 9-mon-exclusive ability tests to use Gen 9 mon ( #3733 )
...
* Updated Gen 9-mon-exclusive ability tests to use Gen 9 mon
* Fixed message
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-12-15 00:19:28 +01:00
Alex
be045fdc0c
Fixes Quick Draw ( #3724 )
...
* Fixes Quick Draw
* Fixes Custap and rest of Quick Draw
* review applied
2023-12-15 00:03:59 +01:00
Alex
38c61854e6
Changed Ivy Gudgel effect ( #3721 )
...
* Change Ivy Gudgel effect
* test assumptions
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-12-14 18:09:06 +01:00
Alex
44e81d4f4c
Gen 9 configs for Protean/Libero, Intrepid Sword and Dauntless Sword ( #3614 )
...
* Gen 9 configs for Protean/Libero, Intrepid Sword and Dauntless Sword
* use bitfield
* battler fix
* fields
2023-12-12 00:08:44 +01:00
Martin Griffin
ee1fb1d454
SpeciesInfo tests ( #3688 )
...
* Remove unnecessary const
* Test that species ID tables are shared between all forms
* Use P_FAMILY_MELTAN
* Test that form change tables contain only IDs in form species tables
* Fix isPrimalReversion typo
* Test form change targets have appropriate species flags
* Fix #3689
2023-12-11 13:54:20 +01:00
Eduardo Quezada
b2917fac5d
Merge remote-tracking branch '_RHH_origin/master' into RHH/upcoming
...
# Conflicts:
# include/constants/battle_script_commands.h
# src/battle_script_commands.c
2023-12-10 14:29:42 -03:00
Rose
8dbce50783
Fix Ice Heal typo in test
...
Ice heal heals being frozen, not paralyzed
2023-12-10 17:07:28 +00:00
Alex
628eb95925
Adds Rage Fist ( #3573 )
...
* Adds Rage Fist
* Fix initial implementation
* fix merge
* review changes
* endure test
* add field enduredDamage
* rage fist: transform, disguise and field change
* merge fix
2023-12-10 12:33:25 +01:00
Alex
403843cecf
Fixes Fling damage calcs ( #3670 )
2023-12-10 00:27:05 +01:00
Alex
57ce85207e
Fixes Substitute triggering Stamina and Eject Button on crash damage ( #3669 )
...
* Fixes Substitute triggering Stamina
* Fix Eject Button triggering on crash damage
2023-12-09 17:40:04 +01:00
Alex
d86a2136a7
Fixes Cutton Down / Defiant interaction ( #3657 )
2023-12-08 17:29:29 +01:00