Commit graph

14623 commits

Author SHA1 Message Date
psf
8d6cb9692a
Improved Repel / Lure Menu (#3594)
* First draft of repel lure

* Updated all lure and repel scripts

* Optimized inc file

* Updated y coord

* optimized sprays.c

* Removed spray.inc

* Updated cosnt use

* Removed dead repel and lure code

* Updated debug for testing

* testing new inc file

* turn on debug and options

* playground generated inc file without ifs

* pory generated inc with ifdef complete

* Updated spray.c with new inc

* reverted item config

* Reverted event scripts

* Reverted event scripts

* Revert config

* Added testing scripts for debug

* Added back specials

* reverted debug scripts

* Updated use of constants

* Addressed tabs > spaces feedback
https://github.com/rh-hideout/pokeemerald-expansion/pull/3594\#discussion_r1402917676

* Updated constant names to avoid confusion
Made inc file changes
https://github.com/rh-hideout/pokeemerald-expansion/pull/3594\#pullrequestreview-1746418044

* Updated constant name of NUM_SPRAY_TYPES to NUM_SPRAY_STRENGTH to be more accurate
2023-11-23 21:31:33 +01:00
Alex
71fd95e6d4
Fixes Protosynthesis and Quark Drive ability pop up (#3595) 2023-11-23 19:49:21 +01:00
Bassoonian
d6ded280a3
Reflect Ivy Cudgel type in interfaces (#3590)
* Reflect Ivy Cudgel type in interfaces

* Use GetSideParty
2023-11-23 19:23:10 +01:00
Nephrite
5eae07e4b9 Jaw Lock, Axe Kick, Spin Out
Jaw Lock needs a test but I'm too lazy to write it
2023-11-23 23:43:11 +09:00
Nephrite
b7d77ad59e Confusion moves 2023-11-23 23:33:55 +09:00
Nephrite
d81bf6afde EFFECT_POISON_HIT
Also tidied up paralysis/burn scripts; updated Barb Barrage
2023-11-23 22:29:11 +09:00
Nephrite
bec0fea7f6 Flinching moves
All work fine - all tests pass
2023-11-23 17:14:50 +09:00
Nephrite
d9f64b7537 Fixed seteffectwithchance
Now has the ability to loop over multiple effects without causing problems - requires a maybe controversial macro modification...
2023-11-23 17:08:30 +09:00
Nephrite
27c32f1d36 Fixed compatibilty with current move effect system and other moves 2023-11-23 13:16:52 +09:00
ghoulslash
c0bc6979c7
Fixes Howl activating if partner has Soundproof (#3593) 2023-11-22 17:42:36 -05:00
Alex
ca39889587 Fixes Howl 2023-11-22 21:55:08 +01:00
Nephrite
ffe89c7248 Redid Fang Moves
Pass tests too
2023-11-23 00:21:57 +09:00
Alex
7fb811d33d burn_hit -> move_effect_burn 2023-11-22 19:24:32 +09:00
Alex
ba6d223f17 matcha gotcha 2023-11-22 19:20:30 +09:00
Bassoonian
a7beed5b25
Dynamax messages (#3581)
* Dynamax messages

* Convert various to callnative

* Remove battler argument from callnatives

* Rename i variable

* Fix missing else
2023-11-21 19:18:18 +01:00
Alex
b9edbb429b
Adds combined pledge move effects (#3336)
* Adds combined pledge move effects

* added pledge status and various other fixes

* leftover

* fix triple arrow test tag

* pledge moves can not be redirected by absorbing abilities

* more pledge changes

* remove duplicate test

* Stab boost, Rainbow anim and new SeaOfFire anim

* leftover

---------

Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-11-21 16:23:22 +01:00
Alex
be42d4eafb
Increase score of secondary effects only at 100% chance (#3583)
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-11-21 11:30:20 +01:00
ghoulslash
4c783e2ae1
Indexes for Type Effectiveness table (#3374) 2023-11-20 22:02:22 -05:00
ghoulslash
5be62225ec
Merge branch 'upcoming' into RHH/pr/upcoming/typeEffectiveness 2023-11-20 21:45:37 -05:00
ghoulslash
34c608724d
Clean up time of day code (#3585) 2023-11-20 14:39:50 -05:00
Alex
428a23d313
Merge branch 'upcoming' into timefunctionfixes 2023-11-20 20:20:04 +01:00
Frank DeBlasio
f356bb1cee
Added B_UPDATED_MOVE_DATA checks against Acid/Crunch's descriptions (#3586)
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2023-11-20 20:07:34 +01:00
ghoulslash
41e65357b8
Merge branch 'upcoming' into timefunctionfixes 2023-11-20 14:04:19 -05:00
Bassoonian
c9c0827ba2
Fix 3568 (#3569) 2023-11-20 19:33:06 +01:00
Bassoonian
cb245a00c6
Includes older item and move names as variants (#3580)
* Item name variants

* Updated move names

---------

Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2023-11-20 18:35:00 +01:00
GriffinR
b302291bd3
Merge pull request #1953 from Icedude907/move-files
Moved files - spinda spots, jp fonts, redyellowgreen_frame.bin
2023-11-20 12:27:05 -05:00
Nephrite
1dadc79b8b Triple Arrows redo
Sorry, Lunos
2023-11-20 19:39:13 +09:00
Bassoonian
f6f305ef1d Clean up time of day code 2023-11-20 11:06:20 +01:00
Eduardo Quezada
13a65a21ad Adds configable nature colors (#3582)
* Colored stats depending on nature

* Fix bug

* Update colors and add config

---------

Co-authored-by: DizzyEggg <jajkodizzy@wp.pl>
2023-11-19 21:11:38 -03:00
Eduardo Quezada
341bbb30ef Revert "Adds configable nature colors (#3582)"
This reverts commit 9311911413.
2023-11-19 21:10:21 -03:00
Bassoonian
9311911413
Adds configable nature colors (#3582)
* Colored stats depending on nature

* Fix bug

* Update colors and add config

---------

Co-authored-by: DizzyEggg <jajkodizzy@wp.pl>
2023-11-19 23:18:47 +01:00
Bassoonian
59a7d2cb92 Update colors and add config 2023-11-19 18:30:18 +01:00
Bassoonian
8a772b729a Merge branch 'nature_color' of https://github.com/DizzyEggg/pokeemerald into naturecolors 2023-11-19 18:23:47 +01:00
Alex
4cb03d4add
Adds Raging Bull and various fixes (#3552)
* Adds Raging Bull and various fixes

* fix compiling on abgcc

* syrup bomb anim fix

* sticky syrup anim in link battles

* fix sticky syrup in link battles

* fix battler index

---------

Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-11-19 17:45:58 +01:00
Katy
b5cb92f0e2
Gen 6 Sprites/Animations For Species (#3543)
* Bunnelby Spritework

+ New pal + new animation

* Fletchling Spritework

New front sprite, animation and palettes

* Fletchinder + Talonflame Changes

New animation for Fletchinder
Spritework + animations for Talonflame

* Flabebe, Floette + Florges Changes

+ Touched up Flabebe
+ Fixed Floettes normal forms sprite
+ Added second frame to Eternal form for Floette
+ Animations changed

* Amaura Spritework

New second frame + animation (frame-by-frame)

* Chespin Spritework

Touched up chespins sprites + changed the animation.

---------

Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2023-11-18 23:48:02 +01:00
Nephrite
45d8491148 Fixed macro + implemented working Mortal Spin
It's that easy
2023-11-19 05:05:19 +09:00
Nephrite
41202a964a Initial struct change + paralysis test
Works great
2023-11-19 03:20:33 +09:00
Frank DeBlasio
42076897d3
Made function for time-based evolutions (#3369)
* Made function for time-based evolutions

* Incorporated Edu's comments and time variables

* Moved time of day begin/end variables to rtc.h

* Fixed if/else statement to pass building with modern

* Added morning

* Added ability to check if end time > beginning time

* Updated times to match SwSh

---------

Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-11-18 16:53:56 +01:00
Alex
5fa1bffa8d
Adds Glaive Rush, fixes for Plasma Fists and Relic Song (#3476)
* Adds Glaive Rush

* Fixes: Glaive Rush status is removed until users next turn

* Glaive Rush no affect

* simplify glaive rush script

* simlify script further

* leftover

* Fix Plasma Fists and Relic Song + tests

* Callnative for Plasma Fists

* Use Status Field Ion Deludge for Plasma Fists

* add assumes for flinch_status

---------

Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-11-18 15:19:38 +01:00
GriffinR
758f7446f0
Merge pull request #1959 from SnorlaxMonster/master
Rename HITMARKER_IGNORE_SAFEGUARD
2023-11-18 08:43:44 -05:00
SnorlaxMonster
190e77e9c8 Rename HITMARKER_IGNORE_SAFEGUARD
Rename HITMARKER_IGNORE_SAFEGUARD to HITMARKER_STATUS_ABILITY_EFFECT.
This flag is used exclusively by status-inflicting Abilities,
and has 3 main functions:
- Whether the effect bypasses Shield Dust
- Whether the effect bypasses Safeguard
- Which text string to display when the status condition is inflicted
   (i.e. whether it was inflicted by a move or Ability)

I believe this new name better represents what the flag actually does.
This name was structured to parallel HITMARKER_SYNCHRONISE_EFFECT.
2023-11-18 13:57:50 +11:00
Frank DeBlasio
efe4929ce2
Added Japan-only Walda PC icons (#3550)
* Added Japan-only Walda PC icons

* Added a config for the Japanese icons

* Update overworld.h with suggestions

---------

Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
2023-11-18 00:54:13 +01:00
ghoulslash
bf8c9609ae
add battle pyramid wild reqs (#2581)
* add battle pyramid wild reqs

* fix comment

* fix ice type round to match vanilla. move config to overworld

* some fixes

* BATTLE_PYRAMID_RANDOM_ENCOUNTERS define to FALSE defualt

* fix GetSpeciesName

* fix GetTotalBaseStat define, gEvolutionTable targetSpecies call

* fix wildMons call

* fix call to CheckBattlePyramidEvoRequirement

* fix arg 2 in CheckBattlePyramidEvoRequirement

* free->Free and fix evoItems ptr

* move sBurningMoves

* fix comment

fix ice type round to match vanilla. move config to overworld

some fixes

BATTLE_PYRAMID_RANDOM_ENCOUNTERS define to FALSE defualt

fix GetSpeciesName

fix GetTotalBaseStat define, gEvolutionTable targetSpecies call

fix wildMons call

fix call to CheckBattlePyramidEvoRequirement

fix arg 2 in CheckBattlePyramidEvoRequirement

free->Free and fix evoItems ptr

move sBurningMoves

BATTLE_PYRAMID_RANDOM_ENCOUNTERS defaults to false

* fix errors

* initial movesCount, abilitiesCount

---------

Co-authored-by: ghoulslash <pokevoyager0@gmail.com>
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-11-17 16:04:41 +01:00
Eduardo Quezada
508332a93f Reverted PR template tests 2023-11-17 11:59:34 -03:00
Eduardo Quezada
8f3eb1c9a5 PR template test 2 2023-11-17 11:53:25 -03:00
Eduardo Quezada
5f24bf6e77 PR template test 2023-11-17 11:49:01 -03:00
LOuroboros
efe9f6d8ab
Added battle tests for Embargo (#3555)
* Added Embargo battle tests

* Expanded Embargo doesn't prevent Primal Reversion to avoid CI failure

* Applied corrections to some of the Embargo tests
2023-11-17 13:14:37 +01:00
Eduardo Quezada D'Ottone
c46f9ec6a5
Form changing method for Shaymin Sky into Land at night (#1690)
* Form changing method for Shaymin Sky into Land at night

* Ordered form change tables

* Refactored form change type to support both night and day

* Removed added space

---------

Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-11-17 00:09:43 +01:00
Eduardo Quezada D'Ottone
b33c4952af
Clarify project's description to avoid people cloning vanilla pokeemerald (#3570) 2023-11-16 23:32:58 +01:00
Frank DeBlasio
8981897c9b
Fixed logic to allow Shadow Tag to work (#3549)
* Fixed logic to allow Shadow Tag to work

* Fixed which boolean is changed

* Reverted boolean change and updated B_SHADOW_TAG_ESCAPE comparison

---------

Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
2023-11-16 21:36:04 +01:00