atiran/sovereignx
3
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
sovereignx/test/battle/move_effect
History
Nephrite 65c508d193
Secondary effects overhaul minor follow-up (#4062) 
* settwoturnstring command

* Unified two-turn attacks and Meteor Beam

To do: Solar Beam

* Solar Beam

Also fixed various function, removed EFFECT_GUST (who knows why that exists?)

* Updated Solar Beam + tests

* Redid two turn move + animations logic

Removed pointless various function; to do: remove Skull Bash, fix AI test

* Removed now-pointless flag

* Removed Skull Bash

And temporarily commented out failing AI tests

* Removed Sky Uppercut effect

Not sure when or why this was ever necessary

* Removed BattleScript_EffectSemiInvulnerable

Now uses BattleScript_EffectTwoTurnsAttack. Kept the effect; used the argument field to determine which STATUS3 such moves should apply but added a function to jump over weather checks in BattleScript_EffectTwoTurnsAttack if the current move is semi-invulnerable (since the instant-fire weather check and STATUS3 use the same field)

* Applied review changes

* Replaced VARIOUS with callnative

Tried to fix test but couldn't :/ wtf is going on

* Fixed one AI test

Cant fix the other...

* Added KNOWN_FAILING to failing AI tests

Separated them out into their own test

* Optimised script, overhauled charge turn string setting

Condensed multiple confusing macros into one, jumpifweathercheckchargeeffects. Script now tweaked and trimmed, string ids for charge turns now added to argument along with status3 (thanks to compression macro) and instant-fire-weather for semi-invulnerable and two-turn moves respectively. Also introduced a savedStringId in gBattleScripting to make string selection work.

* Unified two turn move tests + minor corrections

* Added semi-invulnerable move tests

Set the Razor Wind test to known failing - something to do with its animation?

---------

Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2024-02-04 23:02:59 +01:00
..
absorb.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
accuracy_down.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
after_you.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
ally_switch.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
assist.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
attack_down.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
attack_up.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
attack_up_user_ally.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
aura_wheel.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
aurora_veil.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
axe_kick.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
barb_barrage.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
beak_blast.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
belly_drum.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
bide.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
brick_break.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
bug_bite.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
burn_hit.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
burn_up.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
chilly_reception.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
clanging_scales.c Renamed healBlockBanned to healingMove (#3981) 2024-01-12 18:41:45 +01:00
collision_course.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
confusion_hit.c Merge branch 'upcoming' into secondary_effects_overhaul 2024-01-01 20:40:11 +09:00
corrosive_gas.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
court_change.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
defense_down.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
defense_up.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
defog.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
dire_claw.c Tweaked helper functions 2023-12-30 17:42:53 +09:00
doodle.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
double_shock.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
dream_eater.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
embargo.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
encore.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
evasion_up.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
explosion.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
fickle_beam.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
fillet_away.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
flinch_hit.c Tweaked helper functions 2023-12-30 17:42:53 +09:00
flinch_status.c Tweaked helper functions 2023-12-30 17:42:53 +09:00
fling.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
focus_punch.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
freeze_hit.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
glaive_rush.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
haze.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
heal_pulse.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
healing_wish.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
hex.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
hit_escape.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
hit_set_entry_hazardss.c Tweaked helper functions 2023-12-30 17:42:53 +09:00
hit_set_remove_terrain.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
hit_switch_target.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
hurricane.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
hydro_steam.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
infernal_parade.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
ion_deluge.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
ivy_cudgel.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
jaw_lock.c Tweaked helper functions 2023-12-30 17:42:53 +09:00
knock_off.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
last_resort.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
leech_seed.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
make_it_rain.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
max_hp_50_recoil.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
metronome.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
mind_blown.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
mirror_move.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
moonlight.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
morning_sun.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
multi_hit.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
octolock.c fixes tests 2023-10-25 10:18:59 +02:00
ohko.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
paralyze_hit.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
pay_day.c Fix stat drop in doubles for single target moves (#4003) 2024-01-16 09:25:40 -03:00
photon_geyser.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
plasma_fists.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
pledge.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
poison_hit.c Tweaked helper functions 2023-12-30 17:42:53 +09:00
population_bomb.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
protect.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
psychic_noise.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
pursuit.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
rage_fist.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
rampage.c Renamed seteffectwithchance to setadditionaleffects 2023-12-30 20:29:09 +09:00
rapid_spin.c Apply suggestions from code review 2024-01-12 02:13:55 +09:00
recoil.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
recoil_if_miss.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
reflect.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
reflect_type.c Made Reflect Type handle 3rd types (#3303) 2023-10-23 10:08:36 +01:00
relic_song.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
revival_blessing.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
roar.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
roost.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
salt_cure.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
semi_invulnerable_moves.c Secondary effects overhaul minor follow-up (#4062) 2024-02-04 23:02:59 +01:00
shed_tail.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
shell_trap.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
sleep.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
sp_atk_two_down.c Fix stat drop in doubles for single target moves (#4003) 2024-01-16 09:25:40 -03:00
special_attack_down.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
special_attack_up_3.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
spikes.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
spin_out.c Tweaked helper functions 2023-12-30 17:42:53 +09:00
stealth_rock.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
sticky_web.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
stockpile.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
strength_sap.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
stuff_cheeks.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
substitute.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
synthesis.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
syrup_bomb.c Syrup Bomb / Sticky Syrup addition (#3948) 2024-01-09 13:37:07 +01:00
tailwind.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
take_heart.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
teatime.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
techno_blast.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
telekinesis.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
teleport.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
throat_chop.c Review changes 2024-01-10 00:55:43 +09:00
thunder.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
torment.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
toxic.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
toxic_spikes.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
tri_attack.c Tweaked helper functions 2023-12-30 17:42:53 +09:00
triple_arrows.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
triple_kick.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
two_turn_moves.c Secondary effects overhaul minor follow-up (#4062) 2024-02-04 23:02:59 +01:00
upper_hand.c Adds move Upper Hand (#4085) 2024-02-01 12:23:58 +01:00
venoshock.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00
weather_ball.c Move data unification (#3999) 2024-01-29 08:51:32 -03:00