devraza/rustboyadvance-ng
Archived
1
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity
351 commits 1 branch 1 tag 4 MiB
Commit graph

309 commits

Author SHA1 Message Date
Michel Heily
b22388252b gpu: Cleanup #1 
Former-commit-id: a40fca25eae76afb4d581d8da1404a5d52c9efab
 2019-12-28 21:13:44 +02:00
Michel Heily
b13c3026c8 gpu: Refactor Gpu::current_scanline -> Gpu::vcount 
Former-commit-id: fe17235bd7e953195e6348e4670bf0520a78270a
 2019-12-28 20:25:27 +02:00
Michel Heily
cc4f328691 timers: Fix wrong irq number 
Timers were triggering DMA interrupts, wonder why.. ><


Former-commit-id: 4fd2781a4bf71d0c0ebc1badae003d76a781ee75
 2019-12-28 17:03:59 +02:00
Michel Heily
d8545dd8cd sdl2: Use callbacks with ring buffer instead of audio queue. 
Better latencies, and also fast-forward (aka Turbo mode) sounds normal
this way.


Former-commit-id: d1075087e847c765a871157a7973c897575ef4d7
 2019-12-28 17:03:59 +02:00
Michel Heily
cb54f4d1a3 cosmetic: Notify vblank/hblank DMA inside of Gpu 
Former-commit-id: de53e1ed3e2c1df19ef878c4b84893b92ee46064
 2019-12-27 16:31:18 +02:00
Michel Heily
5acd7ddd71 Solve the sound clicking issue in Kirby! 
The symptom of the problem was in the form of a rythmic click sound popping in the left channel.

Diving deep into Kirby's binary, I found out that channel B and channel
A are playing too different pcm buffers simultationsly: A is enabled for
the right channel and B is enabled for the left.

I found out that the game's sound driver was using VCOUNT in order to syncornize the audio,
but in some occassions the fifo DMA was not disabled in time, causing the DMA to
fill the fifo in additional 16 bytes of garbage residing next to channel
B's pcmBuffer.

After a thorough check-up of the GPU state machine, I find out that I
stay in VBLANK for 1 line too long, and that's what caused the audio
buffer to de-sync with the gpu emulation.

This commit fixes this issue.


Former-commit-id: e0f20bd01b8abf62da486e2501cff197a9a22763
 2019-12-27 15:28:06 +02:00
Michel Heily
c9e80f4f60 Remove dead code 
Former-commit-id: 5d5768ca6b73060197d9bacda61cba4c03804ad0
 2019-12-27 12:41:36 +02:00
Michel Heily
c2ac3c5a10 Improve DMA code 
Former-commit-id: 8fdb6195ceb323aebd8a26da98fe286d89ef8363
 2019-12-27 12:37:32 +02:00
Michel Heily
b026ad4ed3 Add simple resampling using cosine interpolation, seems to work~ish. 
Still have clicks & delays in my audio output.


Former-commit-id: 46707fc773d8083fbba1ec614e3e0a3e53866b98
 2019-12-23 01:37:45 +02:00
Michel Heily
ac9a17713b Fix address alignment bug in IoDevices::write_8 
Former-commit-id: b89d469e9f2d11f21df3af2b4299cf9928abbd59
 2019-12-23 01:37:45 +02:00
Michel Heily
10d0934f82 GameBoyAdvance: Use dyn traits instead of generic types 
"Performance hit" is not significient


Former-commit-id: 809dea4cdbf9579d8e9d18de95b3c9a05723c68f
 2019-12-23 01:37:45 +02:00
Michel Heily
398e66b723 More work. DMA sound seems to work, but sounds very crappy. 
Former-commit-id: cc9f2877f9ccc1b05163af3fd35ff07efa8e3067
 2019-12-23 01:37:45 +02:00
Michel Heily
fefeddbc40 Continue working on DMA sound. 
Cleanup timer.rs
run cargo fmt
restore debugging continue&frame commands
Fix bug introduced in previous commit causing the bios animation to
hang


Former-commit-id: 188acaa1121503a97f2d3be816f6f57835e17fe1
 2019-12-23 01:37:45 +02:00
Michel Heily
70cb99161d Start working on DMA sound 
Former-commit-id: 066210a86a7836b6ae1dfd5ce229d050cbe00ca4
 2019-12-23 01:37:45 +02:00
Michel Heily
38e504515b rba-sdl2: Trying spin_sleep crate 
Former-commit-id: 1c6a36a1a61be3949080a8c86915235aaf25d0e5
 2019-12-20 19:02:33 +02:00
Michel Heily
31eb12cb6a Add "press SPACE to turbo" to sdl2 binary, like in old-school emulators :P 
Former-commit-id: 95dfddfac193ac846f179ec607a8f7c3fc0e21a4
 2019-12-20 18:11:14 +02:00
Michel Heily
cb630ffb8e Optimise SDL2 rendering code 
Former-commit-id: 4a0e4f57a97c98bc8a930901bd1ba2125d96138b
 2019-12-20 17:48:24 +02:00
Michel Heily
3c7a734270 Add minifb based binary, currently it has better performance than the SDL2. 
SDL2 rendering is really bottlenecking currently..


Former-commit-id: 8e04b799f248209a138990b2389e740b0d1d9f0f
 2019-12-20 16:31:26 +02:00
Michel Heily
385016f24a Use Rc<RefCell<T>> to have the GameboyAdvance struct hold references to platform video,audio,input combo 
Former-commit-id: bfe233a333790fe1bad1038bd553a3fe244e57fa
 2019-12-20 15:11:26 +02:00
Michel Heily
aee86d85c8 Start Sdl2AudioPlayer 
Former-commit-id: 905b846d751db577bc213f1ca38a4c0e72558cfa
 2019-12-20 15:11:26 +02:00
Michel Heily
04d2edfc01 Refactor "backend" concept 
See plat/sdl2


Former-commit-id: 5f7c9625467003d5b73307959095eb5365db523e
 2019-12-20 15:11:26 +02:00
Michel Heily
326bb06e82 Move rom file loading logic to Cartridge 
Former-commit-id: 29045310d380657819529333b5231a98be5fa8c1
 2019-12-20 15:11:26 +02:00
Yonatan Goldschmidt
763ee217d8 Add WIP sound controller and backend 
Former-commit-id: 50e5bb71a620ac138a880872ae1f13f1c0c0604c
 2019-12-20 15:11:26 +02:00
Yonatan Goldschmidt
7cfa4bb07d Remove some unused imports 
Former-commit-id: 64bd0e7419cd374f6321fcc3bd9fdee7a241592b
 2019-12-20 15:11:26 +02:00
Yonatan Goldschmidt
41deb1631c Print read/writes to unhandled sound registers 
Former-commit-id: f63a98b61866c872ef52dd972db3ef28054be432
 2019-12-20 15:11:26 +02:00
Michel Heily
29df4231e9 Protect unused bits from being set in window flags 
Former-commit-id: a618b4775de7276618dd11ace2e140d200fb066b
 2019-12-20 15:07:23 +02:00
Michel Heily
cb36db688e Fix LSR#0 
Former-commit-id: 7cfcc0b8f6e0849c9090148f2cc381b3419abd39
 2019-12-20 15:06:21 +02:00
Michel Heily
11219dab7e tmpfix: Reset scanline in scanline_aff_bg placeholder 
Former-commit-id: a4f910210bfa186611d771202a4ef96e97fe75b7
 2019-11-21 17:46:51 +02:00
Michel Heily
42904782f7 Fix bios infinite loop caused by changes in f5a8ca8de8a5b007ace879f50fb97ead3e976347 [formerly e885e9ff1393dd14f5e4132c71a7641d658399cb] 
This commit removed the dummy iomem buffer, and the bios busy waits on
REG_SOUNDBIAS in order to proceed.


Former-commit-id: 1fb8e2b621bed22da55781adcaae748aaaf845b9
 2019-11-21 17:36:58 +02:00
Michel Heily
9856f04e05 Implement affine sprites. Displaying TONC affine sprites demos correctly. 
Former-commit-id: 6f8aaec9cb844a685a1b07f7d09a0535039133b8
 2019-11-20 06:25:38 +02:00
Michel Heily
64a877369d Reorganize sprite rendering code 
This commit contains changes I forgot to push way earlier.


Former-commit-id: 793bfc2bde25f2299136e6b196f2770ee1db8d19
 2019-11-20 05:33:51 +02:00
Michel Heily
bb08b2f48e Improve timers 
Former-commit-id: 02985b13aec6ac4ce52952b9bc505e48ebbb94e6
 2019-11-20 05:20:46 +02:00
Michel Heily
3c3129c73c Minor fixes 
Fix LSR integer underflow.
Change SWI LR calculation


Former-commit-id: 6a298719e380c3a01f70c3b05d9f3507638398d5
 2019-11-20 05:04:54 +02:00
Michel Heily
3c3e8c35b4 Fix wrong sprite size calculation 
This solve many graphical glitches with normal sprites in:

- Kirby - Nightmare in Dreamland
- DragonBall Advanced Adventure
- DragonBall Supersonic Warriors


Former-commit-id: aa7813720ca86c0ff0a3111f245d35765112d750
 2019-11-16 20:18:28 +02:00
Michel Heily
49ef59b8e9 fixup! Improve the debugger 
Former-commit-id: 9ca33bd4f8273a6be66cec6a8218664a7aada376
 2019-11-16 18:48:24 +02:00
Michel Heily
4c3862543e Fix bug in MODE0 where BG3 would not be rendered due to inconclusive range, thank you Rust. 
Former-commit-id: 6dd8ce110d212083cba394f08488d4fffdf6d015
 2019-11-16 18:17:53 +02:00
Michel Heily
46931a1f6a Fix CPU bugs, KIRBY BOOTS! 
- Bad LSR emulation caused an edge-case making allmost all of the game I tested fail to boot past intro.
- Incorrect sign extension of offset5 in THUMB caused bad address calculation.

Kirby boots with rendering glitches, I played past the first 2 boses
without crashes.


Former-commit-id: 8ea0ad6eb0f70e6dc23d1f2fcc44c8c0b3448fba
 2019-11-16 18:17:53 +02:00
Michel Heily
ccfff31123 Improve DMA 
According to GBATEK:
The SAD, DAD, and CNT_L registers are holding the initial start
addresses, and initial length. The hardware does NOT change the content
of these registers during or after the transfer.

The actual transfer takes place by using internal pointer/counter
registers. The initial values are copied into internal regs under the
following circumstances:

Upon DMA Enable (Bit 15) changing from 0 to 1: Reloads SAD, DAD, CNT_L.

Upon Repeat: Reloads CNT_L, and optionally DAD (Increment+Reload).


Former-commit-id: 1e606dc88603a4600a79a341ef17fe8ccb482871
 2019-11-16 18:17:53 +02:00
Michel Heily
4f2fbc2af2 More memory map bug fixes (Wrong ROM masks and more) 
Former-commit-id: 4149a16965d111fb95629e8381269eae4f84c0c4
 2019-11-16 18:17:53 +02:00
Michel Heily
f7dc417e94 Fix accesses outside of IO region 
Former-commit-id: dc874b6d28370cf7256156f2502bd2dc56a0a3fd
 2019-11-16 18:17:53 +02:00
Michel Heily
b9d0857acc Don't allow IRQs when pipeline is reloading 
Former-commit-id: a51d3671dfabab422f2ad880b3cbe1bac65d442b
 2019-11-16 18:17:53 +02:00
Michel Heily
b288625b9a Improve the debugger 
- Add tracing of opcodes and potentially more stuff
- Add option to run a script file at the beginnig (I use it to redirect
traces to a file)
- Support breakpoints again


Former-commit-id: 4e988d6bc1a59456c96547f0320a6d9abedcae00
 2019-11-16 18:17:53 +02:00
Michel Heily
7e98af80c2 Fixes to ALU, passing mGBA carry tests 
Former-commit-id: 14a4293b2511c7c63a920e6344e89b209ca7c5ee
 2019-11-16 18:17:53 +02:00
Michel Heily
88b908f2a0 Implemenet GBA Halt control 
Former-commit-id: 1b09cb881b4e68f410abe6e1f6a161cd55a4626a
 2019-11-12 18:55:26 +02:00
Michel Heily
dcab1e6328 Improve GPU state machine. 
This fixes the glitch in dma_demo.gba where the rendering of the circle
was off by a scanline.


Former-commit-id: 907fefd548b6557ce46e06a99d0bc6ab83a8f332
 2019-11-12 18:22:00 +02:00
Michel Heily
1d088accb8 mGBA test suite now boots! 
Fix tons of bug and reimplemented some of the core code.
Add a neat feature for debug builds:
When the cpu "swi 0x55" instruction, a breakpoint is triggered on the
host.


Former-commit-id: 959249df4374327d90b2503d7a45f8d5d27995a6
 2019-11-12 18:22:00 +02:00
Michel Heily
c117cbe924 Make the debugger work again, but currently breakpoints are not supported. 
Added memory write command and the ability to pause the debugger with Ctrl-C


Former-commit-id: 83d141fa191dadefb84f7c9de163631a69af8324
 2019-11-12 18:22:00 +02:00
Michel Heily
c78a111ad4 Implement DMA, WIP 
I have fought very hard against the rust ownership model,
In the end for DMA to play nice with my code, I had to resort to use
unsafe code for now..

The DMA implementation itself is not accurate to say the least, but will
have to do for now.

Tonc's dma_demo.gba plays but with a visual glitch.


Former-commit-id: 3b9cdcb2d09c78701290f2c48b77f9f3487e85c9
 2019-11-09 19:44:55 +02:00
Michel Heily
3a1d5c10ce Fix many bugs, refactor many things.. 
Passing: Armwrestler, cpu_test by Dead_Body

Former-commit-id: 80d815d110c5341515dd01c476a0d7e25ecb66a8
 2019-11-09 01:06:24 +02:00
Michel Heily
2bd8b56bc6 Fix that DAMN bug. 
Long story short, I've been hunting this bug for a while now.
While passing armwresteler tests, I still had an emulation bug which
causeed libgcc's iprintf to produce bugged strings.

In order to find it, I've used https://github.com/fleroviux/NanoboyAdvance/
And patched it to produce a formatted log of every step of the execution
of iprintf:
{OPCODE} {PC} {R0} {R1} ... {R14} {FLAGS}
Did the same on my emulator and searched for differences.

Found out the a "CMP r3, #0x0" instruction turned off the carry flag
when it shouldn't. Found this sad function, the check I'm using for
carry flag is meaningless when done on signed integers. :sigh:


Former-commit-id: 871d2581921796dae9bf4f5fdaa45c6ad46aebec
 2019-11-06 00:49:59 +02:00
Michel Heily
7cc1a50d12 Support zip files and add --no-framerate-limit 
Former-commit-id: 62a7122fb0b3e832eeb3cbf347a0966e4cd32d50
 2019-09-11 21:26:40 +03:00
Michel Heily
fa211fa77e Fix thumb NEG instruction. Finally pass armwrestler! 
This one took me quite a bit. :/


Former-commit-id: f08537dda5a62076c3faff31a898c0a585102526
 2019-09-10 01:01:49 +03:00
Michel Heily
441482516e Get rid of timer.rs spam 
Former-commit-id: 2d2ce31ad77840e4a8685257a77f824da21992ba
 2019-09-09 20:07:45 +03:00
Michel Heily
9ebb0d3d2d Fix OBJ priorities (tonc prio_demo.gba works) 
Former-commit-id: a55b3be7688ef7e1446a54c38fc5ddb5034cb4b9
 2019-08-31 14:13:21 +02:00
Michel Heily
ba9b4662d4 Fix SBC and RSC instructions 
Needed to add 1-C and not substract 1-C


Former-commit-id: 339201a2cd41d777d3b3204995e698182032c80d
 2019-08-31 14:10:05 +02:00
Michel Heily
eab08992b9 Add normal sprite rendering support. 
Former-commit-id: 04c3d7ec3051ce4c5aeacb552688c0217b3b3d3b
 2019-08-27 23:15:22 +03:00
Michel Heily
8abebbe844 Implement Window special effect (win_demo.gba works, excpet the sprite) 
Former-commit-id: 511d04045bbb678ceec39e34c483f04db154997b
 2019-08-24 00:36:48 +03:00
Michel Heily
1d2d950729 Fix IoRegs::write_8 
Former-commit-id: 9877e7f42fefafb71dd319287e01d55926d4d12c
 2019-08-24 00:33:01 +03:00
Michel Heily
f40ee148ea Add sdl2 key mappings 
Former-commit-id: 9b3aa941ffca9a679d9ce70ca43d6396d4dfe5ff
 2019-08-23 22:47:12 +03:00
Michel Heily
4a72a1035f Fix Rgb15::is_transparent bug 
Former-commit-id: f12729b993ec9bef94a58a4d48982c7d3939c45b
 2019-08-17 21:27:36 +03:00
Michel Heily
639993edd7 Add blending and mosaic SFX, and cleanup code. 
Former-commit-id: b9f0ccaf1820da61f49ebeb2af5beff5cccd722f
 2019-08-13 22:15:36 +03:00
Michel Heily
c4b24fde02 Refactor GPU registers wrappers to a separate module 
Former-commit-id: 3e7c6326232cd761674061ceed758a56412da17f
 2019-08-11 22:35:32 +03:00
Michel Heily
52ef793759 Move gpu module to a separate folder, to allow for later cleanup. 
Also, get rid of "render" command


Former-commit-id: 7dd004f3ff8f55686665adead497ebae4f873379
 2019-08-11 22:28:52 +03:00
Michel Heily
edf2efcce5 Fix panic if debugger histfile does not exist 
Former-commit-id: a355a783b4d513dd3c65ef41de6a7604853a7b0f
 2019-08-11 21:50:44 +03:00
Michel Heily
9064ae9cf8 Fix bug in IoRegs::write_32 
Former-commit-id: a2c5b57a0e7da2fa0f080d70acd77b8643bc4742
 2019-08-11 21:50:44 +03:00
Michel Heily
3f6a52cae6 Add sdl2 backend 
Currently has bad performance


Former-commit-id: 384ef6b5cd7b1e1baeb6adfbc0b299b0d07d7a5d
 2019-08-10 18:14:59 +03:00
Michel Heily
acd0e4f338 cpu: Refactor instructions to use explicit cycle counting. 
The way cycles were counted up untill now was not accurate enough,
I've avoided doing so because the instruction implementation looks
bloated this way, but I've had problems with cycle accuracy with tonc's
timer demo.

This is not entirely correct though, and I'm 100% sure there are some
mistakes, but works good enough for now.


Former-commit-id: 748faaf99fe2f42925c0a2110192c6a01e5d27d4
 2019-08-08 20:05:09 +03:00
Michel Heily
d86cc87c79 Add WAITCNT, and refactor cycle calculation 
Former-commit-id: e1ee5c9ce1f1db549fddd80907467da51e63b676
 2019-08-07 09:50:33 +03:00
Michel Heily
fe071bf1ec Fix timer bugs 
Former-commit-id: 9839368895dca306b66a095ab0b9386c77bd2c12
 2019-08-07 09:45:10 +03:00
Michel Heily
c72bbb96fd [WIP] Timers 
Seems to work, but the cycle's are not accurate so they run slowly


Former-commit-id: a0b80acb4b68ed64caa535a0ec9f75a081d3aed4
 2019-08-05 09:53:41 +03:00
Michel Heily
c7dd713605 The big ioregs refactoring. 
This commit refactors the ioregs:
* Use bitfield crate to implement the GPU ioregs.
* IoRegs are stored in their own variables bindings (i.e, Gpu related ioregs are now fields of the Gpu struct)
  - This optimize performance quiet alot from my testings - since every scanline was accessing deseralizing ioregs from sysbus. (Getting constant 59fps now)
* For now, comment out DMA model

Also, cleaned the code up to eliminate rustc warnings.


Former-commit-id: 9077695c446ebd1a71783acfdd9819245aa02d7a
 2019-08-03 00:24:15 +03:00
Michel Heily
9f0df9af06 optimization: Optimize VRAM accesses from within the gpu. 
Not going through the memory mapping anymore.

Also, this commit wraps the gpu pixeldata with a struct


Former-commit-id: d7b706d9de61bac7909e10d6bbe092968e6acc9f
 2019-08-02 18:04:35 +03:00
Michel Heily
eb2a1a02fe Implement background scrolling! 
tonc's brin_demo.gba now works as intended :)


Former-commit-id: 596c063c5968534f42e42f52203c85262b9c6fa2
 2019-07-31 00:52:46 +03:00
Michel Heily
f862209911 Support axis flip for tiles 
Former-commit-id: daefb380ab2dfcee600297690dcc0c7c1a37f911
 2019-07-29 09:46:12 +03:00
Michel Heily
90edebbe82 Align to halfword for thumb branch long instructions 
Former-commit-id: f75e4baf003dcb7c535db3692383cc95575dfd81
 2019-07-29 01:55:16 +03:00
Michel Heily
e962150aaf Start working on Interrupts. 
it kinda works now, but needs testing.


Former-commit-id: 8510314cce248a737d492d935cf5b48f86d920ed
 2019-07-29 01:28:22 +03:00
Michel Heily
66a484e3ae Fix mode0 calculation of tile map entries. 
tonc's hello.gba demo now works correctly :)


Former-commit-id: ead3a01e810f69503abbe8bddd0853433862549b
 2019-07-27 23:28:00 +03:00
Michel Heily
f39095a03b Fix thumb conditional branch offset 
Former-commit-id: b42f233b7f2ca5d427b0e36860a305f7e1a26a1d
 2019-07-27 21:30:27 +03:00
Michel Heily
df48f307f0 armwrestler-fix: Fix post indexed LDR_STR when rd==rn 
Former-commit-id: b886c969c2d570fbb831eeeddc0f65ad575cfccb
 2019-07-27 21:28:43 +03:00
Michel Heily
477b4f45fd Fix thumb MUL not setting the flags 
Former-commit-id: b43e35a7fa2894fcc5cef7eeae9d74123e40219b
 2019-07-27 20:25:59 +03:00
Michel Heily
44426b5f0e Impl arm SWP 
Also ran some rustfmt


Former-commit-id: 30480e79d7f2926d5a5f15db20427179a672a78c
 2019-07-27 20:20:58 +03:00
Michel Heily
e06c77b6fd armwrestler-fix: Fix MULL_MLAL instructions 
Also fix disassembly for MULL_MLAL


Former-commit-id: f535b2db7edb5d056160699436dbeb0c15e61388
 2019-07-27 18:57:20 +03:00
Michel Heily
7429236471 Fix mistake in UMLAL 
Former-commit-id: 6fe9bdf5471b71b58dcf9ee9ffa03c41b24e6301
 2019-07-26 17:55:50 +03:00
Michel Heily
1b5626a1a7 armwrestler-fix: Refactor barrel shifter and fix ALU carry flag, hopefully for good. 
Passing most of armwrestler ALU tests (still have bugs in UMULL and
SMULL)


Former-commit-id: 3c57ca9b5360b5c9bba74b00a5bede5a8cc496af
 2019-07-26 17:55:50 +03:00
Michel Heily
24483456ed armwrestler-fix: Fix writeback for LDR where rd==rn 
Instead of returning an Err, the writeback should just be disabled.


Former-commit-id: 91636a4eeaf76d0dbd11d250202671fcf8aaa4e6
 2019-07-22 20:33:31 +03:00
Michel Heily
009e46f6d5 armwrestler-fix: Properly handle misaligned addresses LDR/LDRH/LDRSH 
Former-commit-id: 742a7c2b8413fa9d45df1575a0b14b8d1ab697c4
 2019-07-22 20:25:40 +03:00
Michel Heily
2a66e525b1 Fix thumb disassembly of LDMIA/STMIA 
Former-commit-id: b04b07f181fff82869503671dd0f500a6c3e5fb1
 2019-07-22 09:31:35 +03:00
Michel Heily
2fb6f3c884 Implement (psr / usr bank) transfers for LDM_STM 
Former-commit-id: 140e6a6c75f65f08f645b1a0ff2ca7c065438ce4
 2019-07-22 09:21:49 +03:00
Michel Heily
0b5902c52e Implement special MRS 
Former-commit-id: 1af358887ef71344987f72d65612095c72565f43
 2019-07-22 09:21:45 +03:00
Michel Heily
c0d437b1a1 Fix exceptions and dataprocess mode change 
Former-commit-id: 5892131496904b621398212b9dfc077242fa9557
 2019-07-22 01:16:48 +03:00
Michel Heily
7501adfd12 Implement thumb17 (Swi) 
Former-commit-id: 62d7e14e9b84e74d9236e1f0a5e961ae805f861c
 2019-07-22 01:15:58 +03:00
Michel Heily
eea26d2393 thumb: Change ordering when decoding thumb instruction. 
This fixes a bug where "swi" instructions are decoded as conditional
branches.

The order really matters here, because Swi instructions are actually
conditional branch with illegal condition code.


Former-commit-id: 0024a8b53386a510dd321c157391c99a2af29223
 2019-07-22 00:25:26 +03:00
Michel Heily
387e26fad9 Add support for BGMode3 (tonc first.gba example now working) 
Former-commit-id: 52ac773ee2c3542ff3b046c3ea33fde02e804492
 2019-07-22 00:09:44 +03:00
Michel Heily
7e9c0e31da Add minifb backend - Armwrestler now plays ! 
Former-commit-id: d72ea9139e04624322cf3bc4a8ab330f6bb133a4
 2019-07-20 23:02:18 +03:00
Michel Heily
61e1f055f1 Model the keypad 
Former-commit-id: 4f38fa754e3ee809a7386351297decb2d7f1451f
 2019-07-20 22:58:29 +03:00
Michel Heily
53115a9a58 Refactor core functionality into a separate module 
Former-commit-id: 5d55b9eb0b63ed7c61465b4e814782165caa5002
 2019-07-20 16:46:00 +03:00
Michel Heily
0f73abaf98 Optimize instructions with "register lists" (LDM_STM) 
These instruction (probably) allocated a vector each time.


Former-commit-id: 66f724e21e1e5d667d19c1f21d2cc4fa3944faac
 2019-07-20 16:07:19 +03:00
Michel Heily
7119ba2451 Cpu: Rewrite pipeline code. 
Pipeline code was unreadable up until now, this also fixes a bug:

* Some roms have illegal instructions right after branch instructions, and
the cpu would error trying to decode them because of pipelining.


Former-commit-id: e3201c7b0d2adfc772231a3e2d5909f43c17b50f
 2019-07-20 16:03:37 +03:00
Michel Heily
1f074e20ad Refactor lcd -> gpu 
Former-commit-id: c12be139770922bac55490c76348f5406fc00f07
 2019-07-16 01:21:11 +03:00
Michel Heily
876cdfdcb3 Implement MODE4 rendering, ArmWrestler renders now! 
Former-commit-id: 4910a63b454ae9309abc0aa584a7d0bc96143538
 2019-07-15 20:49:47 +03:00
Michel Heily
1084be52b8 WIP mode0 rendering 
Former-commit-id: 6bce375f9373bbddf4522da5ecc2ea3584373847
 2019-07-15 19:23:16 +03:00
Michel Heily
9d8272b895 Fix wrong use of rust ranges in the lcd.rs module 
Former-commit-id: 73d588299baed7f5206b904f40ecf4a4e5283ef6
 2019-07-15 19:09:41 +03:00
Michel Heily
a4925b7233 Fix SP values for "--skip-bios" 
Former-commit-id: d89d3c9c6b5d062137442df4017d59dea047270f
 2019-07-15 07:31:29 +03:00
Michel Heily
0500d33cb7 Refactor bus interface 
Former-commit-id: f325cda23f5e9946b367456d82ba71bb92bdd46e
 2019-07-15 07:30:52 +03:00
Michel Heily
f08da850c7 thumb: Fix overflowing multiplication 
Former-commit-id: 5dbd45f9fd3811726aad9c32444f0dcf42d0b8be
 2019-07-13 23:33:37 +03:00
Michel Heily
ab8c067616 Flush pipelines when entering an exception 
Former-commit-id: c00754b8156ecac66cc0a72f6a7c73ee700448f0
 2019-07-13 23:33:10 +03:00
Michel Heily
fb5229705b Refactor and fix arm condition check 
Former-commit-id: 132c14fc56a21426263971e2d544ff10f072fea1
 2019-07-13 23:32:43 +03:00
Michel Heily
1747addcd3 Start modeling the Lcd Display 
Former-commit-id: 544f185c6f9eead870032170292b1cc8afc724bf
 2019-07-11 18:17:28 +03:00
Michel Heily
95f45e55a9 arm: Impl MULL_MLAL and fix writeback for post-index memory transfers 
Also some minor fixes and formatting


Former-commit-id: 4929b28cbb4eeeed5acfbdcdd19392ffa3bb0f37
 2019-07-11 18:10:58 +03:00
Michel Heily
4763f79abf arm: Impl MLA 
Former-commit-id: fe2c836bd09af165381537445dd288ca7bac24ce
 2019-07-11 00:02:39 +03:00
Michel Heily
5bc4c79d6e arm: Implement MRS 
Former-commit-id: 8c1528b2bcd08096f929c4ee940f1a1f5eac2911
 2019-07-10 23:54:45 +03:00
Michel Heily
5f625b2209 Add special case for MSR immediate 
Former-commit-id: f9fabb3c0d7c05243866b712096c2c82cf41672d
 2019-07-10 23:48:14 +03:00
Michel Heily
a9bf2d25e0 arm: Implement Arm MSR_FLAGS 
Former-commit-id: 64d2cf255304ecca02dadc55266d22bc1f92bb4c
 2019-07-10 22:35:40 +03:00
Michel Heily
4c3379615a Fix bug in RRX (defined "old_carry" after changing it >< ) 
Former-commit-id: b890d40bb57da1cc6b63d6436bc8f346131fa5bc
 2019-07-10 22:35:40 +03:00
Michel Heily
50086a8715 Fix word alignment for arm BX 
Former-commit-id: 9223259793cd8ecccb02b40c428d32315c632bff
 2019-07-10 22:35:40 +03:00
Michel Heily
2864f83681 Arm: Partially implement MUL 
Former-commit-id: 3b37f5cbe327e15be4cee56572c2230dbda48082
 2019-07-10 22:35:40 +03:00
Tamir
543161d6b8 Fix cli help lines to all follow the same structure 
Help lines all start with a capital letter and don't end with a dot


Former-commit-id: 31e65514d15540538e2de528810957e16c8b5090
 2019-07-10 12:59:48 +03:00
Michel Heily
92f65794d8 Fix writeback for Thumb LdmStm 
Former-commit-id: 00a15dc99716290da7b260b261090454d621ce8a
 2019-07-09 02:20:32 +03:00
Michel Heily
65de0c4e9d Thumb 4 - Take care of "neg" case. 
I overlooked it :/


Former-commit-id: 360eb755bcf343cddd98807e9faeff007c94cf64
 2019-07-09 01:30:24 +03:00
Michel Heily
34233fa654 alu: Fix bug in SBC and RSC ops 
Former-commit-id: 1cb23d6280e1816395c46a7571dd9f48df870202
 2019-07-09 01:29:34 +03:00
Michel Heily
19e4196384 Thumb 4 - Set flags if needed (For CMP) 
Former-commit-id: 4f5bc97375c8aa45036b025a3420331a8137da17
 2019-07-09 01:28:14 +03:00
Michel Heily
0bdf4993ee thumb: Word align PC when jumping to Arm code 
Former-commit-id: 55fa28246c45a6bd807c53ce8bf0bb5865d36564
 2019-07-09 01:27:23 +03:00
Michel Heily
6ddb136852 alu: Also fix carry detection for unsigned addition 
Former-commit-id: d405f885e2b54c23aef5faab86cc1da681bd05ec
 2019-07-09 00:40:52 +03:00
Michel Heily
6c0df33597 Finally got the barrel shifter right? 
The barrel shifter sure has lots of edge cases, need to implement tests ASAP


Former-commit-id: 989fc4477f610603154404d0ed4335619ebd6345
 2019-07-09 00:33:53 +03:00
Michel Heily
2817db4e1c alu: Fix carry detection for subtraction 
Former-commit-id: c9d8612f72ce4a002ea33446209bd7e6da0eb5aa
 2019-07-09 00:33:53 +03:00
Michel Heily
1bacb927af Fix ROR with amount > 32 
Former-commit-id: 8f88de3c55c0e452266c40944ff920175b83627e
 2019-07-08 21:03:47 +03:00
Michel Heily
9421281381 Fix THUMB 1 
I didn't send this through the ALU :/


Former-commit-id: 40b4d23dcd769496e9dcd47bbf8d472b91e6a7bf
 2019-07-08 20:58:22 +03:00
Michel Heily
f7b2b48e5d Refactor ALU code into its own module, and fix things. 
* Fix overflow flag being ignored
* Fix barrel shifter misimplementations
* Rustfmt fixes


Former-commit-id: a14d50372f7850a04b204accf4e5d8b924e4b48e
 2019-07-08 20:57:58 +03:00
Michel Heily
ecdd6e0ed4 thumb: Fix ALU ops for barrel shifter opcodes 
I kinda missed these when I read the manual ><


Former-commit-id: 7d6c21b6c3b46bf065a177c1c7f7a7a1baa6b8fa
 2019-07-08 01:47:41 +03:00
Michel Heily
163d8bda59 Fix not flushing the pipeline for "mov pc, reg" instructions 
Former-commit-id: 66136ef70b8f48d5e9f4c10b65f1e2fbd3dd3ea1
 2019-07-08 00:58:09 +03:00
Michel Heily
863838a4a4 Force R15 alignment via cpu.set_reg 
I've encounted many bugs with instructions that write PC but don't align
it.


Former-commit-id: b6a234564729f83c0b5e8adfa293227299aad4ac
 2019-07-08 00:57:18 +03:00
Michel Heily
7e7d2c5208 thumb: Fix misimplementation of THUMB 12 :( 
And this kids, is why you don't ever assume what an instruction does
without reading the manual.
Also, I called the ThumbFormat enum variant "LdrAddress", so I went
ahead and implemented as an ldr_str :/


Former-commit-id: f13833d16fba07565a0aba9d247d9754dbfc3d39
 2019-07-08 00:49:03 +03:00
Michel Heily
6eab76d52f Impose a minimum length of 4MB for the gamepak memory 
Former-commit-id: 08e66bff0bc39968e572b941da84c155a45f31c8
 2019-07-07 23:33:47 +03:00
Michel Heily
d36da30618 arm: Impl LDR_STR_HS 
Former-commit-id: 2baa0f2fb8cf855cb4626fbb1937e17f4e7d3035
 2019-07-07 23:10:17 +03:00
Michel Heily
45f3bd6264 arm: Fix STR use of R15 as the base register (Rd) 
Former-commit-id: 696733731a9996ebb90b7d4acf3341facc1ed228
 2019-07-07 22:57:21 +03:00
Michel Heily
c92bde54a1 Begin modeling DMA 
Former-commit-id: 83ab601e70666f76ed3ebfb22340c6b1868af3ac
 2019-07-07 01:47:51 +03:00
Michel Heily
c2685c14d7 Impl more thumb, Fix more things, the usual 
Former-commit-id: 02f1898bfd8dd50519f103bb367e358fc55c46e7
 2019-07-06 23:38:08 +03:00
Michel Heily
6dd48c6238 Add option to skip bios code so I can start checking out test roms 
Former-commit-id: b78c8d9807ba3097d641a57ec7fcd500b32b4d96
 2019-07-06 19:26:51 +03:00
Michel Heily
36dba78c55 More fixes 
Former-commit-id: 897cbc0fb9c12469606c48ee8a02d35bf82c2ae5
 2019-07-06 18:48:22 +03:00
Michel Heily
8dc169d25d fix: bug in some ALU opcodes 
Former-commit-id: 7e05a11a709ad7f834916afa82ec5460068363f9
 2019-07-06 18:47:42 +03:00
Michel Heily
efb5d361d6 Add PaletteView command for the debugger. 
Former-commit-id: c4e0250eea700cfbcbb9f904cde7b6bc055d3e05
 2019-07-06 16:04:43 +03:00
Michel Heily
3cc84b1b03 Model many things 
Former-commit-id: b87fa2b16b395f497cf217ea043e68404ab2f65e
 2019-07-06 15:54:07 +03:00
Michel Heily
d1ef35646f Impl Thumb LdrStrImmOffset 
Former-commit-id: 17d6f4ae1cb5f68b9fccf35536a6346e88326e77
 2019-07-06 15:51:58 +03:00
Michel Heily
600bebc9d2 Partially Impl Arm LDM_STM (give me a break) 
Manually testing seems to work, too lazy to write any tests now,
Will do it after all instructions are complete, buggy or not.


Former-commit-id: 0f36c81d6451c706408dd3c4815bfb3abea1ff44
 2019-07-05 18:39:10 +03:00
Michel Heily
4da863da9b Fix carry flag on barrel shifter ops 
Former-commit-id: 31cf2166d97fcdcca0dd9c59591f5e28b5b5f6cc
 2019-07-05 18:31:08 +03:00
Michel Heily
638e449421 Impl Thumb 18 (Branch) 
Former-commit-id: 152dab739a1fa1b9d324084fc810b8540af9c3d7
 2019-07-05 16:21:24 +03:00
Michel Heily
74329c2a0b Never leave unfinished work.. 
Former-commit-id: 91acecdaf3ec7f9de892bd9f712e3cf521e08beb
 2019-07-05 16:10:21 +03:00
Michel Heily
0c50209735 Fix wrong calculation of conditional branch offset in Thumb mode 
Former-commit-id: 4cc28b13b19b2bf45e2b0e34d9a9dc0f83f82b01
 2019-07-05 16:01:16 +03:00
Michel Heily
37117257a6 Impl Thumb 10 (load store halfword) 
Former-commit-id: 0d5e88f200613b6df2b999ecbb855ce480e73322
 2019-07-05 15:50:14 +03:00
Michel Heily
d4b6952411 Impl Thumb 19, fix warnings and rustfmt 
Former-commit-id: 8690aa25b1aa343b344776716b6213596bd1459a
 2019-07-05 15:34:52 +03:00